Enabled PHP 5.5 and 5.6 rector rules

GrahamCampbell · GrahamCampbell · commit fa42d2614cf2 · 2020-07-16T17:15:05.000+01:00
diff --git a/rector.yml b/rector.yml
@@ -14,6 +14,8 @@ parameters:
         - 'php52'
         - 'php53'
         - 'php54'
+        - 'php55'
+        - 'php56'
 
 services:
     Rector\SOLID\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector: ~
diff --git a/test/Gitlab/Tests/Api/AbstractApiTest.php b/test/Gitlab/Tests/Api/AbstractApiTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\AbstractApi;
 use Gitlab\Client;
 use Http\Client\HttpClient;
 use PHPUnit\Framework\TestCase;
@@ -48,7 +49,7 @@ protected function getAbstractApiMock(array $methods = [])
         ;
         $client = Client::createWithHttpClient($httpClient);
 
-        return $this->getMockBuilder('Gitlab\Api\AbstractApi')
+        return $this->getMockBuilder(AbstractApi::class)
             ->setConstructorArgs([
                 $client,
                 null,
diff --git a/test/Gitlab/Tests/Api/DeployKeysTest.php b/test/Gitlab/Tests/Api/DeployKeysTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\DeployKeys;
 class DeployKeysTest extends TestCase
 {
     /**
@@ -41,6 +42,6 @@ protected function getMultipleDeployKeysData()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\DeployKeys';
+        return DeployKeys::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/DeploymentsTest.php b/test/Gitlab/Tests/Api/DeploymentsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Deployments;
 class DeploymentsTest extends TestCase
 {
     /**
@@ -230,6 +231,6 @@ public function shouldShowDeployment()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Deployments';
+        return Deployments::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/EnvironmentsTest.php b/test/Gitlab/Tests/Api/EnvironmentsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Environments;
 class EnvironmentsTest extends TestCase
 {
     /**
@@ -190,6 +191,6 @@ public function shouldStopEnvironment()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Environments';
+        return Environments::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/GroupBoardsTest.php b/test/Gitlab/Tests/Api/GroupBoardsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\GroupsBoards;
 class GroupBoardsTest extends TestCase
 {
     /**
@@ -227,6 +228,6 @@ public function shouldDeleteList()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\GroupsBoards';
+        return GroupsBoards::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/GroupsMilestonesTest.php b/test/Gitlab/Tests/Api/GroupsMilestonesTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\GroupsMilestones;
 class GroupsMilestonesTest extends TestCase
 {
     /**
@@ -134,6 +135,6 @@ public function shouldGetMilestonesMergeRequests()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\GroupsMilestones';
+        return GroupsMilestones::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/GroupsTest.php b/test/Gitlab/Tests/Api/GroupsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Groups;
 class GroupsTest extends TestCase
 {
     /**
@@ -523,7 +524,7 @@ public function shouldRemoveVariable()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Groups';
+        return Groups::class;
     }
 
     /**
diff --git a/test/Gitlab/Tests/Api/IssueBoardsTest.php b/test/Gitlab/Tests/Api/IssueBoardsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\IssueBoards;
 class IssueBoardsTest extends TestCase
 {
     /**
@@ -227,6 +228,6 @@ public function shouldDeleteList()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\IssueBoards';
+        return IssueBoards::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/IssuesTest.php b/test/Gitlab/Tests/Api/IssuesTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Issues;
 class IssuesTest extends TestCase
 {
     /**
@@ -677,6 +678,6 @@ public function shouldGetIssueParticipants()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Issues';
+        return Issues::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/JobsTest.php b/test/Gitlab/Tests/Api/JobsTest.php
@@ -225,6 +225,6 @@ public function shouldPlay()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Jobs';
+        return Jobs::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/KeysTest.php b/test/Gitlab/Tests/Api/KeysTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Keys;
 class KeysTest extends TestCase
 {
     /**
@@ -21,6 +22,6 @@ public function shouldShowKey()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Keys';
+        return Keys::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/MergeRequestsTest.php b/test/Gitlab/Tests/Api/MergeRequestsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\MergeRequests;
 class MergeRequestsTest extends TestCase
 {
     /**
@@ -839,7 +840,7 @@ protected function getMultipleMergeRequestsData()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\MergeRequests';
+        return MergeRequests::class;
     }
 
     /**
diff --git a/test/Gitlab/Tests/Api/MilestonesTest.php b/test/Gitlab/Tests/Api/MilestonesTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Milestones;
 class MilestonesTest extends TestCase
 {
     /**
@@ -114,6 +115,6 @@ public function shouldGetMilestonesIssues()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Milestones';
+        return Milestones::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/ProjectNamespacesTest.php b/test/Gitlab/Tests/Api/ProjectNamespacesTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\ProjectNamespaces;
 class ProjectNamespacesTest extends TestCase
 {
     /**
@@ -43,6 +44,6 @@ public function shouldShowNamespace()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\ProjectNamespaces';
+        return ProjectNamespaces::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/ProjectsTest.php b/test/Gitlab/Tests/Api/ProjectsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Projects;
 class ProjectsTest extends TestCase
 {
     /**
@@ -1996,6 +1997,6 @@ public function shouldDeleteAllMergedBranches()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Projects';
+        return Projects::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/RepositoriesTest.php b/test/Gitlab/Tests/Api/RepositoriesTest.php
@@ -626,6 +626,6 @@ public function shouldGetMergeBase()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Repositories';
+        return Repositories::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/ScheduleTest.php b/test/Gitlab/Tests/Api/ScheduleTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Schedules;
 class ScheduleTest extends TestCase
 {
     /**
@@ -123,6 +124,6 @@ public function shouldRemoveSchedule()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Schedules';
+        return Schedules::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/SnippetsTest.php b/test/Gitlab/Tests/Api/SnippetsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Snippets;
 class SnippetsTest extends TestCase
 {
     /**
@@ -236,6 +237,6 @@ public function shouldRevokeSnippetAwardEmoji()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Snippets';
+        return Snippets::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/SystemHooksTest.php b/test/Gitlab/Tests/Api/SystemHooksTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\SystemHooks;
 class SystemHooksTest extends TestCase
 {
     /**
@@ -77,6 +78,6 @@ public function shouldRemoveHook()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\SystemHooks';
+        return SystemHooks::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/TagsTest.php b/test/Gitlab/Tests/Api/TagsTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Tags;
 class TagsTest extends TestCase
 {
     /**
@@ -150,6 +151,6 @@ public function releaseDataProvider()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Tags';
+        return Tags::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/UsersTest.php b/test/Gitlab/Tests/Api/UsersTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Users;
 class UsersTest extends TestCase
 {
     /**
@@ -721,7 +722,7 @@ public function shouldGetCurrentUserInactiveImpersonationTokens()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Users';
+        return Users::class;
     }
 
     /**
diff --git a/test/Gitlab/Tests/Api/VersionTest.php b/test/Gitlab/Tests/Api/VersionTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Version;
 class VersionTest extends TestCase
 {
     /**
@@ -24,6 +25,6 @@ public function shouldShowVersion()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Version';
+        return Version::class;
     }
 }
diff --git a/test/Gitlab/Tests/Api/WikiTest.php b/test/Gitlab/Tests/Api/WikiTest.php
@@ -2,6 +2,7 @@
 
 namespace Gitlab\Tests\Api;
 
+use Gitlab\Api\Wiki;
 class WikiTest extends TestCase
 {
     /**
@@ -118,6 +119,6 @@ public function shouldRemoveWiki()
 
     protected function getApiClass()
     {
-        return 'Gitlab\Api\Wiki';
+        return Wiki::class;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\DeployKeys;`
`5`	`6`	`class DeployKeysTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -41,6 +42,6 @@ protected function getMultipleDeployKeysData()`
`41`	`42`
`42`	`43`	`protected function getApiClass()`
`43`	`44`	`{`
`44`		`- return 'Gitlab\Api\DeployKeys';`
	`45`	`+ return DeployKeys::class;`
`45`	`46`	`}`
`46`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\Deployments;`
`5`	`6`	`class DeploymentsTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -230,6 +231,6 @@ public function shouldShowDeployment()`
`230`	`231`
`231`	`232`	`protected function getApiClass()`
`232`	`233`	`{`
`233`		`- return 'Gitlab\Api\Deployments';`
	`234`	`+ return Deployments::class;`
`234`	`235`	`}`
`235`	`236`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\Environments;`
`5`	`6`	`class EnvironmentsTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -190,6 +191,6 @@ public function shouldStopEnvironment()`
`190`	`191`
`191`	`192`	`protected function getApiClass()`
`192`	`193`	`{`
`193`		`- return 'Gitlab\Api\Environments';`
	`194`	`+ return Environments::class;`
`194`	`195`	`}`
`195`	`196`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\GroupsBoards;`
`5`	`6`	`class GroupBoardsTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -227,6 +228,6 @@ public function shouldDeleteList()`
`227`	`228`
`228`	`229`	`protected function getApiClass()`
`229`	`230`	`{`
`230`		`- return 'Gitlab\Api\GroupsBoards';`
	`231`	`+ return GroupsBoards::class;`
`231`	`232`	`}`
`232`	`233`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\GroupsMilestones;`
`5`	`6`	`class GroupsMilestonesTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -134,6 +135,6 @@ public function shouldGetMilestonesMergeRequests()`
`134`	`135`
`135`	`136`	`protected function getApiClass()`
`136`	`137`	`{`
`137`		`- return 'Gitlab\Api\GroupsMilestones';`
	`138`	`+ return GroupsMilestones::class;`
`138`	`139`	`}`
`139`	`140`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\Groups;`
`5`	`6`	`class GroupsTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -523,7 +524,7 @@ public function shouldRemoveVariable()`
`523`	`524`
`524`	`525`	`protected function getApiClass()`
`525`	`526`	`{`
`526`		`- return 'Gitlab\Api\Groups';`
	`527`	`+ return Groups::class;`
`527`	`528`	`}`
`528`	`529`
`529`	`530`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\IssueBoards;`
`5`	`6`	`class IssueBoardsTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -227,6 +228,6 @@ public function shouldDeleteList()`
`227`	`228`
`228`	`229`	`protected function getApiClass()`
`229`	`230`	`{`
`230`		`- return 'Gitlab\Api\IssueBoards';`
	`231`	`+ return IssueBoards::class;`
`231`	`232`	`}`
`232`	`233`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Gitlab\Tests\Api;`
`4`	`4`
	`5`	`+use Gitlab\Api\Issues;`
`5`	`6`	`class IssuesTest extends TestCase`
`6`	`7`	`{`
`7`	`8`	`/**`
`@@ -677,6 +678,6 @@ public function shouldGetIssueParticipants()`
`677`	`678`
`678`	`679`	`protected function getApiClass()`
`679`	`680`	`{`
`680`		`- return 'Gitlab\Api\Issues';`
	`681`	`+ return Issues::class;`
`681`	`682`	`}`
`682`	`683`	`}`