Grid: scroll to keep selected cell in view#6
Merged
Conversation
Wrap the results ScrollView in a ScrollViewReader and scroll on selectedIndex changes so arrow-key nav past the fold doesn't push the highlighted cell off-screen. anchor: nil is a bring-into-view, so Left/Right steps inside a visible row don't jitter. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
There was a problem hiding this comment.
Pull request overview
This PR improves keyboard navigation in the SwiftUI results grid by automatically scrolling to keep the currently selected result cell visible as selectedIndex changes.
Changes:
- Wraps the results
ScrollViewin aScrollViewReaderto enable programmatic scrolling. - Adds an
onChangehandler onmodel.selectedIndexthatscrollTos the newly selected result (using bring-into-view semantics viaanchor: nil).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScrollViewin aScrollViewReaderand callscrollTowhenevermodel.selectedIndexchanges, so arrow-key nav doesn't push the focused cell off-screen.anchor: nilis a bring-into-view scroll, so Left/Right steps inside an already-visible row don't jitter the position.Test plan
swift buildpasses.