From 90728454f6c1d64ec80bef0a40cd52f51dd836fe Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Fri, 30 May 2025 03:28:56 +0530
Subject: [PATCH 1/8] Fix snackbar not being visible when keyboard is present
 (in more settings screen/page)

---
 app/src/main/AndroidManifest.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 36985190..14c2c184 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -185,6 +185,7 @@
             android:theme="@style/Theme.App"
             android:taskAffinity=".ui.activities.InAppGallery"
             android:excludeFromRecents="true"
+            android:windowSoftInputMode="adjustResize"
             android:exported="false"/>
 
         <activity

From 9bcce246b64a8fc128b9b35a96e8b144ee3286a6 Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Fri, 30 May 2025 23:29:43 +0530
Subject: [PATCH 2/8] Add string resources (for video bitrate setting UI)

---
 app/src/main/res/values/strings.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 9aa6ae1e..fb09ecbe 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -193,4 +193,11 @@
 
     <string name="video_audio_recording_muted">The video\'s audio recording has been muted</string>
     <string name="video_audio_recording_unmuted">The video\'s audio recording has been unmuted</string>
+
+    <string name="video_bitrate_was_set_to_auto">Video bitrate was set to auto mode</string>
+    <string name="video_bitrate">Video Bitrate</string>
+    <string name="video_bitrate_description">Adjust the video bitrate of a video recording to a specified bitrate. The specified value will be taken as a hint and may not be the exact video rate at all times while recording.</string>
+    <string name="reset_video_bitrate">Reset video bitrate</string>
+    <string name="video_bitrate_number_limit" tools:ignore="PluralsCandidate">Video bitrate can only be between %1$d %2$s and %3$d %4$s</string>
+    <string name="unit">Unit</string>
 </resources>

From 0f327a80e509378b609f86d21cb4d115596f6fb3 Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Fri, 30 May 2025 23:30:06 +0530
Subject: [PATCH 3/8] Add icon for video bitrate setting

---
 app/src/main/res/drawable/video_bitrate.xml | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 app/src/main/res/drawable/video_bitrate.xml

diff --git a/app/src/main/res/drawable/video_bitrate.xml b/app/src/main/res/drawable/video_bitrate.xml
new file mode 100644
index 00000000..16655a46
--- /dev/null
+++ b/app/src/main/res/drawable/video_bitrate.xml
@@ -0,0 +1,13 @@
+<vector
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:autoMirrored="true"
+    android:height="24dp"
+    android:viewportHeight="960"
+    android:viewportWidth="960"
+    android:width="24dp">
+      
+    <path
+        android:fillColor="?attr/colorControlNormal"
+        android:pathData="M160,800Q127,800 103.5,776.5Q80,753 80,720L80,240Q80,207 103.5,183.5Q127,160 160,160L640,160Q673,160 696.5,183.5Q720,207 720,240L720,420L880,260L880,700L720,540L720,720Q720,753 696.5,776.5Q673,800 640,800L160,800ZM160,720L640,720Q640,720 640,720Q640,720 640,720L640,240Q640,240 640,240Q640,240 640,240L160,240Q160,240 160,240Q160,240 160,240L160,720Q160,720 160,720Q160,720 160,720ZM160,720Q160,720 160,720Q160,720 160,720L160,240Q160,240 160,240Q160,240 160,240L160,240Q160,240 160,240Q160,240 160,240L160,720Q160,720 160,720Q160,720 160,720Z"/>
+    
+</vector>

From 7ddd82a054fd22e415eb760a2d922fe7da3e6af8 Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Sat, 31 May 2025 03:12:48 +0530
Subject: [PATCH 4/8] Update logic of existing input number filter classes *
 Add a class CustomNumFilter that ensures only number is present on the field
 the filter is applied to * Use the custom CustomNumFilter for NumInputFilter
 (old) or now NumLimFilter (new) class * Shift the two input filter classes to
 a separate package (app.grapheneos.camera.inputfilter)

---
 .../app/grapheneos/camera/NumInputFilter.kt   | 42 -------------------
 .../camera/inputfilter/CustomNumFilter.kt     | 36 ++++++++++++++++
 .../camera/inputfilter/NumLimitFilter.kt      | 19 +++++++++
 3 files changed, 55 insertions(+), 42 deletions(-)
 delete mode 100644 app/src/main/java/app/grapheneos/camera/NumInputFilter.kt
 create mode 100644 app/src/main/java/app/grapheneos/camera/inputfilter/CustomNumFilter.kt
 create mode 100644 app/src/main/java/app/grapheneos/camera/inputfilter/NumLimitFilter.kt

diff --git a/app/src/main/java/app/grapheneos/camera/NumInputFilter.kt b/app/src/main/java/app/grapheneos/camera/NumInputFilter.kt
deleted file mode 100644
index 793f9bb6..00000000
--- a/app/src/main/java/app/grapheneos/camera/NumInputFilter.kt
+++ /dev/null
@@ -1,42 +0,0 @@
-package app.grapheneos.camera
-
-import android.text.InputFilter
-import android.text.Spanned
-import app.grapheneos.camera.ui.activities.MoreSettings
-
-class NumInputFilter(private val settings: MoreSettings) : InputFilter {
-
-    override fun filter(
-        source: CharSequence,
-        start: Int,
-        end: Int,
-        dest: Spanned,
-        dstart: Int,
-        dend: Int
-    ): CharSequence? {
-        try {
-            val input = (dest.subSequence(0, dstart).toString() + source + dest.subSequence(
-                dend,
-                dest.length
-            )).toInt()
-            if (isInRange(input)) {
-                return null
-            } else {
-                settings.showMessage(settings.getString(
-                    R.string.photo_quality_number_limit, min, max))
-            }
-        } catch (e: NumberFormatException) {
-            e.printStackTrace()
-        }
-        return ""
-    }
-
-    private fun isInRange(value: Int): Boolean {
-        return value in min..max
-    }
-
-    companion object {
-        const val min = 1
-        const val max = 100
-    }
-}
diff --git a/app/src/main/java/app/grapheneos/camera/inputfilter/CustomNumFilter.kt b/app/src/main/java/app/grapheneos/camera/inputfilter/CustomNumFilter.kt
new file mode 100644
index 00000000..a8105c6c
--- /dev/null
+++ b/app/src/main/java/app/grapheneos/camera/inputfilter/CustomNumFilter.kt
@@ -0,0 +1,36 @@
+package app.grapheneos.camera.inputfilter
+
+import android.text.InputFilter
+import android.text.Spanned
+
+open class CustomNumFilter(
+    val shouldAcceptNumber : (Float) -> Boolean,
+) : InputFilter {
+
+    override fun filter(
+        source: CharSequence,
+        start: Int,
+        end: Int,
+        dest: Spanned,
+        dstart: Int,
+        dend: Int
+    ): CharSequence? {
+        val transformedString = source.subSequence(start, end).replace(Regex("[^0-9]"), "")
+
+        try {
+            val input = (dest.subSequence(0, dstart).toString() + source + dest.subSequence(
+                dend,
+                dest.length
+            )).toFloat()
+            if (this.shouldAcceptNumber(input)) {
+                return transformedString
+            } else {
+                return ""
+            }
+        } catch (e: NumberFormatException) {
+            e.printStackTrace()
+            return transformedString
+        }
+        return transformedString
+    }
+}
\ No newline at end of file
diff --git a/app/src/main/java/app/grapheneos/camera/inputfilter/NumLimitFilter.kt b/app/src/main/java/app/grapheneos/camera/inputfilter/NumLimitFilter.kt
new file mode 100644
index 00000000..2d6b3ded
--- /dev/null
+++ b/app/src/main/java/app/grapheneos/camera/inputfilter/NumLimitFilter.kt
@@ -0,0 +1,19 @@
+package app.grapheneos.camera.inputfilter
+
+// Ensures that the field is within the min/max limits for a number type input field
+class NumLimitFilter(
+    val min: Float,
+    val max: Float,
+    val onOutOfRange: () -> Unit,
+) : CustomNumFilter(
+    shouldAcceptNumber = { num ->
+        if (num in min..max) {
+            true
+        } else {
+            onOutOfRange()
+            false
+        }
+    }
+) {
+    constructor(min: Int, max: Int, onOutOfRange: () -> Unit) : this(min.toFloat(), max.toFloat(), onOutOfRange)
+}
\ No newline at end of file

From 17a33050def1b2dfbb308d75f2ad5c8d2b511bda Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Sat, 31 May 2025 03:14:48 +0530
Subject: [PATCH 5/8] Add UI for video bitrate setting

---
 app/src/main/res/layout/more_settings.xml | 109 ++++++++++++++++++++++
 1 file changed, 109 insertions(+)

diff --git a/app/src/main/res/layout/more_settings.xml b/app/src/main/res/layout/more_settings.xml
index c3b8117f..a07ec8a5 100644
--- a/app/src/main/res/layout/more_settings.xml
+++ b/app/src/main/res/layout/more_settings.xml
@@ -515,6 +515,115 @@
 
                 </LinearLayout>
 
+                <LinearLayout
+                    android:id="@+id/video_bitrate_setting"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:background="?android:attr/selectableItemBackground"
+                    android:clickable="true"
+                    android:focusable="true"
+                    android:orientation="horizontal"
+                    android:paddingTop="8dp"
+                    android:paddingHorizontal="16dp"
+                    android:paddingBottom="10dp">
+
+                    <ImageView
+                        android:id="@+id/video_bitrate_setting_icon"
+                        android:layout_width="48dp"
+                        android:layout_height="48dp"
+                        android:contentDescription="@string/video_bitrate"
+                        android:paddingStart="4dp"
+                        android:paddingEnd="8dp"
+                        android:src="@drawable/video_bitrate" />
+
+                    <LinearLayout
+                        android:layout_width="0dp"
+                        android:layout_height="wrap_content"
+                        android:layout_marginHorizontal="4dp"
+                        android:layout_weight="1"
+                        android:orientation="vertical">
+
+                        <TextView
+                            android:id="@+id/video_bitrate_setting_title"
+                            android:layout_width="wrap_content"
+                            android:layout_height="wrap_content"
+                            android:layout_marginStart="10dp"
+                            android:paddingBottom="2dp"
+                            android:text="@string/video_bitrate"
+                            android:textColor="?android:textColorPrimary"
+                            android:textSize="16sp" />
+
+                        <TextView
+                            android:id="@+id/video_bitrate_setting_subtitle"
+                            android:layout_width="wrap_content"
+                            android:layout_height="wrap_content"
+                            android:paddingStart="10dp"
+                            android:text="@string/video_bitrate_description"
+                            android:textSize="14sp"
+                            tools:ignore="RtlSymmetry" />
+
+                        <LinearLayout
+                            android:layout_width="match_parent"
+                            android:layout_height="match_parent"
+                            android:orientation="horizontal"
+                            android:layout_marginTop="4dp">
+
+                            <com.google.android.material.textfield.TextInputLayout
+                                style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox"
+                                android:layout_width="0dp"
+                                android:layout_weight="1"
+                                android:layout_height="wrap_content"
+                                android:layout_marginStart="5dp"
+                                android:layout_marginLeft="5dp"
+                                android:layout_marginEnd="5dp"
+                                android:layout_marginRight="5dp"
+                                android:padding="3dp">
+
+                                <com.google.android.material.textfield.TextInputEditText
+                                    android:id="@+id/video_bitrate_value_field"
+                                    android:layout_width="match_parent"
+                                    android:layout_height="wrap_content"
+                                    android:hint="@string/video_bitrate"
+                                    android:imeOptions="actionDone"
+                                    android:inputType="number" />
+
+                            </com.google.android.material.textfield.TextInputLayout>
+
+                            <com.google.android.material.textfield.TextInputLayout
+                                style="@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox.ExposedDropdownMenu"
+                                android:layout_width="wrap_content"
+                                android:layout_height="wrap_content"
+                                android:layout_marginStart="5dp"
+                                android:layout_marginLeft="5dp"
+                                android:layout_marginEnd="5dp"
+                                android:layout_marginRight="5dp"
+                                android:padding="3dp">
+
+                                <AutoCompleteTextView
+                                    android:id="@+id/video_bitrate_unit_spinner"
+                                    android:layout_width="match_parent"
+                                    android:layout_height="wrap_content"
+                                    android:hint="@string/unit"
+                                    android:imeOptions="actionDone"
+                                    android:inputType="none" />
+
+                            </com.google.android.material.textfield.TextInputLayout>
+
+                            <Button
+                                android:id="@+id/refresh_video_bitrate"
+                                style="?attr/materialIconButtonFilledStyle"
+                                android:layout_width="wrap_content"
+                                android:layout_height="wrap_content"
+                                android:layout_gravity="center_vertical"
+                                android:contentDescription="@string/reset_video_bitrate"
+                                app:icon="@drawable/refresh" />
+
+                        </LinearLayout>
+
+                    </LinearLayout>
+
+                </LinearLayout>
+
             </LinearLayout>
 
             <LinearLayout

From 7ad7b2c2199fd64d6f7cb5bebe99b10e1ec7988e Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Sat, 31 May 2025 03:30:26 +0530
Subject: [PATCH 6/8] Add code to store, view and manage preference (for video
 bitrate setting)

---
 .../java/app/grapheneos/camera/CamConfig.kt   | 60 +++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/app/src/main/java/app/grapheneos/camera/CamConfig.kt b/app/src/main/java/app/grapheneos/camera/CamConfig.kt
index 128205f5..95f32653 100644
--- a/app/src/main/java/app/grapheneos/camera/CamConfig.kt
+++ b/app/src/main/java/app/grapheneos/camera/CamConfig.kt
@@ -111,6 +111,10 @@ class CamConfig(private val mActivity: MainActivity) {
 
             const val ENABLE_ZSL = "enable_zsl"
 
+            const val VIDEO_BITRATE_VALUE = "video_bitrate_value"
+
+            const val VIDEO_BITRATE_UNIT = "video_bitrate_unit"
+
             // const val IMAGE_FILE_FORMAT = "image_quality"
             // const val VIDEO_FILE_FORMAT = "video_quality"
         }
@@ -156,6 +160,10 @@ class CamConfig(private val mActivity: MainActivity) {
 
             const val ENABLE_ZSL = false
 
+            const val VIDEO_BITRATE_VALUE = 0 // auto
+
+            const val VIDEO_BITRATE_UNIT = "b/s"
+
             // const val IMAGE_FILE_FORMAT = ""
             // const val VIDEO_FILE_FORMAT = ""
         }
@@ -176,6 +184,12 @@ class CamConfig(private val mActivity: MainActivity) {
             BarcodeFormat.PDF_417,
         )
 
+        val VIDEO_BITRATE_UNITS = arrayOf(
+            "b/s",
+            "kb/s",
+            "mb/s"
+        )
+
         val imageCollectionUri: Uri = MediaStore.Images.Media.getContentUri(
             MediaStore.VOLUME_EXTERNAL_PRIMARY
         )!!
@@ -555,6 +569,52 @@ class CamConfig(private val mActivity: MainActivity) {
             editor.apply()
         }
 
+    // The value of bit rate set by the user (the effective value can be different based on the selected unit)
+    var videoBitRateValue: Int
+        get() {
+            return commonPref.getInt(
+                SettingValues.Key.VIDEO_BITRATE_VALUE,
+                SettingValues.Default.VIDEO_BITRATE_VALUE
+            )
+        }
+        set(value) {
+            val editor = commonPref.edit()
+            editor.putInt(SettingValues.Key.VIDEO_BITRATE_VALUE, value)
+            editor.apply()
+        }
+
+    // The unit of bit rate set by the user (impacts the effective value of bit rate sent)
+    var videoBitRateUnit: String
+        get() {
+            return commonPref.getString(
+                SettingValues.Key.VIDEO_BITRATE_UNIT,
+                SettingValues.Default.VIDEO_BITRATE_UNIT
+            ) ?: SettingValues.Default.VIDEO_BITRATE_UNIT
+        }
+        set(value) {
+            val editor = commonPref.edit()
+            editor.putString(SettingValues.Key.VIDEO_BITRATE_UNIT, value)
+            editor.apply()
+        }
+
+    // Returns a multiplier value based on the
+    val videoBitRateMultiplier : Int
+        get() {
+            return if (videoBitRateUnit == "kb/s") {
+                1000
+            } else if (videoBitRateUnit == "mb/s") {
+                1000000
+            } else {
+                1
+            }
+        }
+
+    // The effective video bit rate based on [videoBitRateValue] and [videoBitRateUnit]
+    val videoBitRate : Int
+        get() {
+            return videoBitRateMultiplier * videoBitRateValue
+        }
+
     val isZslSupported : Boolean by lazy {
         camera!!.cameraInfo.isZslSupported
     }

From 0f01298517307910b04cccb2d8966a7f08bd45f0 Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Sat, 31 May 2025 03:32:47 +0530
Subject: [PATCH 7/8] Make video bitrate setting UI functional

---
 .../camera/ui/activities/MoreSettings.kt      | 175 ++++++++++++++----
 1 file changed, 140 insertions(+), 35 deletions(-)

diff --git a/app/src/main/java/app/grapheneos/camera/ui/activities/MoreSettings.kt b/app/src/main/java/app/grapheneos/camera/ui/activities/MoreSettings.kt
index 18b228fb..ae441f8b 100644
--- a/app/src/main/java/app/grapheneos/camera/ui/activities/MoreSettings.kt
+++ b/app/src/main/java/app/grapheneos/camera/ui/activities/MoreSettings.kt
@@ -2,7 +2,6 @@ package app.grapheneos.camera.ui.activities
 
 import android.content.Context
 import android.content.Intent
-import android.graphics.Color
 import android.graphics.Rect
 import android.os.Bundle
 import android.view.KeyEvent
@@ -10,20 +9,23 @@ import android.view.MotionEvent
 import android.view.View
 import android.view.inputmethod.EditorInfo
 import android.view.inputmethod.InputMethodManager
+import android.widget.AdapterView
+import android.widget.ArrayAdapter
+import android.widget.AutoCompleteTextView
 import android.widget.Button
 import android.widget.EditText
 import android.widget.TextView
 import androidx.activity.enableEdgeToEdge
 import androidx.activity.result.contract.ActivityResultContracts
 import androidx.appcompat.app.AppCompatActivity
-import androidx.core.view.OnApplyWindowInsetsListener
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsCompat
 import app.grapheneos.camera.CamConfig
 import app.grapheneos.camera.CapturedItems
-import app.grapheneos.camera.NumInputFilter
+import app.grapheneos.camera.inputfilter.NumLimitFilter
 import app.grapheneos.camera.R
 import app.grapheneos.camera.databinding.MoreSettingsBinding
+import app.grapheneos.camera.inputfilter.CustomNumFilter
 import app.grapheneos.camera.util.storageLocationToUiString
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.google.android.material.snackbar.Snackbar
@@ -44,6 +46,10 @@ open class MoreSettings : AppCompatActivity(), TextView.OnEditorActionListener {
     private lateinit var iFField: EditText
     private lateinit var vFField: EditText
 
+    private lateinit var videoBitRateValueField: EditText
+    private lateinit var videoBitRateUnitField: AutoCompleteTextView
+    private lateinit var videoBitRateUnitFieldAdapter: ArrayAdapter<String>
+
     private val dirPickerHandler = registerForActivityResult(
         ActivityResultContracts.StartActivityForResult()
     ) {
@@ -150,9 +156,130 @@ open class MoreSettings : AppCompatActivity(), TextView.OnEditorActionListener {
             pQField.setText(camConfig.photoQuality.toString())
         }
 
-        pQField.filters = arrayOf(NumInputFilter(this))
+        pQField.filters = arrayOf(NumLimitFilter(
+            min = PHOTO_QUALITY_MIN,
+            max = PHOTO_QUALITY_MAX,
+            onOutOfRange = {
+                showMessage(getString(R.string.photo_quality_number_limit, PHOTO_QUALITY_MIN, PHOTO_QUALITY_MAX))
+            }
+        ))
+        pQField.onFocusChangeListener = object: View.OnFocusChangeListener {
+            override fun onFocusChange(v: View, hasFocus: Boolean) {
+                if (!hasFocus) {
+                    if (pQField.text.isEmpty()) {
+                        camConfig.photoQuality = 0
+
+                        showMessage(
+                            getString(R.string.photo_quality_was_set_to_auto)
+                        )
+                    } else {
+                        try {
+                            camConfig.photoQuality =
+                                Integer.parseInt(pQField.text.toString())
+                        } catch (_: Exception) {
+                            camConfig.photoQuality = 0
+
+                        }
+                    }
+                }
+            }
+        }
         pQField.setOnEditorActionListener(this)
 
+        // Video bitrate value field
+        videoBitRateValueField = binding.videoBitrateValueField
+
+        if (camConfig.videoBitRateValue != 0) {
+            videoBitRateValueField.setText(camConfig.videoBitRateValue.toString())
+        }
+
+        videoBitRateValueField.filters = arrayOf(
+            CustomNumFilter(
+                shouldAcceptNumber = { value ->
+                    val calculatedBitRate = value * camConfig.videoBitRateMultiplier
+                    if (calculatedBitRate >= VIDEO_BITRATE_MIN && calculatedBitRate <= VIDEO_BITRATE_MAX) {
+                        true
+                   } else {
+                        val minVideoBitrateInUnits = (VIDEO_BITRATE_MIN.toFloat() / camConfig.videoBitRateMultiplier).coerceAtLeast(1f).toInt()
+                        val maxVideoBitrateInUnits = VIDEO_BITRATE_MAX / camConfig.videoBitRateMultiplier
+
+                        showMessage(getString(R.string.video_bitrate_number_limit, minVideoBitrateInUnits, camConfig.videoBitRateUnit, maxVideoBitrateInUnits, camConfig.videoBitRateUnit))
+                        false
+                    }
+                }
+            )
+        )
+        videoBitRateValueField.onFocusChangeListener = object: View.OnFocusChangeListener {
+            override fun onFocusChange(v: View, hasFocus: Boolean) {
+                if (!hasFocus) {
+                    if (videoBitRateValueField.text.isEmpty()) {
+                        camConfig.videoBitRateValue = 0
+
+                        showMessage(
+                            getString(R.string.video_bitrate_was_set_to_auto)
+                        )
+                    } else {
+                        try {
+                            camConfig.videoBitRateValue =
+                                Integer.parseInt(videoBitRateValueField.text.toString())
+                        } catch (exception: Exception) {
+                            camConfig.videoBitRateValue = 0
+                            showMessage(
+                                getString(R.string.video_bitrate_was_set_to_auto)
+                            )
+                        }
+                    }
+                }
+            }
+        }
+        videoBitRateValueField.setOnEditorActionListener(this)
+
+        // Video bit rate unit field
+        videoBitRateUnitField = binding.videoBitrateUnitSpinner
+
+        videoBitRateUnitFieldAdapter = ArrayAdapter<String>(
+            this,
+            android.R.layout.simple_spinner_item,
+            CamConfig.VIDEO_BITRATE_UNITS
+        )
+
+        videoBitRateUnitFieldAdapter.setDropDownViewResource(
+            android.R.layout.simple_spinner_dropdown_item
+        )
+
+        videoBitRateUnitField.setAdapter(videoBitRateUnitFieldAdapter)
+
+        videoBitRateUnitField.setText(camConfig.videoBitRateUnit, false)
+
+        videoBitRateUnitField.onItemClickListener = object : AdapterView.OnItemClickListener {
+            override fun onItemClick(
+                parent: AdapterView<*>?,
+                view: View?,
+                position: Int,
+                id: Long
+            ) {
+                val selectedBitRateUnit = CamConfig.VIDEO_BITRATE_UNITS[position]
+                camConfig.videoBitRateUnit = selectedBitRateUnit
+
+                // Update bitrate value to highest possible valid value when it exceeds VIDEO_BITRATE_MAX
+                // while switching to a higher value unit (as a fallback to prevent overflow while switching
+                // from say MAX_INT b/s to MAX_INT mb/s (b/s --> mb/s) which would lead to unexpected behavior
+                val maxVideoBitrateWithUnits = VIDEO_BITRATE_MAX / camConfig.videoBitRateMultiplier
+                if (camConfig.videoBitRateValue > maxVideoBitrateWithUnits) {
+                    camConfig.videoBitRateValue = maxVideoBitrateWithUnits
+                    videoBitRateValueField.setText(maxVideoBitrateWithUnits.toString())
+                }
+            }
+        }
+
+        binding.refreshVideoBitrate.setOnClickListener {
+            camConfig.videoBitRateValue = 0
+            videoBitRateValueField.setText("")
+            showMessage(
+                getString(R.string.video_bitrate_was_set_to_auto)
+            )
+        }
+
         iFField = binding.imageFormatSettingField
         iFField.setOnEditorActionListener(this)
 
@@ -267,7 +394,7 @@ open class MoreSettings : AppCompatActivity(), TextView.OnEditorActionListener {
                 v.getGlobalVisibleRect(outRect)
                 if (!outRect.contains(event.rawX.toInt(), event.rawY.toInt())) {
                     clearFocus()
-                    dumpData()
+//                    dumpData()
                 }
             }
         }
@@ -284,39 +411,10 @@ open class MoreSettings : AppCompatActivity(), TextView.OnEditorActionListener {
         }
     }
 
-    private fun dumpData() {
-
-        // Dump state of photo quality
-        if (pQField.text.isEmpty()) {
-            camConfig.photoQuality = 0
-
-            showMessage(
-                getString(R.string.photo_quality_was_set_to_auto)
-            )
-        } else {
-            try {
-
-                camConfig.photoQuality =
-                    Integer.parseInt(pQField.text.toString())
-
-            } catch (exception: Exception) {
-
-                camConfig.photoQuality = 0
-
-            }
-        }
-
-//        // Dump state of image format
-//        camConfig.imageFormat = iFField.text.toString()
-//
-//        // Dump state of video format
-//        camConfig.videoFormat = vFField.text.toString()
-    }
-
     override fun onEditorAction(p0: TextView?, id: Int, p2: KeyEvent?): Boolean {
         return if (id == EditorInfo.IME_ACTION_DONE) {
             clearFocus()
-            dumpData()
+//            dumpData()
             true
         } else false
     }
@@ -332,6 +430,13 @@ open class MoreSettings : AppCompatActivity(), TextView.OnEditorActionListener {
     }
 
     companion object {
+        const val PHOTO_QUALITY_MIN = 1
+        const val PHOTO_QUALITY_MAX = 100
+
+        // Video bitrate in bs
+        const val VIDEO_BITRATE_MIN = 1
+        const val VIDEO_BITRATE_MAX = Integer.MAX_VALUE
+
         private var camConfigId = 0L
         private var staticCamConfig: CamConfig? = null
 

From 208af9b261e4dbd639765b5b22d6f6aebfc925d5 Mon Sep 17 00:00:00 2001
From: MHShetty <shettymohitn@gmail.com>
Date: Sat, 31 May 2025 03:33:16 +0530
Subject: [PATCH 8/8] Implement video bitrate functionality

---
 app/src/main/java/app/grapheneos/camera/CamConfig.kt | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/app/grapheneos/camera/CamConfig.kt b/app/src/main/java/app/grapheneos/camera/CamConfig.kt
index 95f32653..b5968a46 100644
--- a/app/src/main/java/app/grapheneos/camera/CamConfig.kt
+++ b/app/src/main/java/app/grapheneos/camera/CamConfig.kt
@@ -1206,10 +1206,15 @@ class CamConfig(private val mActivity: MainActivity) {
                         View.VISIBLE
                     }
 
-                val videoCaptureBuilder = VideoCapture.Builder(
-                    Recorder.Builder()
+                val recorderBuilder = Recorder.Builder()
                     .setQualitySelector(QualitySelector.from(videoQuality))
-                    .build()
+
+                if (mActivity.camConfig.videoBitRateValue != 0) {
+                    recorderBuilder.setTargetVideoEncodingBitRate(mActivity.camConfig.videoBitRate)
+                }
+
+                val videoCaptureBuilder = VideoCapture.Builder(
+                    recorderBuilder.build()
                 )
 
                 videoCaptureBuilder.setVideoStabilizationEnabled(mActivity.camConfig.enableEIS)