Skip to content

Commit a9131cc

Browse files
committed
add debug menu entry for crashing WebView
This will be useful for making the app gracefully handle WebView crashes.
1 parent e9a3758 commit a9131cc

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

app/src/main/java/app/grapheneos/pdfviewer/PdfViewer.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -684,6 +684,7 @@ public boolean onPrepareOptionsMenu(@NonNull Menu menu) {
684684
R.id.action_outline));
685685
if (BuildConfig.DEBUG) {
686686
ids.add(R.id.debug_action_toggle_text_layer_visibility);
687+
ids.add(R.id.debug_action_crash_webview);
687688
}
688689
if (mDocumentState < STATE_LOADED) {
689690
for (final int id : ids) {
@@ -764,6 +765,9 @@ public boolean onOptionsItemSelected(MenuItem item) {
764765
} else if (itemId == R.id.debug_action_toggle_text_layer_visibility) {
765766
binding.webview.evaluateJavascript("toggleTextLayerVisibility()", null);
766767
return true;
768+
} else if (itemId == R.id.debug_action_crash_webview) {
769+
binding.webview.loadUrl("chrome://crash");
770+
return true;
767771
}
768772

769773
return super.onOptionsItemSelected(item);

app/src/main/res/menu/pdf_viewer_debug.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,9 @@
77
android:title="@string/debug_action_toggle_text_layer_visibility"
88
app:showAsAction="never" />
99

10+
<item
11+
android:id="@+id/debug_action_crash_webview"
12+
android:title="@string/debug_action_crash_webview"
13+
app:showAsAction="never" />
14+
1015
</menu>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<string name="outline_not_available">No outline available</string>
2121

2222
<string name="debug_action_toggle_text_layer_visibility">Toggle text layer visibility</string>
23+
<string name="debug_action_crash_webview">Crash WebView</string>
2324

2425
<string name="document_properties_invalid_date">Invalid date</string>
2526
<string name="document_properties_retrieval_failed">Failed to obtain document metadata</string>

0 commit comments

Comments
 (0)