Fix some more bugs within the compositor

Author: GrieferAtWork

kos/include/libvideo/codec/rectutils.h

@@ -88,15 +88,15 @@ __LOCAL __ATTR_WUNUSED __ATTR_IN(1) __ATTR_IN(2) __ATTR_OUT(3) __BOOL LIBVIDEO_C
 video_rect_intersect_overflow_in_b(struct video_rect const *__restrict a,
                                    struct video_rect const *__restrict b,
                                    struct video_rect *__restrict intersect) {
+	video_offset_t b_xend, b_yend, intersect_xend, intersect_yend;
 	video_offset_t a_xend = video_rect_getxend(a);
 	video_offset_t a_yend = video_rect_getyend(a);
-	video_offset_t b_xend, b_yend;
-	video_offset_t intersect_xend = __hybrid_min(a_xend, b_xend);
-	video_offset_t intersect_yend = __hybrid_min(a_yend, b_yend);
 	if (__hybrid_overflow_sadd(video_rect_getxmin(b), video_rect_getxdim(b), &b_xend))
 		b_xend = VIDEO_OFFSET_MAX;
 	if (__hybrid_overflow_sadd(video_rect_getymin(b), video_rect_getydim(b), &b_yend))
 		b_yend = VIDEO_OFFSET_MAX;
+	intersect_xend = __hybrid_min(a_xend, b_xend);
+	intersect_yend = __hybrid_min(a_yend, b_yend);
 	video_rect_setxmin(intersect, __hybrid_max(video_rect_getxmin(a), video_rect_getxmin(b)));
 	video_rect_setymin(intersect, __hybrid_max(video_rect_getymin(a), video_rect_getymin(b)));
 	if (video_rect_getxmin(intersect) < intersect_xend && video_rect_getymin(intersect) < intersect_yend) {

kos/include/libvideo/compositor/compositor.h

@@ -42,6 +42,7 @@ __DECL_BEGIN
                                         * - When set, `VIDEO_WINDOW_F_PASSTHRU' is ignored
                                         * - When set, buffer returned by `video_window_getbuffer' has alpha-support */
 #define VIDEO_WINDOW_F_PASSTHRU 0x0002 /* Enable support for video_buffer passthru (when possible) */
+/* TODO: "VIDEO_WINDOW_F_PASSTHRU" should be the default -- disallow should be its own flag */
 #define VIDEO_WINDOW_F_HIDDEN   0x0004 /* Window is being hidden right now */
 #define VIDEO_WINDOW_F_ALL (VIDEO_WINDOW_F_ALPHA | VIDEO_WINDOW_F_PASSTHRU | VIDEO_WINDOW_F_HIDDEN)
 

kos/src/apps/showpic/main.c

@@ -604,7 +604,7 @@ int main(int argc, char *argv[]) {
 
 		/* Create a second (small) window to interact with the first (big) one */
 		position.vwp_over = VIDEO_WINDOW_MOVE_OVER__FOREGROUND;
-		position.vwp_attr.vwa_flags = VIDEO_WINDOW_F_PASSTHRU /*| VIDEO_WINDOW_F_ALPHA*/;
+		position.vwp_attr.vwa_flags = VIDEO_WINDOW_F_PASSTHRU | VIDEO_WINDOW_F_ALPHA;
 		position.vwp_attr.vwa_rect.vr_xmin = 10;
 		position.vwp_attr.vwa_rect.vr_ymin = 10;
 		position.vwp_attr.vwa_rect.vr_xdim = 200;
@@ -626,7 +626,7 @@ int main(int argc, char *argv[]) {
 			colors[0][0] = VIDEO_COLOR_RGBA(0xff, 0, 0, 0xff);
 			colors[0][1] = VIDEO_COLOR_RGBA(0, 0xff, 0, 0xff);
 			colors[1][0] = VIDEO_COLOR_RGBA(0, 0, 0xff, 0xff);
-			colors[1][1] = VIDEO_COLOR_RGBA(0xff, 0xff, 0xff, 0xff);
+			colors[1][1] = VIDEO_COLOR_RGBA(0xff, 0xff, 0xff, 0);
 			video_gfx_gradient(&window2_gfx, 0, 0,
 			                   video_gfx_getclipw(&window2_gfx),
 			                   video_gfx_getcliph(&window2_gfx),