Skip to content

Allow overriding the default generation of rest arguments in js-es <= 5 #12306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R32 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Allow overriding the default generation of rest arguments in js-es <= 5 #12306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/generators/genjs.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,14 +757,16 @@ and gen_function ?(keyword="function") ctx f pos =
else begin
check_var_declaration v;
let non_rest_args = List.rev args_rev in
let args_decl = declare_rest_args_legacy ctx.com (List.length non_rest_args) v in
let body =
let body = if has_var_flag v VUsedByTyper then
let args_decl = declare_rest_args_legacy ctx.com (List.length non_rest_args) v in
let el =
match f.tf_expr.eexpr with
| TBlock el -> args_decl @ el
| _ -> args_decl @ [f.tf_expr]
in
mk (TBlock el) f.tf_expr.etype f.tf_expr.epos
else
f.tf_expr
in
{ f with tf_args = non_rest_args; tf_expr = body }, mk_non_rest_arg_names non_rest_args
end
Expand Down
Loading