|
| 1 | +package appcore |
| 2 | + |
| 3 | +import ( |
| 4 | + "net/http" |
| 5 | + "os" |
| 6 | + "path/filepath" |
| 7 | + "strings" |
| 8 | + "testing" |
| 9 | + |
| 10 | + "github.com/HexmosTech/git-lrc/internal/reviewmodel" |
| 11 | +) |
| 12 | + |
| 13 | +func TestIsLiveReviewAPIKeyInvalid(t *testing.T) { |
| 14 | + tests := []struct { |
| 15 | + name string |
| 16 | + err error |
| 17 | + want bool |
| 18 | + }{ |
| 19 | + { |
| 20 | + name: "valid unauthorized code", |
| 21 | + err: &reviewmodel.APIError{ |
| 22 | + StatusCode: http.StatusUnauthorized, |
| 23 | + Body: `{"error_code":"LIVE_REVIEW_API_KEY_INVALID","error":"invalid"}`, |
| 24 | + }, |
| 25 | + want: true, |
| 26 | + }, |
| 27 | + { |
| 28 | + name: "unauthorized but different error code", |
| 29 | + err: &reviewmodel.APIError{ |
| 30 | + StatusCode: http.StatusUnauthorized, |
| 31 | + Body: `{"error_code":"SOMETHING_ELSE","error":"nope"}`, |
| 32 | + }, |
| 33 | + want: false, |
| 34 | + }, |
| 35 | + { |
| 36 | + name: "non-401 should not trigger recovery", |
| 37 | + err: &reviewmodel.APIError{ |
| 38 | + StatusCode: http.StatusTooManyRequests, |
| 39 | + Body: `{"error_code":"LIVE_REVIEW_API_KEY_INVALID"}`, |
| 40 | + }, |
| 41 | + want: false, |
| 42 | + }, |
| 43 | + { |
| 44 | + name: "malformed json should not trigger recovery", |
| 45 | + err: &reviewmodel.APIError{ |
| 46 | + StatusCode: http.StatusUnauthorized, |
| 47 | + Body: `not-json`, |
| 48 | + }, |
| 49 | + want: false, |
| 50 | + }, |
| 51 | + } |
| 52 | + |
| 53 | + for _, tt := range tests { |
| 54 | + t.Run(tt.name, func(t *testing.T) { |
| 55 | + got := isLiveReviewAPIKeyInvalid(tt.err) |
| 56 | + if got != tt.want { |
| 57 | + t.Fatalf("isLiveReviewAPIKeyInvalid() = %v, want %v", got, tt.want) |
| 58 | + } |
| 59 | + }) |
| 60 | + } |
| 61 | +} |
| 62 | + |
| 63 | +func TestParseAPIErrorCode(t *testing.T) { |
| 64 | + code, err := parseAPIErrorCode(`{"error_code":"LIVE_REVIEW_API_KEY_INVALID"}`) |
| 65 | + if err != nil { |
| 66 | + t.Fatalf("expected no error, got %v", err) |
| 67 | + } |
| 68 | + if code != "LIVE_REVIEW_API_KEY_INVALID" { |
| 69 | + t.Fatalf("unexpected code: %s", code) |
| 70 | + } |
| 71 | + |
| 72 | + if _, err := parseAPIErrorCode(`{not-json}`); err == nil { |
| 73 | + t.Fatal("expected parse error for malformed json") |
| 74 | + } |
| 75 | +} |
| 76 | + |
| 77 | +func TestPersistConfigUpdatesPreservesExistingAPIURL(t *testing.T) { |
| 78 | + tmpDir := t.TempDir() |
| 79 | + configPath := filepath.Join(tmpDir, ".lrc.toml") |
| 80 | + original := "api_url = \"http://localhost:8888\"\njwt = \"old\"\n" |
| 81 | + if err := os.WriteFile(configPath, []byte(original), 0600); err != nil { |
| 82 | + t.Fatalf("write config: %v", err) |
| 83 | + } |
| 84 | + |
| 85 | + if err := persistConfigUpdates(configPath, map[string]string{"jwt": "new"}); err != nil { |
| 86 | + t.Fatalf("persist config updates: %v", err) |
| 87 | + } |
| 88 | + |
| 89 | + updatedBytes, err := os.ReadFile(configPath) |
| 90 | + if err != nil { |
| 91 | + t.Fatalf("read config: %v", err) |
| 92 | + } |
| 93 | + updated := string(updatedBytes) |
| 94 | + |
| 95 | + if !strings.Contains(updated, `api_url = "http://localhost:8888"`) { |
| 96 | + t.Fatalf("expected api_url to remain unchanged: %s", updated) |
| 97 | + } |
| 98 | + if !strings.Contains(updated, `jwt = "new"`) { |
| 99 | + t.Fatalf("expected jwt to be updated: %s", updated) |
| 100 | + } |
| 101 | +} |
| 102 | + |
| 103 | +func TestPersistConfigUpdatesRejectsAPIURLMutation(t *testing.T) { |
| 104 | + tmpDir := t.TempDir() |
| 105 | + configPath := filepath.Join(tmpDir, ".lrc.toml") |
| 106 | + if err := os.WriteFile(configPath, []byte("jwt = \"old\"\n"), 0600); err != nil { |
| 107 | + t.Fatalf("write config: %v", err) |
| 108 | + } |
| 109 | + |
| 110 | + err := persistConfigUpdates(configPath, map[string]string{"api_url": "https://livereview.hexmos.com"}) |
| 111 | + if err == nil { |
| 112 | + t.Fatal("expected api_url mutation guard to fail") |
| 113 | + } |
| 114 | + if !strings.Contains(err.Error(), "api_url updates are not allowed") { |
| 115 | + t.Fatalf("unexpected error: %v", err) |
| 116 | + } |
| 117 | +} |
0 commit comments