destroy endpoint returns :persistentId instead of identifier

[donsizemore]

Tested in 5.9: the "destroy" endpoint returns:

{"status":"OK","data":{"message":"Dataset :persistentId destroyed"}}

Not sure if this was intentional, but it seems preferable for the API to return the identifier in the response.

[pdurbin]

This is probably a holdover from when you could only operate on datasets by ID rather than by PID.

From a quick look at the code (Datasets.java) I suspect that if you delete by ID it will return the ID.

That said, yes, we should fix this. The easiest fix would be to always return the ID or always return the PID. A fancier fix would return the PID when that was used and return the ID when that was used.

[pdurbin]

@donsizemore don't look now but there's a fix in progress!

• Fix destroy dataset response for persistent IDs #12402