Fix destroy dataset response for persistent IDs#12402
Open
won-seoop wants to merge 1 commit into
Open
Conversation
won-seoop
force-pushed
the
8412-destroy-response-persistent-id
branch
from
3b9e835 to
f26ba04
Compare
pdurbin
reviewed
May 20, 2026
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
@won-seoop this seems like a great fix! Thank you! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the destroy dataset success message for
:persistentIdrequests so it reports the actual dataset persistent ID instead of the literal:persistentIdpath token. Adds unit coverage for numeric IDs and persistent IDs.Which issue(s) this PR closes:
Special notes for your reviewer:
None.
Suggestions on how to test this:
mvn -Dtest=DatasetsTest testDoes this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.