Skip to content

Commit b2ee12d

Browse files
committed
ci: fix docker-build job condition
1 parent ebfd643 commit b2ee12d

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

.github/workflows/ci-cd.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,15 +205,24 @@ jobs:
205205
docker-build:
206206
runs-on: ubuntu-latest
207207
needs: [test, integration-test]
208-
if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop') && secrets.DOCKER_USERNAME != '' && secrets.DOCKER_PASSWORD != ''
208+
if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop')
209209

210210
steps:
211211
- uses: actions/checkout@v4
212212

213213
- name: Set up Docker Buildx
214214
uses: docker/setup-buildx-action@v2
215215

216+
- name: Check Docker Hub secrets
217+
run: |
218+
if [ -z "${{ secrets.DOCKER_USERNAME }}" ] || [ -z "${{ secrets.DOCKER_PASSWORD }}" ]; then
219+
echo "Docker Hub credentials not configured; skipping docker push steps."
220+
else
221+
echo "Docker Hub credentials present."
222+
fi
223+
216224
- name: Login to Docker Hub
225+
if: ${{ secrets.DOCKER_USERNAME != '' && secrets.DOCKER_PASSWORD != '' }}
217226
uses: docker/login-action@v2
218227
with:
219228
username: ${{ secrets.DOCKER_USERNAME }}
@@ -232,6 +241,7 @@ jobs:
232241
type=raw,value=latest,enable={{is_default_branch}}
233242
234243
- name: Build and push Docker image
244+
if: ${{ secrets.DOCKER_USERNAME != '' && secrets.DOCKER_PASSWORD != '' }}
235245
uses: docker/build-push-action@v4
236246
with:
237247
context: .

0 commit comments

Comments
 (0)