cleanup

Author: gmethvin

.github/workflows/codeql.yml

@@ -27,7 +27,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v4

.github/workflows/publish.yml

@@ -25,7 +25,7 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Setup pnpm
         uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061

CONTRIBUTING.md

@@ -11,7 +11,7 @@ pnpm build
 
 ## Architecture
 
-The CLI is a thin layer over the `[@iterable/api](https://github.com/Iterable/api-client)` client. Each command maps a Zod schema from the client package to CLI arguments and calls one client method.
+The CLI is a thin layer over the [@iterable/api](https://github.com/Iterable/api-client) client. Each command maps a Zod schema from the client package to CLI arguments and calls one client method.
 
 ### Request flow
 

src/index.ts

@@ -17,6 +17,11 @@ import {
 } from "./router.js";
 import { COMMAND_NAME } from "./utils/command-info.js";
 
+const CLI_PAGINATION_DEFAULTS: Record<string, number> = {
+  page: 1,
+  pageSize: 10,
+};
+
 async function main(): Promise<void> {
   const parsed = parseArgs(process.argv.slice(2));
 
@@ -95,10 +100,6 @@ async function main(): Promise<void> {
       command.cliTransforms
     );
 
-    const CLI_PAGINATION_DEFAULTS: Record<string, number> = {
-      page: 1,
-      pageSize: 10,
-    };
     const schemaKeys =
       command.schema instanceof z.ZodObject
         ? new Set(Object.keys(command.schema.shape))

src/key-manager.ts

@@ -1112,6 +1112,9 @@ export class KeyManager {
 
   /** Deactivate all keys (no key will be active). */
   async deactivateAllKeys(): Promise<void> {
+    if (!this.store) {
+      await this.initialize();
+    }
     if (!this.store) {
       throw new Error("Key store not initialized");
     }

src/keys-cli.ts

@@ -73,17 +73,16 @@ async function saveKeyInteractive(
       return key;
     }
 
-    const { activateNow } = await inquirer.prompt([
+    const { activateNow } = await inquirer.prompt<{ activateNow: boolean }>([
       {
         type: "confirm",
         name: "activateNow",
         message: `Set "${key.name}" as your active API key now?`,
         default: !isUpdate,
       },
     ]);
-    const shouldActivate = activateNow as boolean;
 
-    if (shouldActivate) {
+    if (activateNow) {
       await keyManager.setActiveKey(key.id);
       showSuccess(`"${key.name}" is now your active API key`);
       const updatedKey = await keyManager.getKeyMetadata(key.id);
@@ -194,7 +193,7 @@ async function saveKeyInteractive(
     return true;
   };
 
-  const { name } = await inquirer.prompt([
+  const { name } = await inquirer.prompt<{ name: string }>([
     {
       type: "input",
       name: "name",
@@ -213,13 +212,8 @@ async function saveKeyInteractive(
   try {
     const id =
       isUpdate && existingKey
-        ? await keyManager.updateKey(
-            existingKey.id,
-            name as string,
-            apiKey,
-            baseUrl
-          )
-        : await keyManager.addKey(name as string, apiKey, baseUrl);
+        ? await keyManager.updateKey(existingKey.id, name, apiKey, baseUrl)
+        : await keyManager.addKey(name, apiKey, baseUrl);
 
     spinner.succeed(
       isUpdate
@@ -229,7 +223,7 @@ async function saveKeyInteractive(
 
     const w = 12;
     console.log();
-    console.log(`  ${"Name:".padEnd(w)} ${chalk.white.bold(name as string)}`);
+    console.log(`  ${"Name:".padEnd(w)} ${chalk.white.bold(name)}`);
     console.log(`  ${"ID:".padEnd(w)} ${chalk.gray(id)}`);
     console.log(`  ${"Endpoint:".padEnd(w)} ${linkColor()(baseUrl)}`);
     console.log();
@@ -442,7 +436,9 @@ export async function handleKeysCommand(args: string[]): Promise<void> {
       }
 
       if (keyToDelete.isActive && otherKeys.length > 0) {
-        const { newActiveKey } = await inquirer.prompt([
+        const { newActiveKey } = await inquirer.prompt<{
+          newActiveKey: string;
+        }>([
           {
             type: "list" as const,
             name: "newActiveKey",
@@ -457,7 +453,7 @@ export async function handleKeysCommand(args: string[]): Promise<void> {
           },
         ]);
         if (newActiveKey !== "none") {
-          await keyManager.setActiveKey(newActiveKey as string);
+          await keyManager.setActiveKey(newActiveKey);
           const activated = otherKeys.find((k) => k.id === newActiveKey);
           if (activated) {
             showSuccess(`Switched to "${activated.name}"`);

src/output.ts

@@ -64,9 +64,18 @@ interface TableData {
   metadata: Record<string, unknown>;
 }
 
+function isObjectArray(value: unknown): value is Record<string, unknown>[] {
+  return (
+    Array.isArray(value) &&
+    value.length > 0 &&
+    typeof value[0] === "object" &&
+    value[0] !== null
+  );
+}
+
 function findTableData(data: unknown): TableData | null {
-  if (Array.isArray(data)) return { rows: data, metadata: {} };
-  if (data && typeof data === "object") {
+  if (isObjectArray(data)) return { rows: data, metadata: {} };
+  if (data && typeof data === "object" && !Array.isArray(data)) {
     const entries = Object.entries(data as Record<string, unknown>);
     for (const [arrayKey, value] of entries) {
       if (Array.isArray(value)) {

src/router.ts

@@ -90,12 +90,8 @@ export function parseArgs(argv: string[]): ParsedArgs {
   return { category, action, rest, globalFlags };
 }
 
-function getVersion(): string {
-  return PACKAGE_VERSION;
-}
-
 export function showVersion(): void {
-  console.log(`${COMMAND_NAME} ${getVersion()}`);
+  console.log(`${COMMAND_NAME} ${PACKAGE_VERSION}`);
 }
 
 interface KeyInfo {
@@ -125,7 +121,7 @@ async function getKeyInfo(): Promise<KeyInfo> {
 }
 
 export async function showGlobalHelp(): Promise<void> {
-  const version = getVersion();
+  const version = PACKAGE_VERSION;
   const categories = getCategories();
   const keyInfo = await getKeyInfo();
 
@@ -193,7 +189,7 @@ export async function showGlobalHelp(): Promise<void> {
     theme.bold("GLOBAL OPTIONS"),
     `  ${theme.accent("--help, -h")}        Show help`,
     `  ${theme.accent("--version, -V")}     Show version`,
-    `  ${theme.accent("--output")} <fmt>    Output format: ${OUTPUT_FORMATS.join(", ")} (default: pretty)`,
+    `  ${theme.accent("--output")} <fmt>    Output format: ${OUTPUT_FORMATS.join(", ")} (default: pretty in TTY, json when piped)`,
     `  ${theme.accent("--columns")} <cols>  Columns to show in table output (comma-separated)`,
     `  ${theme.accent("--json")} <data>     Pass raw JSON — bypasses all other flags (use '-' for stdin)`,
     `  ${theme.accent("--file")} <path>    Read JSON input from a file`,

src/utils/theme.ts

@@ -5,8 +5,6 @@ import { detectBackground } from "./detect-background.js";
 const mode = detectBackground();
 
 export const theme = {
-  mode,
-
   key: mode === "dark" ? chalk.hex("#7DD3FC") : chalk.hex("#0369A1"),
   value: mode === "dark" ? chalk.hex("#86EFAC") : chalk.green,
   number: mode === "dark" ? chalk.hex("#FDE68A") : chalk.yellow,

tests/unit/router.test.ts

@@ -90,4 +90,22 @@ describe("parseArgs", () => {
     expect(result.globalFlags.help).toBe(true);
     expect(result.action).toBeNull();
   });
+
+  it("extracts --force flag", () => {
+    const result = parseArgs(["--force", "lists", "delete", "123"]);
+    expect(result.globalFlags.force).toBe(true);
+    expect(result.category).toBe("lists");
+  });
+
+  it("extracts -f shorthand", () => {
+    const result = parseArgs(["-f", "lists", "delete"]);
+    expect(result.globalFlags.force).toBe(true);
+  });
+
+  it("extracts --file flag", () => {
+    const result = parseArgs(["--file", "data.json", "users", "bulk-update"]);
+    expect(result.globalFlags.file).toBe("data.json");
+    expect(result.category).toBe("users");
+    expect(result.action).toBe("bulk-update");
+  });
 });