From 42e898fd23e13193040d759ac9280c8821aed398 Mon Sep 17 00:00:00 2001 From: pedro_Simoes Date: Thu, 17 Jul 2025 18:03:19 -0300 Subject: [PATCH 1/2] Update largeWriteTest Improves the readability of the test. The assertions are clearer and include descriptive messages, making it easier to identify which assertion fails. This enhances code maintainability, understanding and debugging efficiency. Signed-off-by: pedro_Simoes --- .../org/janusgraph/graphdb/serializer/SerializerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java b/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java index 331c35f9f9..31e5e57446 100644 --- a/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java +++ b/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java @@ -245,8 +245,8 @@ public void largeWriteTest() { out.writeObjectNotNull(str.toString()); ReadBuffer b = out.getStaticBuffer().asReadBuffer(); if (printStats) log.debug(bufferStats(b)); - assertEquals(str.toString(), serialize.readObjectNotNull(b, String.class)); - assertFalse(b.hasRemaining()); + assertEquals(str.toString(), serialize.readObjectNotNull(b, String.class), "Serialized string does not match the original string"); + assertFalse(b.hasRemaining(), "The buffer has remaining data after reading"); } @Test From 6cdcc8cc1a70a553078f3fd8894bb94a5995e841 Mon Sep 17 00:00:00 2001 From: pedro_Simoes Date: Thu, 17 Jul 2025 18:09:23 -0300 Subject: [PATCH 2/2] Update testObjectVerification Signed-off-by: pedro_Simoes --- .../graphdb/serializer/SerializerTest.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java b/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java index 31e5e57446..2120ecb4a4 100644 --- a/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java +++ b/janusgraph-test/src/test/java/org/janusgraph/graphdb/serializer/SerializerTest.java @@ -212,22 +212,22 @@ public void testObjectVerification() { out.writeObject(null,TClass1.class); //Test failure - for (Object o : new Object[]{new TClass2("abc",2),Calendar.getInstance(), Lists.newArrayList()}) { + for (Object o : new Object[]{new TClass2("abc",2), Calendar.getInstance(), new java.util.ArrayList<>()}) { try { out.writeObjectNotNull(o); - fail(); + fail("Expected an exception but none was thrown"); } catch (Exception ignored) { } } ReadBuffer b = out.getStaticBuffer().asReadBuffer(); - assertEquals(t1, serialize.readClassAndObject(b)); - assertNull(serialize.readClassAndObject(b)); - assertEquals(t1, serialize.readObject(b, TClass1.class)); - assertNull(serialize.readObject(b, TClass1.class)); + assertEquals(t1, serialize.readClassAndObject(b), "The first object read does not match the expected TClass1 instance"); + assertNull(serialize.readClassAndObject(b), "Expected null for the second read but found a non-null value"); + assertEquals(t1, serialize.readObject(b, TClass1.class), "The third object read does not match the expected TClass1 instance"); + assertNull(serialize.readObject(b, TClass1.class), "Expected null for the fourth read but found a non-null value"); - assertFalse(b.hasRemaining()); + assertFalse(b.hasRemaining(), "Buffer should have no remaining data after all reads"); }