Scoped contexts and a proper precompilation workload#62
Open
JamesWrigley wants to merge 4 commits intomasterfrom
Open
Scoped contexts and a proper precompilation workload#62JamesWrigley wants to merge 4 commits intomasterfrom
JamesWrigley wants to merge 4 commits intomasterfrom
Conversation
This prevents a lingering task during precompilation.
JamesWrigley
force-pushed
the
precompile
branch
from
440b113 to
49602b5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 88.39% 88.65% +0.25%
==========================================
Files 12 13 +1
Lines 2232 2283 +51
==========================================
+ Hits 1973 2024 +51
Misses 259 259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesWrigley
force-pushed
the
precompile
branch
from
49602b5 to
9365ae3
Compare
This makes use of the scoped context and in-process worker support to have both the master and worker running in the same process for precompilation. Also lowered the sleep time for the launch Condition notification to 0.1s. This helps since the Condition is edge-triggered and launching an in-process worker usually takes less than 1s.
JamesWrigley
force-pushed
the
precompile
branch
from
9365ae3 to
311f2ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #61 and #58, this PR:
ContextClusterstate into aScopedValue. Since accessingScopedValue's can allocate I tried to minimize accesses in hot paths (like serialization and message handling) by assigning the value to a local variable.LocalManager.Scoped contexts could potentially be exposed as an API and used for multi-cluster support. The TTFW (Time-To-First-Worker) for
addprocs(1)dropped from ~1.8s to ~1s on Julia 1.12, and subsequent calls take ~0.8s.For reviewers, I've tried to keep each commit atomic so I'd recommend reviewing them one-by-one.