The properties 'creator', 'creation_time', 'editor', 'update_time' can be filled even if track_changes is set to false

Author: tencnivel

Project.toml

@@ -1,7 +1,7 @@
 name = "PostgresORM"
 uuid = "748b5efa-ed57-4836-b183-a38105a77fdd"
 authors = ["Vincent Laugier <vincent.laugier@gmail.com>"]
-version = "0.1.4"
+version = "0.1.5"
 
 [deps]
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"

src/Controller/coreORM.create.jl

@@ -13,39 +13,37 @@ function create_entity!(new_object::IEntity,
 
     query_string = "INSERT INTO " * table_name
 
+    #
+    # Enrich the created object with the creator and creation time if needed
+    #
+    creator_property = util_get_creator_property(orm_module)
+    if !ismissing(creator_property)
+         # Only set the creator property if it is empty because the rest of the
+         #  application may want to set it (eg. if importing data)
+         if ismissing(getproperty(new_object,creator_property))
+             setproperty!(new_object,
+                          creator_property,
+                          creator)
+         # If the object has the creator property set, use it
+         else
+             creator = getproperty(new_object,creator_property)
+         end
+    end
 
-    # Record the state of the attributes in the modification table
-    if util_get_track_changes(orm_module)
-
-         #
-         # Enrich the created object
-         #
-
-         creator_property = util_get_creator_property(orm_module)
-         if !ismissing(creator_property)
-              # Only set the creator property if it is empty because the rest of the
-              #  application may want to set it (eg. if importing data)
-              if ismissing(getproperty(new_object,creator_property))
-                  setproperty!(new_object,
-                               creator_property,
-                               creator)
-              # If the object has the creator property set, use it
-              else
-                  creator = getproperty(new_object,creator_property)
-              end
+    creation_time_property = util_get_creation_time_property(orm_module)
+    if !ismissing(creation_time_property)
+        # Only set the creation time if it is empty because the rest of the
+        #  application may want to set it (eg. if importing data)
+        if ismissing(getproperty(new_object, creation_time_property))
+            setproperty!(new_object,
+                         creation_time_property,
+                         now(Dates.UTC))
+        end
+    end
 
-         end
 
-         creation_time_property = util_get_creation_time_property(orm_module)
-         if !ismissing(creation_time_property)
-             # Only set the creation time if it is empty because the rest of the
-             #  application may want to set it (eg. if importing data)
-             if ismissing(getproperty(new_object, creation_time_property))
-                 setproperty!(new_object,
-                              creation_time_property,
-                              now(Dates.UTC))
-             end
-         end
+    # Record the state of the attributes in the modification table
+    if util_get_track_changes(orm_module)
 
          #
          # Create the modification entries
@@ -85,7 +83,7 @@ function create_entity!(new_object::IEntity,
 
          end
 
-    end # if track_changes
+    end # ENDOF if track_changes
 
     props = util_get_entity_props_for_db_actions(new_object,
                                                  dbconn,

src/Controller/coreORM.update.jl

@@ -89,7 +89,7 @@ function util_compare_and_sync_entities(previous_entities::Vector{<:IEntity},
     else
         data_type = typeof(new_entities[1])
     end
-    
+
     # ############################################################################## #
     # PART1. Identify the indexes of the entities for the different types of actions
     #   (i.e. remove the entity from the association, create and add an entity to
@@ -328,36 +328,34 @@ function update_entity!(updated_object::IEntity,
         return updated_object
     end
 
-    # Compare versions if needed, by retrieving the current state of the object
-    #   in the database
-    if util_get_track_changes(orm_module)
+    #
+    # Enrich the updated object with the creator and creation time if needed
+    #
+    editor_property = util_get_editor_property(orm_module)
+    if !ismissing(editor_property)
 
-         #
-         # Enrich the updated object
-         #
-         editor_property = util_get_editor_property(orm_module)
-         if !ismissing(editor_property)
-
-             # Only set the editor property if it is empty because the rest of the
-             #  application may want to set it (eg. if importing data)
-             if ismissing(getproperty(updated_object,editor_property))
-
-                 setproperty!(updated_object,
-                              editor_property,
-                              editor)
-             # If the object has the creator property set, use it
-             else
-                 editor = getproperty(updated_object,editor_property)
-             end
+        # Only set the editor property if it is empty because the rest of the
+        #  application may want to set it (eg. if importing data)
+        if ismissing(getproperty(updated_object,editor_property))
 
+            setproperty!(updated_object,
+                         editor_property,
+                         editor)
+        # If the object has the creator property set, use it
+        else
+            editor = getproperty(updated_object,editor_property)
+        end
+    end
+    update_time_property = util_get_update_time_property(orm_module)
+    if !ismissing(update_time_property)
+        setproperty!(updated_object,
+                     update_time_property,
+                     now(Dates.UTC))
+    end
 
-         end
-         update_time_property = util_get_update_time_property(orm_module)
-         if !ismissing(update_time_property)
-             setproperty!(updated_object,
-                          update_time_property,
-                          now(Dates.UTC))
-         end
+    # Compare versions if needed, by retrieving the current state of the object
+    #   in the database
+    if util_get_track_changes(orm_module)
 
          #
          # Create the modification entries
@@ -388,7 +386,7 @@ function update_entity!(updated_object::IEntity,
              create_entity!(modif,dbconn)
          end
 
-     end # if track_changes
+     end # ENDOF if track_changes
 
     # Create the dictionnary of properties for insertion in the database
     props = util_get_entity_props_for_db_actions(updated_object,