CreateSession is called twice

[LBBO]

When I click on Create session in the browser action popup, it initiates two request to /createSession where only one is required (and desired!).

[aditimaurya]

Hey, I would like to work on this issue. Can you please assign this to me? Please do let me know that in which file I need to do changes regarding this issue, so that I could contribute more efficiently without confusions. :)

[LBBO]

Hey, great to hear you want to contribute! I just want to briefly mention that Hacktoberfest is coming up. Feel free to wait until October before you actually open the PR if you want it to count towards your free T-shirt. This issue can easily wait until then.

---

The problem here is probably something with the message passing. In chrome plugins, only the background script is allowed to perform HTTP requests. So the process for creating a session is slightly more complicated than you might expect:

1. The user opens the browserAction popup by clicking on the plugin logo. They then click on Create session and a message is sent to their active tab (this happens in src/plugin/browser_action/components/ManageSession.vue).
2. The content script receives that message (src/plugin/contentScript/listenForBrowserActionEvents.ts) and does some stuff. Eventually, it sends a message to the background script.
3. src/plugin/backgroundScript.ts receives the message and sends a request to [server]/createSession.

Something happens in that process to cause two requests to be sent. Your task would be finding out what exactly that is and fixing it.

---

Some hints for development and debugging:

• npm run devServer runs the server locally
• Don't install the plugin from the zip file as described in the README. Instead, run npm run buildPlugin (after an npm i, of course) to build the plugin locally and then import the newly created dist/plugin folder as an unpacked plugin (instead of the folder you would have downloaded from the zip file).
• At the moment, you'll need to build the entire plugin and then reload it in Chrome to test your changes. To do that, run npm run buildPlugin and then click the little reload icon on the extensions page.
• On the extensions page, you'll find a link that says background page. Clicking on that will open up DevTools for that backgroundScript, where you can find a console and network tab. You can get DevTools for the popup by right-clicking it and then pressing Inspect element and anything logged by contentScript will appear in the normal DevTools console. These tools might come in handy, especially with this bug.

---

Hopefully, this answers most questions that might come up. If not, don't hesitate to ask! Thanks for your help!

[aditimaurya]

thanks a lot @LBBO , I'll give my best to fix this issue, and will make PR in October. Thanks for assigning to me .

[LBBO]

Hey @aditimaurya,

Just a quick heads up: in #24 I moved some files around that you might have been working with. They haven't really been changed, but src/plugin/browser_action/components/ManageSession.vue can now be found in src/plugin/user_interface/components/ManageSession.vue.

I hope, that doesn't disturb your work too much! If you face any problems with the new folder structure, just let me know!

[LBBO]

Hey @aditimaurya,

While working on #21 I found the source of this issue and now that I know what the exact problem is, I'd actually like to have it fixed rather quickly.

The problem is that I thought chrome.runtime.sendMessage only sends a message to the backgroundScript. Instead, it sends messages to every script provided by the plugin (except the for sender itself). That means that messages should always contain information as to who they are intended for, so I can still throw errors when unknown queries are received, without having to worry about whether the message was intended for another script.

Are you going to be able to take care of this soon? Otherwise I might take care of it myself because it does seem more important than I originally thought.

[aditimaurya]

Hey, please put a deadline so that I can keep that in mind while fixing this. I wanted to do it soon but please give a deadline so that it would be much better to work with a date. It pushes me to do it soon. I'll fix it. Don't worry.

[LBBO]

Alright, then I'll give you three days from now (until this Friday, 19:00 CEST)

[aditimaurya]

Hey @LBBO ! I apologise for not being able to meet the deadline and not able to resolve this issue. Please unassign me, I think I need to learn a lot more about typescript and it's functioning after that I'll be able to work, I worked a lot for that but it seems much difficult to me to solve it as a beginner.
Thanks for giving a chance, I've learnt a lot from this project !!!

[LBBO]

Hey @aditimaurya,

no problem, everybody starts somewhere and you never finish learning! Are you sure you want to give up? I could also give you a few pointers, how you might be able to fix the issue 😉