WhatsApp.disconnect() doesn't disconnect?

[f321x]

Calling .disconnect() on a WhatsApp client session just makes the client connect again (it emits a new connected event), is this intentional?
I would expect disconnect to permanently disconnect/stop the client until the user explicitly calls .connect() again.

[Labfox]

I'm going to try and investigate this, but I'll have to ask how you executed the library (especially before or after the 3b35b74 commit, which contained lots of refactoring and dependencies updates).

[Labfox]

You will probably need to backport the change if you want to try it on your branch. The functions haven't changed much, though.

[f321x]

I tried this change as part of the feat/newsletter-support branch, however the issue still seems to exist.
Running this simple code demonstrates the issue:

def get_whatsapp_client():
    client = WhatsApp(
        print_qr_code=True,
        on_event=lambda _, e: print(f"{e=}"),
        on_disconnect=lambda: print(f"disconnected callback"), 
        database_dir="/tmp"
    )
    client.connect()
    time.sleep(3)
    client.disconnect()

prints:

e={'eventType': 'isLoggedIn', 'loggedIn': True}
e={'eventType': 'Connected'}
disconnected callback
e={'eventType': 'Connected'}  <-- here it connects again, get_whatsapp_client doesn't return

# below is me spamming CTRL+C
^CException ignored while joining a thread in _thread._shutdown():
Traceback (most recent call last):
  File "/usr/lib64/python3.14/threading.py", line 1583, in _shutdown
    _thread_shutdown()
KeyboardInterrupt: 

[Labfox]

The problem seems to come from here. I tried a fix in 5f3962d which should solve the problem if Python or Whatsmeow was too slow.