fix(mcp,versioning,ingest): PG ROUND type error, hardcoded table names, direct transaction imports

mcp.ts: ROUND(AVG(salience), 4) fails on PG because AVG returns double
precision and ROUND(double precision, integer) does not exist in standard
PostgreSQL. Use AVG(salience) directly — JS precision is sufficient for
stats display. Also fix hardcoded 'waypoints' table name to use
waypoints_table variable, consistent with the table variable pattern.

versioning.ts, ingest.ts: replace direct transaction singleton import
with make_transaction() per-call factory, matching the pattern already
used in hsg.ts. Eliminates the latent consistency risk noted in the
security review (finding G).

Co-Authored-By: Claude <noreply@anthropic.com>
AI-Generated: true

Author: rbrenner

packages/openmemory-js/src/ai/mcp.ts

@@ -11,7 +11,7 @@ import {
     delete_memory,
     sector_configs,
 } from "../memory/hsg";
-import { q, all_async, memories_table, vector_store } from "../core/db";
+import { q, all_async, memories_table, waypoints_table, vector_store } from "../core/db";
 import { getEmbeddingInfo } from "../memory/embed";
 import { j, p } from "../utils";
 import type { sector_type, mem_row, rpc_err_code } from "../core/types";
@@ -657,7 +657,7 @@ export const create_mcp_srv = () => {
                 params,
             );
             const sector_rows = await all_async(
-                `SELECT primary_sector, COUNT(*) as count, ROUND(AVG(salience), 4) as avg_salience FROM ${memories_table} ${where} GROUP BY primary_sector`,
+                `SELECT primary_sector, COUNT(*) as count, AVG(salience) as avg_salience FROM ${memories_table} ${where} GROUP BY primary_sector`,
                 params,
             );
             const [dedup_row] = await all_async(
@@ -670,7 +670,7 @@ export const create_mcp_srv = () => {
                 [...params, seven_days_ago],
             );
             const [orphan_row] = await all_async(
-                `SELECT COUNT(*) as orphans FROM ${memories_table} m ${where ? where + ' AND' : 'WHERE'} NOT EXISTS (SELECT 1 FROM waypoints w WHERE w.src_id = m.id OR w.dst_id = m.id)`,
+                `SELECT COUNT(*) as orphans FROM ${memories_table} m ${where ? where + ' AND' : 'WHERE'} NOT EXISTS (SELECT 1 FROM ${waypoints_table} w WHERE w.src_id = m.id OR w.dst_id = m.id)`,
                 params,
             );
 

packages/openmemory-js/src/core/versioning.ts

@@ -7,7 +7,7 @@
  * - Version retrieval and comparison
  */
 
-import { run_async, all_async, get_async, q, transaction } from "./db";
+import { run_async, all_async, get_async, q, make_transaction } from "./db";
 import { env } from "./cfg";
 import { rid, now, j } from "../utils";
 
@@ -330,7 +330,8 @@ export async function restore_version(
 
     // Update the memory with restored content
     const new_version = current.version + 1;
-    await transaction.begin();
+    const txn = make_transaction();
+    await txn.begin();
     try {
         await q.upd_mem_with_sector.run(
             version.content,
@@ -340,7 +341,7 @@ export async function restore_version(
             now(),
             memory_id
         );
-        await transaction.commit();
+        await txn.commit();
 
         // Save the restored state as well
         await save_version(
@@ -356,7 +357,7 @@ export async function restore_version(
 
         return { success: true, new_version };
     } catch (e) {
-        await transaction.rollback();
+        await txn.rollback();
         throw e;
     }
 }

packages/openmemory-js/src/ops/ingest.ts

@@ -1,5 +1,5 @@
 import { add_hsg_memory } from "../memory/hsg";
-import { q, transaction } from "../core/db";
+import { q, make_transaction } from "../core/db";
 import { rid, now, j } from "../utils";
 import { extractText, ExtractionResult } from "./extract";
 import { enrichDocumentMetadata, parse_frontmatter, split_by_sections } from "./document_metadata";
@@ -46,7 +46,8 @@ const mkRoot = async (
     const cnt = `[Document: ${ex.metadata.content_type.toUpperCase()}]\n\n${sum}\n\n[Full content split across ${Math.ceil(txt.length / SEC)} sections]`;
     const id = rid(),
         ts = now();
-    await transaction.begin();
+    const txn = make_transaction();
+    await txn.begin();
     try {
         await q.ins_mem.run(
             id,
@@ -69,11 +70,11 @@ const mkRoot = async (
             user_id || "anonymous",
             null,
         );
-        await transaction.commit();
+        await txn.commit();
         return id;
     } catch (e) {
         console.error("[ERROR] Root failed:", e);
-        await transaction.rollback();
+        await txn.rollback();
         throw e;
     }
 };
@@ -108,15 +109,16 @@ const link = async (
     user_id?: string | null,
 ) => {
     const ts = now();
-    await transaction.begin();
+    const txn = make_transaction();
+    await txn.begin();
     try {
         await q.ins_waypoint.run(rid, cid, user_id || "anonymous", 1.0, ts, ts);
-        await transaction.commit();
+        await txn.commit();
         console.log(
             `[INGEST] Linked: ${rid.slice(0, 8)} -> ${cid.slice(0, 8)} (section ${idx})`,
         );
     } catch (e) {
-        await transaction.rollback();
+        await txn.rollback();
         console.error(`[INGEST] Link failed for section ${idx}:`, e);
         throw e;
     }