TeamParticipants not assigning staff to former properly

[fregerson]

Describe the bug
As title. If a staff (whose position is in Module:StaffRoles) is set to type=former, it is ignored and still remains in Staff Tab.

To Reproduce
See this example, of JiuZhe, ChenXia, and Zhijian in Royal Never Give Up

Expected behavior
Coaches should go in former as like others.

Screenshots

Current Display:

[fregerson]

Lua-Modules/lua/wikis/commons/TeamParticipants/Parse/Wiki.lua

Lines 206 to 209 in e5af811

	local hasNoStaffRoles = Array.all(roles, function(role) return role.type ~= RoleUtil.ROLE_TYPE.STAFF end)
	if playerType ~= 'staff' and not hasNoStaffRoles then
	playerType = 'staff'

Looks like this is the problem: If a player is given a role that is considered a Staff Role, then by default it is included as a Staff without any subsequent consideration. This causes the player.extradata.type to default as staff rather than former, which is why it will never show up in the Former Tab as having left (player.extradata.type != 'former')

Lua-Modules/lua/wikis/commons/Widget/Participants/Team/Roster.lua

Lines 123 to 131 in e5af811

	return ParticipantsTeamMember{
	player = player,
	team = playerTeamAsOpponent,
	even = index % 2 == 0,
	roleLeft = roleLeft,
	roleRight = roleRight,
	trophies = player.extradata.trophies or 0,
	strikethrough = player.extradata.type == 'former',
	}

[PiddyNydra]

How about, for former Staff we do:

• Strikethrough the name
• Sort them to the bottom of Staff list
• An contributor can add a note on Staff list about what happened there

thoughts?

[fregerson]

How about, for former Staff we do:

* Strikethrough the name

* Sort them to the bottom of `Staff` list

* An contributor can add a note on `Staff` list about what happened there

thoughts?

Would just be thinking in that case why can't players also be just pushed to the bottom of the players tab for consistency.

I am also thinking aloud, in wikis which don't manually specify players (instead just taking the first N players to store where N is the NvN mode of the game), if a starter goes to former, does it mean we have to manually go back to apply {{PlayerSubsitutions}} on all the old pages, rather than the new ones.