From fb63853f56d26b39dfc6b7cf7e736b220b5e0619 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 13:52:11 +0100 Subject: [PATCH 01/41] Integrate LuaLS setup and check in workflow Added setup and check steps for LuaLS in the workflow. --- .github/workflows/luacheck.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 4421a7e0320..82ab8b39c06 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -35,6 +35,16 @@ jobs: check_name: 'Lint Report' annotate_only: ${{ (github.event.pull_request.head.repo.full_name != github.repository) }} + - name: Setup LuaLS + run: | + curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz -o luals.tar.gz + tar -xzvf luals.tar.gz + + - name: Check LuaLS + run: | + ./bin/lua-language-server --check --logpath=luals-report.txt + cat luals-report.txt + lua-unit-test: runs-on: ubuntu-latest From f39cd6238bf4fe70aa732aae9e02d7498239d28d Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 13:54:29 +0100 Subject: [PATCH 02/41] Update LuaLS logging in luacheck workflow --- .github/workflows/luacheck.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 82ab8b39c06..e2c2d74e62f 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -42,8 +42,8 @@ jobs: - name: Check LuaLS run: | - ./bin/lua-language-server --check --logpath=luals-report.txt - cat luals-report.txt + ./bin/lua-language-server --check --logpath=luals-logs + cat luals-logs/* lua-unit-test: runs-on: ubuntu-latest From 684a38c01086b119dbfc06d3fbdc63613dafeaaa Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 13:56:09 +0100 Subject: [PATCH 03/41] Update LuaLS check to specify target directory --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index e2c2d74e62f..8fa68fc7dbb 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -42,7 +42,7 @@ jobs: - name: Check LuaLS run: | - ./bin/lua-language-server --check --logpath=luals-logs + ./bin/lua-language-server --check lua/wikis --logpath=luals-logs cat luals-logs/* lua-unit-test: From b7f6a3781e0a8a947375bae813cec292e8d5c1cd Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:01:14 +0100 Subject: [PATCH 04/41] Use config? --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 8fa68fc7dbb..4fdcd11d2d9 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -42,7 +42,7 @@ jobs: - name: Check LuaLS run: | - ./bin/lua-language-server --check lua/wikis --logpath=luals-logs + ./bin/lua-language-server --configpath .luarc.json --check lua/ --logpath luals-logs cat luals-logs/* lua-unit-test: From 68b7accdf77863c69e9af7a776f8d52abbdbd609 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:08:36 +0100 Subject: [PATCH 05/41] Update library paths in .luarc.json --- .luarc.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.luarc.json b/.luarc.json index dccb11b9059..863b63a4626 100644 --- a/.luarc.json +++ b/.luarc.json @@ -17,8 +17,8 @@ "name-style-check": "None" }, "workspace.library": [ - "${3rd}/busted/library", - "${3rd}/luassert/library" + "lua/3rd/busted/library", + "lua/3rd/luassert/library" ], "workspace.ignoreDir": [ ".vscode", From 61e5edf0dca9471764621ec8a44ef0d99337295d Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:22:10 +0100 Subject: [PATCH 06/41] Install 'busted' alongside 'luacheck' in workflow Added 'busted' as a dependency for Lua testing. --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 4fdcd11d2d9..74ae7096b44 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -20,7 +20,7 @@ jobs: - name: Setup dependencies run: | - luarocks install --lua-version=5.1 luacheck + luarocks install --lua-version=5.1 luacheck busted - name: Run lint run: | From 4d88e4b410fdf8a0e0f044704a5087be595562cf Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:23:31 +0100 Subject: [PATCH 07/41] install command --- .github/workflows/luacheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 74ae7096b44..5b8750d74bd 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -20,7 +20,8 @@ jobs: - name: Setup dependencies run: | - luarocks install --lua-version=5.1 luacheck busted + luarocks install --lua-version=5.1 luacheck + luarocks install --lua-version=5.1 busted - name: Run lint run: | From 9ef805423eddf57696957aaed1d5803ef3afa534 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:29:47 +0100 Subject: [PATCH 08/41] Revert: Update library paths in .luarc.json --- .luarc.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.luarc.json b/.luarc.json index 863b63a4626..dccb11b9059 100644 --- a/.luarc.json +++ b/.luarc.json @@ -17,8 +17,8 @@ "name-style-check": "None" }, "workspace.library": [ - "lua/3rd/busted/library", - "lua/3rd/luassert/library" + "${3rd}/busted/library", + "${3rd}/luassert/library" ], "workspace.ignoreDir": [ ".vscode", From bbb9090047547193e1abcbe53342b0de0a33f1e9 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:54:51 +0100 Subject: [PATCH 09/41] Adjust Streamlined the setup of LuaLS by combining curl and tar commands. --- .github/workflows/luacheck.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 5b8750d74bd..2de6b008119 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -38,13 +38,11 @@ jobs: - name: Setup LuaLS run: | - curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz -o luals.tar.gz - tar -xzvf luals.tar.gz + curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzvf - name: Check LuaLS run: | ./bin/lua-language-server --configpath .luarc.json --check lua/ --logpath luals-logs - cat luals-logs/* lua-unit-test: runs-on: ubuntu-latest From 07c6b0e119567354074918af374290c37546215e Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 14:57:35 +0100 Subject: [PATCH 10/41] Set env 3rd? Set environment variable for LuaLS check. --- .github/workflows/luacheck.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 2de6b008119..62571773540 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -41,6 +41,8 @@ jobs: curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzvf - name: Check LuaLS + env: + 3rd: /usr/lib/luarocks/rocks-5.1 run: | ./bin/lua-language-server --configpath .luarc.json --check lua/ --logpath luals-logs From 3e5b3913708262f5001a3ca55052c441f293105d Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:00:31 +0100 Subject: [PATCH 11/41] Fix output verbosity in LuaLS setup and update path --- .github/workflows/luacheck.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 62571773540..b0c1bc19f2a 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -38,11 +38,11 @@ jobs: - name: Setup LuaLS run: | - curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzvf + curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv - name: Check LuaLS env: - 3rd: /usr/lib/luarocks/rocks-5.1 + 3rd: ${{ github.workspace }}/.luarocks run: | ./bin/lua-language-server --configpath .luarc.json --check lua/ --logpath luals-logs From 8d18f17babe51a2702b30734cd75d7bb756af915 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:13:31 +0100 Subject: [PATCH 12/41] Add CI library paths to .luarc.json --- .luarc.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.luarc.json b/.luarc.json index dccb11b9059..f9e5e9624ff 100644 --- a/.luarc.json +++ b/.luarc.json @@ -18,7 +18,11 @@ }, "workspace.library": [ "${3rd}/busted/library", - "${3rd}/luassert/library" + "${3rd}/luassert/library", + + # In CI: + "meta/3rd/busted/library", + "meta/3rd/luassert/library" ], "workspace.ignoreDir": [ ".vscode", From 7b1237431ddb9caa7a72780d67f2fbfb30c123d5 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:14:55 +0100 Subject: [PATCH 13/41] Remove CI comment from .luarc.json Removed comment about CI from workspace.library. --- .luarc.json | 1 - 1 file changed, 1 deletion(-) diff --git a/.luarc.json b/.luarc.json index f9e5e9624ff..6d20b0bbc4b 100644 --- a/.luarc.json +++ b/.luarc.json @@ -20,7 +20,6 @@ "${3rd}/busted/library", "${3rd}/luassert/library", - # In CI: "meta/3rd/busted/library", "meta/3rd/luassert/library" ], From 9cbca4551455b86371060e5e966844aadb3ca1d4 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:16:14 +0100 Subject: [PATCH 14/41] Update library paths in .luarc.json --- .luarc.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.luarc.json b/.luarc.json index 6d20b0bbc4b..c8c0b3f971e 100644 --- a/.luarc.json +++ b/.luarc.json @@ -20,8 +20,8 @@ "${3rd}/busted/library", "${3rd}/luassert/library", - "meta/3rd/busted/library", - "meta/3rd/luassert/library" + "./meta/3rd/busted/library", + "./meta/3rd/luassert/library" ], "workspace.ignoreDir": [ ".vscode", From 8321402a719d5b9e3abeab97095f6d780d3bcddd Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:19:05 +0100 Subject: [PATCH 15/41] Simplify LuaLS check command Removed the configpath option from LuaLS check command. --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index b0c1bc19f2a..632bb08b5be 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -44,7 +44,7 @@ jobs: env: 3rd: ${{ github.workspace }}/.luarocks run: | - ./bin/lua-language-server --configpath .luarc.json --check lua/ --logpath luals-logs + ./bin/lua-language-server --check lua/ --logpath luals-logs lua-unit-test: runs-on: ubuntu-latest From 0e5eac4a0a55403a7125628f4b47bd84f6e06a71 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:19:53 +0100 Subject: [PATCH 16/41] Remove busted installation from luacheck workflow Removed installation of 'busted' from dependencies setup. --- .github/workflows/luacheck.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 632bb08b5be..6402ecec02e 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -21,7 +21,6 @@ jobs: - name: Setup dependencies run: | luarocks install --lua-version=5.1 luacheck - luarocks install --lua-version=5.1 busted - name: Run lint run: | @@ -41,8 +40,6 @@ jobs: curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv - name: Check LuaLS - env: - 3rd: ${{ github.workspace }}/.luarocks run: | ./bin/lua-language-server --check lua/ --logpath luals-logs From 781fdcf148805dd44e9d8b556469f4db0ddaed82 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:25:05 +0100 Subject: [PATCH 17/41] Add 'lua/spec' to workspace.ignoreDir --- .luarc.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.luarc.json b/.luarc.json index c8c0b3f971e..67f3f6d20df 100644 --- a/.luarc.json +++ b/.luarc.json @@ -25,6 +25,7 @@ ], "workspace.ignoreDir": [ ".vscode", - "lua/3rd" + "lua/3rd", + "lua/spec" ] } From 6d6e06f76ec117c79b18fbe9e46813b40e91f34d Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:29:14 +0100 Subject: [PATCH 18/41] Update LuaLS command to use config path --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 6402ecec02e..9478bb3654b 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -41,7 +41,7 @@ jobs: - name: Check LuaLS run: | - ./bin/lua-language-server --check lua/ --logpath luals-logs + ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check lua/ --logpath luals-logs lua-unit-test: runs-on: ubuntu-latest From 3733e9f91d8552aafc115df40d34dedc5ee97800 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:30:39 +0100 Subject: [PATCH 19/41] Revert changes to .luarc.json Removed unused library paths from workspace.library and workspace.ignoreDir. --- .luarc.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.luarc.json b/.luarc.json index 67f3f6d20df..c51cb22c5d9 100644 --- a/.luarc.json +++ b/.luarc.json @@ -19,13 +19,9 @@ "workspace.library": [ "${3rd}/busted/library", "${3rd}/luassert/library", - - "./meta/3rd/busted/library", - "./meta/3rd/luassert/library" ], "workspace.ignoreDir": [ ".vscode", "lua/3rd", - "lua/spec" ] } From 3f34d2275ecb6eac67e6bffa45ebecc47a2e7a64 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:34:08 +0100 Subject: [PATCH 20/41] Update .luarc.json --- .luarc.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.luarc.json b/.luarc.json index c51cb22c5d9..dccb11b9059 100644 --- a/.luarc.json +++ b/.luarc.json @@ -18,10 +18,10 @@ }, "workspace.library": [ "${3rd}/busted/library", - "${3rd}/luassert/library", + "${3rd}/luassert/library" ], "workspace.ignoreDir": [ ".vscode", - "lua/3rd", + "lua/3rd" ] } From 6f2b5a0fb0eaaf40720d2335aa66b9852b84560c Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:38:24 +0100 Subject: [PATCH 21/41] Add LuaLS report upload step in workflow Add artifact upload step for LuaLS report on failure --- .github/workflows/luacheck.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 9478bb3654b..28742aa72a8 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -43,6 +43,13 @@ jobs: run: | ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check lua/ --logpath luals-logs + - name: Report LuaLS + uses: actions/upload-artifact@v6.0.0 + if: failure() + with: + name: LuaLS-Result + path: luals-logs + lua-unit-test: runs-on: ubuntu-latest From 95dbfe23ff2a458ab68b612fe151613f31327cc2 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:47:33 +0100 Subject: [PATCH 22/41] Refactor LuaLS setup and checks in workflow --- .github/workflows/luacheck.yml | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 28742aa72a8..e20cb1a4b27 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -34,21 +34,6 @@ jobs: report_paths: 'report.xml' check_name: 'Lint Report' annotate_only: ${{ (github.event.pull_request.head.repo.full_name != github.repository) }} - - - name: Setup LuaLS - run: | - curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv - - - name: Check LuaLS - run: | - ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check lua/ --logpath luals-logs - - - name: Report LuaLS - uses: actions/upload-artifact@v6.0.0 - if: failure() - with: - name: LuaLS-Result - path: luals-logs lua-unit-test: runs-on: ubuntu-latest @@ -80,3 +65,14 @@ jobs: report_paths: 'busted.xml' check_name: 'Lua Test Report' annotate_only: ${{ (github.event.pull_request.head.repo.full_name != github.repository) }} + + luals-code-style: + runs-on: ubuntu-latest + steps: + - name: Setup LuaLS + run: | + curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv + + - name: Check + run: | + ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check lua/ From ff076d605fe7f68eeb46edbcad31407c9655e9a9 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:48:05 +0100 Subject: [PATCH 23/41] Update luacheck.yml --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index e20cb1a4b27..5e2dbbdcaa2 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -34,7 +34,7 @@ jobs: report_paths: 'report.xml' check_name: 'Lint Report' annotate_only: ${{ (github.event.pull_request.head.repo.full_name != github.repository) }} - + lua-unit-test: runs-on: ubuntu-latest From e46f2a0a6407263b622437f78d34ee778026cd21 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 15:51:21 +0100 Subject: [PATCH 24/41] Checkout --- .github/workflows/luacheck.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 5e2dbbdcaa2..41ea3347147 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -69,6 +69,9 @@ jobs: luals-code-style: runs-on: ubuntu-latest steps: + - name: Checkout + uses: actions/checkout@v6 + - name: Setup LuaLS run: | curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv From 5f0ab82407b6fe3be6136689b8e3655ddad93459 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 16:05:58 +0100 Subject: [PATCH 25/41] check parameter should be workspace root --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 41ea3347147..6471380e252 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -78,4 +78,4 @@ jobs: - name: Check run: | - ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check lua/ + ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check ./ From 582edba3f03cbe8734d3aa33115e786d412401c3 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 16:12:35 +0100 Subject: [PATCH 26/41] Install LuaLS into /usr/bin --- .github/workflows/luacheck.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 6471380e252..1214ec6b1c0 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -74,8 +74,9 @@ jobs: - name: Setup LuaLS run: | - curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv + mkdir -p /usr/bin/luals + curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv -C /usr/bin/luals - name: Check run: | - ./bin/lua-language-server --configpath ${{ github.workspace }}/.luarc.json --check ./ + /usr/bin/luals/bin/lua-language-server --check ./ From 2aef05970717e0d81ed07e756db76c3bbd494885 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 18 Feb 2026 16:14:36 +0100 Subject: [PATCH 27/41] ~/.local instead --- .github/workflows/luacheck.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 1214ec6b1c0..153d7647472 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -74,9 +74,9 @@ jobs: - name: Setup LuaLS run: | - mkdir -p /usr/bin/luals - curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv -C /usr/bin/luals + mkdir -p ~/.local/bin/luals + curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv -C ~/.local/bin/luals - name: Check run: | - /usr/bin/luals/bin/lua-language-server --check ./ + ~/.local/bin/luals/bin/lua-language-server --check ./ From 3cb84ea5a532c45757334f96e572ec35c1badc56 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 15:39:14 +0100 Subject: [PATCH 28/41] Issue warnings --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 153d7647472..0bc39f40869 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,4 +79,4 @@ jobs: - name: Check run: | - ~/.local/bin/luals/bin/lua-language-server --check ./ + ~/.local/bin/luals/bin/lua-language-server --check ./ | while read line; do if [[ $line =~ $pattern ]]; then echo "::warning file=${BASH_REMATCH[1]},line=${BASH_REMATCH[2]}::${BASH_REMATCH[4]}"; fi; done From a735967220d5a83df75244c4689f93d2ebc51081 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 15:45:56 +0100 Subject: [PATCH 29/41] Set pattern, use tee, readability --- .github/workflows/luacheck.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 0bc39f40869..bc87d2c4003 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,4 +79,11 @@ jobs: - name: Check run: | - ~/.local/bin/luals/bin/lua-language-server --check ./ | while read line; do if [[ $line =~ $pattern ]]; then echo "::warning file=${BASH_REMATCH[1]},line=${BASH_REMATCH[2]}::${BASH_REMATCH[4]}"; fi; done + pattern='([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)' + ~/.local/bin/luals/bin/lua-language-server --check ./ \ + | tee \ + | while read line; do \ + if [[ $line =~ $pattern ]]; then \ + echo "::warning file=${BASH_REMATCH[1]},line=${BASH_REMATCH[2]}::${BASH_REMATCH[4]}"; \ + fi; \ + done From e7043037a48c289323eced321c5db7a49810790d Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 15:54:05 +0100 Subject: [PATCH 30/41] Update luacheck.yml --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index bc87d2c4003..3c4983ee9bd 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,7 +79,7 @@ jobs: - name: Check run: | - pattern='([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)' + pattern='([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)'; ~/.local/bin/luals/bin/lua-language-server --check ./ \ | tee \ | while read line; do \ From e61ae6910929df61c0d0470e0684814f26a07f35 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 16:00:06 +0100 Subject: [PATCH 31/41] Pattern as env --- .github/workflows/luacheck.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 3c4983ee9bd..c3eb93aa67f 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -78,12 +78,13 @@ jobs: curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv -C ~/.local/bin/luals - name: Check + env: + PATTERN: '([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)' run: | - pattern='([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)'; ~/.local/bin/luals/bin/lua-language-server --check ./ \ - | tee \ | while read line; do \ - if [[ $line =~ $pattern ]]; then \ + echo $line; \ + if [[ $line =~ ${PATTERN} ]]; then \ echo "::warning file=${BASH_REMATCH[1]},line=${BASH_REMATCH[2]}::${BASH_REMATCH[4]}"; \ fi; \ done From 0110a9fd946180a9aafb8caa2b853b6c70b48fc1 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 16:07:09 +0100 Subject: [PATCH 32/41] echo pattern for test --- .github/workflows/luacheck.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index c3eb93aa67f..59b0428d8f1 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,8 +79,9 @@ jobs: - name: Check env: - PATTERN: '([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)' + PATTERN: '^([^:]+)' run: | + echo $PATTERN ~/.local/bin/luals/bin/lua-language-server --check ./ \ | while read line; do \ echo $line; \ From 38a2719939d3305c33e5f5fdbef3efe728575d0f Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 16:10:13 +0100 Subject: [PATCH 33/41] Specify shell --- .github/workflows/luacheck.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 59b0428d8f1..4888c1008c8 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,9 +79,9 @@ jobs: - name: Check env: - PATTERN: '^([^:]+)' + PATTERN: '^([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)' + shell: bash run: | - echo $PATTERN ~/.local/bin/luals/bin/lua-language-server --check ./ \ | while read line; do \ echo $line; \ From d0f8e0339addc239e5282b35cda9c19dcc2cab78 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 16:16:27 +0100 Subject: [PATCH 34/41] debug output --- .github/workflows/luacheck.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 4888c1008c8..44024234609 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -87,5 +87,7 @@ jobs: echo $line; \ if [[ $line =~ ${PATTERN} ]]; then \ echo "::warning file=${BASH_REMATCH[1]},line=${BASH_REMATCH[2]}::${BASH_REMATCH[4]}"; \ + else + echo "Does not match ${PATTERN}, ${BASH_REMATCH}" fi; \ done From 236fd58b1ea54df04061fddbf5510eaa289290fb Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 16:19:56 +0100 Subject: [PATCH 35/41] Adjust pattern for injected colors --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 44024234609..4cac7c3e3c7 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,7 +79,7 @@ jobs: - name: Check env: - PATTERN: '^([^:]+):([0-9]+):([0-9]+) \[Warning\] (.*)' + PATTERN: '([^:]+):([0-9]+):([0-9]+)(.*?)\[Warning\](.*?) (.*)' shell: bash run: | ~/.local/bin/luals/bin/lua-language-server --check ./ \ From 41b36bf7ba2c7203148d897bf7e7bd081e03e21f Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 16:24:29 +0100 Subject: [PATCH 36/41] Update luacheck.yml --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 4cac7c3e3c7..e6facb33491 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -79,7 +79,7 @@ jobs: - name: Check env: - PATTERN: '([^:]+):([0-9]+):([0-9]+)(.*?)\[Warning\](.*?) (.*)' + PATTERN: '.*?(lua[^:]+):([0-9]+):([0-9]+).*?\[Warning\][^ ]*? (.*)' shell: bash run: | ~/.local/bin/luals/bin/lua-language-server --check ./ \ From b6bf340e704520a07fb520e76ecc1ca77cf8c938 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 17:32:29 +0100 Subject: [PATCH 37/41] Use sed --- .github/workflows/luacheck.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index e6facb33491..cc5f11c47cd 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -78,16 +78,7 @@ jobs: curl -L https://github.com/LuaLS/lua-language-server/releases/download/3.17.1/lua-language-server-3.17.1-linux-x64.tar.gz | tar -xzv -C ~/.local/bin/luals - name: Check - env: - PATTERN: '.*?(lua[^:]+):([0-9]+):([0-9]+).*?\[Warning\][^ ]*? (.*)' shell: bash run: | ~/.local/bin/luals/bin/lua-language-server --check ./ \ - | while read line; do \ - echo $line; \ - if [[ $line =~ ${PATTERN} ]]; then \ - echo "::warning file=${BASH_REMATCH[1]},line=${BASH_REMATCH[2]}::${BASH_REMATCH[4]}"; \ - else - echo "Does not match ${PATTERN}, ${BASH_REMATCH}" - fi; \ - done + | sed -n 'p;s/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]*/::warning file=\1,line=\2::/p' From a5c0e252053f2fb9cef40e2f751ab806c4227fc8 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 17:51:33 +0100 Subject: [PATCH 38/41] Use temp file --- .github/workflows/luacheck.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index cc5f11c47cd..e15e4600e38 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -80,5 +80,5 @@ jobs: - name: Check shell: bash run: | - ~/.local/bin/luals/bin/lua-language-server --check ./ \ - | sed -n 'p;s/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]*/::warning file=\1,line=\2::/p' + ~/.local/bin/luals/bin/lua-language-server --check ./ | tee luals-check + cat luals-check | (sed -e 's/\x1b\[[0-9;]*m//g'| sed -n 's/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]* \[Warning\] /::warning file=\1,line=\2::/p') From 2e43d314651ad0139dc427a6415b38ef8ba685d0 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 17:59:11 +0100 Subject: [PATCH 39/41] Continue on fail --- .github/workflows/luacheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index e15e4600e38..8a809eb29bb 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -80,5 +80,5 @@ jobs: - name: Check shell: bash run: | - ~/.local/bin/luals/bin/lua-language-server --check ./ | tee luals-check + ~/.local/bin/luals/bin/lua-language-server --check ./ | tee luals-check && true cat luals-check | (sed -e 's/\x1b\[[0-9;]*m//g'| sed -n 's/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]* \[Warning\] /::warning file=\1,line=\2::/p') From bf3b0462b113676a44e9aab3803a351a40fb3766 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 18:34:25 +0100 Subject: [PATCH 40/41] upload result --- .github/workflows/luacheck.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 8a809eb29bb..18a63f055b2 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -82,3 +82,8 @@ jobs: run: | ~/.local/bin/luals/bin/lua-language-server --check ./ | tee luals-check && true cat luals-check | (sed -e 's/\x1b\[[0-9;]*m//g'| sed -n 's/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]* \[Warning\] /::warning file=\1,line=\2::/p') + + - name: 'Upload Artifact' + uses: actions/upload-artifact@v4 + with: + path: luals-check From 2fd9ba32b4aed71286ccfba19019b3d2e45f28ed Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 11 Mar 2026 18:54:14 +0100 Subject: [PATCH 41/41] Produce summary --- .github/workflows/luacheck.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml index 18a63f055b2..2c6c226cc30 100644 --- a/.github/workflows/luacheck.yml +++ b/.github/workflows/luacheck.yml @@ -82,8 +82,6 @@ jobs: run: | ~/.local/bin/luals/bin/lua-language-server --check ./ | tee luals-check && true cat luals-check | (sed -e 's/\x1b\[[0-9;]*m//g'| sed -n 's/\(lua[^:]\+\):\([[:digit:]]*\):[[:digit:]]* \[Warning\] /::warning file=\1,line=\2::/p') - - - name: 'Upload Artifact' - uses: actions/upload-artifact@v4 - with: - path: luals-check + echo "| | Files | Warnings |" >> $GITHUB_STEP_SUMMARY + echo "|-|-------|----------|" >> $GITHUB_STEP_SUMMARY + echo "| LuaLS check | $(find lua -name '*.lua' | wc -l) | $(cat luals-check | grep 'Warning' | wc -l) |" >> $GITHUB_STEP_SUMMARY