-
Notifications
You must be signed in to change notification settings - Fork 64
Open
Description
Summary
Currently, PartyManager.VoteKick in Maple2.Server.World/Containers/PartyManager.cs (around line 406) reuses Constants.PartyVoteReadyDurationSeconds as the timeout duration for the vote-kick Thread.Sleep call. A TODO comment in the code already acknowledges this is incorrect.
Expected Fix
- Add a new
PartyVoteKickDurationSecondsvariable toConstants(Maple2.Model/Metadata/Constants.cs) as a custom constant with the correct value. There isn't a key inconstants.xmlfor such a value. - Replace the use of
Constants.PartyVoteReadyDurationSecondsin theTask.Factory.StartNewlambda insideVoteKickwithConstants.PartyVoteKickDurationSeconds. - Remove the TODO comment once resolved.
Context
- Identified during review of PR
#661(Remove hardcoded server constants and use parsed constants from Server.m2d / constants.xml #661 (comment)) - Deferred from PR
#661because the correct constant value has not yet been determined.
Requested by
@mfranca0009
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels