[BUG] onUpdateLevel is not called for starter bros and town roster bros

[Suor]

Judging by MSU code onUpdateLevel() is only called for your bros.

[LordMidas]

Yes. It is called from a hookTree on starting_scenario.onUpdateLevel. Therefore, whenever vanilla calls that function for a bro this will be called for that bro.

This is similar to vanilla issue where they don't call onHired for starting bros.

What do you propose?

[Suor]

In Bro Studio I fix it by calling my function from player.onHired(), player.updateLevel() and scenario.onSpawnAssets():

These are not the best places just what I use now, i.e. world_state.startNewCampaign() is better place than scenario.onSpawnAssets() because it rewrites and regenerates some stuff after onSpawnAssets(). But may think into this direction.

Another is one will need to pass a level num, because we may call it for a bro level 5 already and it's too late to inspect this.m.Level. So some new on function will probably be needed.

[Suor]

player.onHired() is also questionable, because this way we delay on funcs until after bro is hired, which means tryout info might be inaccurate, say if we add a trait in there, which I actually do in Bro Studio, but too many traits may break UI, so I leave it like this.