Enforce warning-as-error and fix LSP warning diagnostics

Author: pchalamet

Directory.Build.props

@@ -11,5 +11,6 @@
     <AssemblyVersion>$(Version)</AssemblyVersion>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
     <ImplicitUsings>enable</ImplicitUsings>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 </Project>

src/FScript.LanguageServer/LspHandlers.fs

@@ -1121,10 +1121,11 @@ module LspHandlers =
                 | None -> None
                 | Some name ->
                     let assembly = typeof<Span>.Assembly
-                    use stream = assembly.GetManifestResourceStream(name)
-                    if isNull stream then
+                    match assembly.GetManifestResourceStream(name) with
+                    | null ->
                         None
-                    else
+                    | stream ->
+                        use stream = stream
                         use reader = new StreamReader(stream)
                         Some (reader.ReadToEnd())
         with _ ->

src/FScript.LanguageServer/LspSymbols.fs

@@ -398,6 +398,8 @@ module LspSymbols =
                 | None -> ()
             | SExpr _ ->
                 ()
+            | SInclude _ ->
+                ()
 
         result
 
@@ -432,6 +434,8 @@ module LspSymbols =
                 | None -> ()
             | SExpr _ ->
                 ()
+            | SInclude _ ->
+                ()
 
         collected.Values |> Seq.toList