Improve output from mariadb-secure-installation to be more honest #4457
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script is likely misleading to users stating 'SUCCESS' about things it didn't do anything about, leading to false sense of security. Improve the output to be more clear about what it is doing or is not doing.
svoj
added
the
External Contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The script is likely misleading to users stating 'SUCCESS' about things it didn't do anything about, leading to false sense of security. Improve the output to be more clear about what it is doing or is not doing.
Release Notes
How can this PR be tested?
Run the script in a container with a fresh MariaDB installation.
This has been in Debian (https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/785f072ac8230a57d683cf07ced225a72ed9a9c7) for 5 months without any reports of issues.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check