diff --git a/app/test/testlinks.cpp b/app/test/testlinks.cpp index 3e57c87f1..6cad9516d 100644 --- a/app/test/testlinks.cpp +++ b/app/test/testlinks.cpp @@ -28,7 +28,8 @@ void UrlTester::processFinished() } else { - qDebug() << " URL " << mUrl << " ...ERROR"; + // for CI debugging + qDebug() << " URL " << mUrl << " ...ERROR. " << r->error(); mResult = 1; } r->deleteLater(); diff --git a/app/test/testmerginapi.cpp b/app/test/testmerginapi.cpp index b066163d5..cf480b655 100644 --- a/app/test/testmerginapi.cpp +++ b/app/test/testmerginapi.cpp @@ -2500,9 +2500,9 @@ void TestMerginApi::testCreateWorkspace() QSKIP( "testCreateWorkspace requires USE_MM_SERVER_API_KEY" ); #endif // we need to register new user for tests and assign its credentials to env vars - QString username = TestUtils::generateUsername(); QString password = TestUtils::generatePassword(); QString email = TestUtils::generateEmail(); + QString username = email.left( email.lastIndexOf( '@' ) ); qDebug() << "REGISTERING NEW TEST USER WITH EMAIL:" << email; diff --git a/app/test/testutils.cpp b/app/test/testutils.cpp index 97abca5cd..3c65c7ccb 100644 --- a/app/test/testutils.cpp +++ b/app/test/testutils.cpp @@ -118,19 +118,19 @@ bool TestUtils::needsToAuthorizeAgain( MerginApi *api, const QString &username ) return false; } - -QString TestUtils::generateUsername() -{ - QDateTime time = QDateTime::currentDateTime(); - QString uniqename = time.toString( QStringLiteral( "ddMMyy-hhmmss-z" ) ); - return QStringLiteral( "mobile-%1" ).arg( uniqename ); -} - QString TestUtils::generateEmail() { +#if defined(Q_OS_MACOS) + QString prefix = QStringLiteral( "mac" ); +#elif defined(Q_OS_LINUX) + QString prefix = QStringLiteral( "lin" ); +#else + QString prefix = QStringLiteral( "mob" ); +#endif QDateTime time = QDateTime::currentDateTime(); - QString uniqename = time.toString( QStringLiteral( "ddMMyy-hhmmss-z" ) ); - return QStringLiteral( "mobile-autotest+%1@lutraconsulting.co.uk" ).arg( uniqename ); + QString uniqeName = time.toString( QStringLiteral( "ddMMyy-hhmmss" ) ); + // adding the prefix and the uniqueName + return QStringLiteral( "%1-%2@lutraconsulting.co.uk" ).arg( prefix, uniqeName ); } QString TestUtils::generatePassword() @@ -139,27 +139,12 @@ QString TestUtils::generatePassword() return QStringLiteral( "_Pass12%1" ).arg( pass ); } -QString TestUtils::generateWorkspaceName( const QString &username ) -{ - static const QRegularExpression regex( R"(mobile-autotest(\d{6})-(\d{4})\d{2}-\d{3})" ); - const QRegularExpressionMatch match = regex.match( username ); - - if ( match.hasMatch() ) - { - const QString date = match.captured( 1 ); // Day Month Year - const QString time = match.captured( 2 ); // Hour Second - return QString( "mmat-%1-%2" ).arg( date, time ); - } - return {}; -} - void TestUtils::generateRandomUser( MerginApi *api, QString &username, QString &password ) { // generate the test run-specific user details QString email = generateEmail(); password = generatePassword(); - username = email.split( '@' ).first(); - username.remove( "+" ); + username = email.left( email.lastIndexOf( '@' ) ); // create the account for the test run user api->clearAuth(); @@ -182,11 +167,10 @@ void TestUtils::generateRandomUser( MerginApi *api, QString &username, QString & // create workspace QSignalSpy wsSpy( api, &MerginApi::workspaceCreated ); // create the workspace name - QString workspace = generateWorkspaceName( username ); - api->createWorkspace( workspace ); + api->createWorkspace( username ); bool workspaceSuccess = wsSpy.wait( TestUtils::LONG_REPLY ); QVERIFY( workspaceSuccess ); - qDebug() << "CREATED NEW WORKSPACE:" << workspace; + qDebug() << "CREATED NEW WORKSPACE:" << username; // call userInfo to set active workspace QSignalSpy infoSpy( api, &MerginApi::userInfoReplyFinished ); @@ -211,7 +195,7 @@ void TestUtils::generateRandomUser( MerginApi *api, QString &username, QString & bool workspaceStorageModified = wsStorageSpy.wait( TestUtils::LONG_REPLY ); if ( workspaceStorageModified ) { - qDebug() << "Updated the storage limit" << workspace; + qDebug() << "Updated the storage limit" << username; } // this needs to be cleared, as the user will be authorized in the test cases. diff --git a/app/test/testutils.h b/app/test/testutils.h index c24d8afeb..8643248fa 100644 --- a/app/test/testutils.h +++ b/app/test/testutils.h @@ -43,15 +43,8 @@ namespace TestUtils bool needsToAuthorizeAgain( MerginApi *api, const QString &username ); void generateRandomUser( MerginApi *api, QString &username, QString &password ); - QString generateUsername(); QString generateEmail(); QString generatePassword(); - /* - * Create a workspace name from the generated username - * Output: a workspace name: mmat-DayMonthYear-HourMinutes - */ - QString generateWorkspaceName( const QString &username ); - QString testDataDir(); QgsProject *loadPlanesTestProject();