From eec4fa941027bcfa26e261219d373d93e2c6083f Mon Sep 17 00:00:00 2001 From: Prashant27-07 Date: Wed, 4 Mar 2026 20:44:14 +0530 Subject: [PATCH 1/3] [222_51] fix: change tooltip from Toggle numbering to Toggle cell alignment (#2938) --- TeXmacs/progs/table/table-menu.scm | 9 +++++++++ devel/222_51.md | 18 ++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 devel/222_51.md diff --git a/TeXmacs/progs/table/table-menu.scm b/TeXmacs/progs/table/table-menu.scm index aca65903de..f507087b1e 100644 --- a/TeXmacs/progs/table/table-menu.scm +++ b/TeXmacs/progs/table/table-menu.scm @@ -643,3 +643,12 @@ ((balloon (icon "tm_cell_join.xpm") "Join selected cells") (cell-set-span-selection))))) +(tm-menu (focus-toggle-icons t) + (:require (table-markup-context? t)) + (push-focus t + (assuming (numbered-context? t) + ((check (balloon (icon "tm_numbered.xpm") "Toggle cell alignment") "v" + (pull-focus t + (numbered-numbered? t))) + (pull-focus t (numbered-toggle t)))))) + \ No newline at end of file diff --git a/devel/222_51.md b/devel/222_51.md new file mode 100644 index 0000000000..3972073a69 --- /dev/null +++ b/devel/222_51.md @@ -0,0 +1,18 @@ +# [222_51] Fix misleading tooltip in tabular context + +## How to test + +1. Open Mogan +2. Insert a table: Insert → Table → Plain tabular +3. Click inside the table +4. Check the focus toolbar — the tooltip for the numbered icon should now say "Toggle cell alignment" instead of "Toggle numbering" +## What +The tooltip "Toggle numbering" was misleading in tabular context. + +## Why + +The button actually toggles cell alignment (tabular vs tabular*), not numbering. + +## How + +Added a table-specific override in table-menu.scm using (:require (table-markup-context? t)) \ No newline at end of file From 26b2a9cb03152f29066539ee02a6d9fb95776714 Mon Sep 17 00:00:00 2001 From: Prashant27-07 Date: Mon, 9 Mar 2026 19:04:43 +0530 Subject: [PATCH 2/3] fix: clean up devel/222_51.md to remove merged content --- devel/222_51.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/devel/222_51.md b/devel/222_51.md index 3972073a69..6834ae12d8 100644 --- a/devel/222_51.md +++ b/devel/222_51.md @@ -1,18 +1,17 @@ # [222_51] Fix misleading tooltip in tabular context -## How to test - -1. Open Mogan -2. Insert a table: Insert → Table → Plain tabular -3. Click inside the table -4. Check the focus toolbar — the tooltip for the numbered icon should now say "Toggle cell alignment" instead of "Toggle numbering" ## What The tooltip "Toggle numbering" was misleading in tabular context. ## Why - The button actually toggles cell alignment (tabular vs tabular*), not numbering. ## How +Added a table-specific override in table-menu.scm using (:require (table-markup-context? t)) + +## How to test +1. Open Mogan +2. Insert a table: Insert + Table + Plain tabular +3. Click inside the table +4. Check the focus toolbar – the tooltip should now say "Toggle cell alignment" instead of "Toggle numbering" -Added a table-specific override in table-menu.scm using (:require (table-markup-context? t)) \ No newline at end of file From 12695c859d1613d7e1f3f558a713dbfffd8a3d55 Mon Sep 17 00:00:00 2001 From: Prashant27-07 Date: Mon, 9 Mar 2026 19:16:47 +0530 Subject: [PATCH 3/3] fix: override alternate icons for tabular context --- TeXmacs/progs/table/table-menu.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/TeXmacs/progs/table/table-menu.scm b/TeXmacs/progs/table/table-menu.scm index f507087b1e..600790c34f 100644 --- a/TeXmacs/progs/table/table-menu.scm +++ b/TeXmacs/progs/table/table-menu.scm @@ -651,4 +651,10 @@ (pull-focus t (numbered-numbered? t))) (pull-focus t (numbered-toggle t)))))) - \ No newline at end of file + (tm-define (alternate-first-icon t) + (:require (table-markup-context? t)) + "tm_cell_left.xpm") + +(tm-define (alternate-second-icon t) + (:require (table-markup-context? t)) + "tm_cell_center.xpm") \ No newline at end of file