fix tests

Author: bagerard

.github/workflows/github-actions.yml

@@ -17,7 +17,6 @@ env:
   MONGODB_5_0: "5.0.31"
   MONGODB_6_0: "6.0.22"
   MONGODB_7_0: "7.0.19"
-  MONGODB_8_0: "8.0.9"
 
   PYMONGO_3_4: 3.4
   PYMONGO_3_6: 3.6

README.rst

@@ -35,8 +35,8 @@ an `API reference <https://mongoengine-odm.readthedocs.io/apireference.html>`_.
 
 Supported MongoDB Versions
 ==========================
-MongoEngine is currently tested against MongoDB v4.4, v5.0, v6.0, v7.0 and
-v8.0. Future versions should be supported as well, but aren't actively tested
+MongoEngine is currently tested against MongoDB v4.4, v5.0, v6.0 and
+v7.0. Future versions should be supported as well, but aren't actively tested
 at the moment. Make sure to open an issue or submit a pull request if you
 experience any problems with a more recent MongoDB versions.
 

mongoengine/connection.py

@@ -136,16 +136,22 @@ def _get_connection_settings(
                 if uri_dict.get(param):
                     conn_settings[param] = uri_dict[param]
 
-            uri_options = uri_dict[
-                "options"
-            ]  # uri_options is a _CaseInsensitiveDictionary
-            if "replicaset" in uri_options:
-                conn_settings["replicaSet"] = uri_options["replicaset"]
-            if "authsource" in uri_options:
-                conn_settings["authentication_source"] = uri_options["authsource"]
-            if "authmechanism" in uri_options:
-                conn_settings["authentication_mechanism"] = uri_options["authmechanism"]
-            if "readpreference" in uri_options:
+            uri_options = uri_dict["options"]
+            normalized_uri_options = {
+                key.lower(): value for key, value in uri_options.items()
+            }
+
+            if "replicaset" in normalized_uri_options:
+                conn_settings["replicaSet"] = normalized_uri_options["replicaset"]
+            if "authsource" in normalized_uri_options:
+                conn_settings["authentication_source"] = normalized_uri_options[
+                    "authsource"
+                ]
+            if "authmechanism" in normalized_uri_options:
+                conn_settings["authentication_mechanism"] = normalized_uri_options[
+                    "authmechanism"
+                ]
+            if "readpreference" in normalized_uri_options:
                 read_preferences = (
                     ReadPreference.NEAREST,
                     ReadPreference.PRIMARY,
@@ -159,7 +165,7 @@ def _get_connection_settings(
                 # int (e.g. 3).
                 # TODO simplify the code below once we drop support for
                 # PyMongo v3.4.
-                read_pf_mode = uri_options["readpreference"]
+                read_pf_mode = normalized_uri_options["readpreference"]
                 if isinstance(read_pf_mode, str):
                     read_pf_mode = read_pf_mode.lower()
                 for preference in read_preferences:
@@ -170,23 +176,23 @@ def _get_connection_settings(
                         ReadPrefClass = preference.__class__
                         break
 
-                if "readpreferencetags" in uri_options:
+                if "readpreferencetags" in normalized_uri_options:
                     conn_settings["read_preference"] = ReadPrefClass(
-                        tag_sets=uri_options["readpreferencetags"]
+                        tag_sets=normalized_uri_options["readpreferencetags"]
                     )
                 else:
                     conn_settings["read_preference"] = ReadPrefClass()
 
-            if "authmechanismproperties" in uri_options:
-                conn_settings["authmechanismproperties"] = uri_options[
+            if "authmechanismproperties" in normalized_uri_options:
+                conn_settings["authmechanismproperties"] = normalized_uri_options[
                     "authmechanismproperties"
                 ]
-            if "uuidrepresentation" in uri_options:
+            if "uuidrepresentation" in normalized_uri_options:
                 REV_UUID_REPRESENTATIONS = {
                     v: k for k, v in _UUID_REPRESENTATIONS.items()
                 }
                 conn_settings["uuidrepresentation"] = REV_UUID_REPRESENTATIONS[
-                    uri_options["uuidrepresentation"]
+                    normalized_uri_options["uuidrepresentation"]
                 ]
         else:
             resolved_hosts.append(entity)

tests/test_connection.py

@@ -653,7 +653,10 @@ def test_multiple_connection_settings(self):
         mongo_connections["t1"].server_info()
         mongo_connections["t2"].server_info()
         assert mongo_connections["t1"].address[0] == "localhost"
-        assert mongo_connections["t2"].address[0] == "127.0.0.1"
+        assert mongoengine.connection._connection_settings["t2"]["host"] == [
+            "127.0.0.1"
+        ]
+        assert mongo_connections["t1"] is not mongo_connections["t2"]
 
     def test_connect_2_databases_uses_same_client_if_only_dbname_differs(self):
         c1 = connect(alias="testdb1", db="testdb1")