Skip to content

fix: continue after deferred MCP startup failures#2355

Open
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/mcp-timeout-soft-failure
Open

fix: continue after deferred MCP startup failures#2355
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/mcp-timeout-soft-failure

Conversation

@he-yufeng
Copy link
Copy Markdown

@he-yufeng he-yufeng commented May 23, 2026

Summary

  • keep deferred MCP startup failures from aborting the interactive turn
  • log the failed startup and continue without the unavailable MCP servers
  • add a regression test for the background MCP wait path

Fixes #2343.

To verify

  • uv run pytest tests\core\test_kimisoul_mcp.py -q
  • uv run pytest tests\core\test_kimisoul_mcp.py tests\core\test_kimisoul_steer.py -q
  • uv run python -m py_compile src\kimi_cli\soul\kimisoul.py tests\core\test_kimisoul_mcp.py
  • uv run ruff check src\kimi_cli\soul\kimisoul.py tests\core\test_kimisoul_mcp.py
  • uv run ruff format --check src\kimi_cli\soul\kimisoul.py tests\core\test_kimisoul_mcp.py
  • git diff --check

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP 连接超时导致整个 CLI 不可用 || MCP connection timeout causes the entire CLI to be unavailable

1 participant