Feature/fqcn 178 (#224)

Uses FQCN for Ansible Modules. "Fixes" Issue #178 

fixes #178

---------

Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>

Author: lcndsmr

.config/ansible-lint.yml

@@ -14,6 +14,5 @@ skip_list:
   - 'command-instead-of-module'
   - 'role-name'
   - 'line-length'
-  - 'fqcn-builtins'
   - 'package-latest'
   - yaml  # Violations reported by yamllint.

README.md

@@ -179,10 +179,10 @@ The execution order of the roles is important! (see below)
     #  elasticstack_release: 8 #7
   pre_tasks:
     - name: Install Rsyslog
-      package:
+      ansible.builtin.package:
         name: rsyslog
     - name: Start rsyslog
-      service:
+       ansible.builtin.service:
         name: rsyslog
         state: started
         enabled: true

molecule/beats_default/converge.yml

@@ -14,8 +14,8 @@
     elasticstack_release: "{{ lookup('env', 'ELASTIC_RELEASE') | int}}"
   tasks:
     - name: Include Elastics repos role
-      include_role:
+      ansible.builtin.include_role:
         name: repos
     - name: Include Beats
-      include_role:
+      ansible.builtin.include_role:
         name: beats

molecule/beats_default/prepare.yml

@@ -3,7 +3,7 @@
   hosts: all
   tasks:
     - name: Install packages for Debian
-      apt:
+      ansible.builtin.apt:
         name:
           - gpg
           - gpg-agent

molecule/beats_default/verify.yml

@@ -5,5 +5,5 @@
   hosts: all
   tasks:
   - name: Example assertion
-    assert:
+    ansible.builtin.assert:
       that: true

molecule/beats_peculiar/converge.yml

@@ -37,27 +37,27 @@
   tasks:
 
     - name: Set Filebeat version for 7.x
-      set_fact:
+      ansible.builtin.set_fact:
         elasticstack_version: "7.17.1"
       when:
         - elasticstack_release == 7
 
     - name: Set Filebeat version for 8.x
-      set_fact:
+      ansible.builtin.set_fact:
         elasticstack_version: "8.4.1"
       when:
         - elasticstack_release == 8
 
     - name: "Include Elastics repos role"
-      include_role:
+      ansible.builtin.include_role:
         name: repos
 
     - name: Refresh apt cache
-      apt:
+      ansible.builtin.apt:
         update_cache: yes
       changed_when: false
       when: ansible_os_family == "Debian"
 
     - name: "Include Beats"
-      include_role:
+      ansible.builtin.include_role:
         name: beats

molecule/beats_peculiar/prepare.yml

@@ -3,7 +3,7 @@
   hosts: all
   tasks:
     - name: Install packages for Debian
-      apt:
+      ansible.builtin.apt:
         name:
           - gpg
           - gpg-agent

molecule/beats_peculiar/verify.yml

@@ -6,22 +6,22 @@
     elasticstack_release: "{{ lookup('env', 'ELASTIC_RELEASE') | int}}"
   tasks:
     - name: fetch Filebeat version
-      command: "filebeat version | grep ^filebeat"
+      ansible.builtin.command: "filebeat version | grep ^filebeat"
       register: beats_filebeat_version
 
     - name: DEBUG show filebeat version output
-      debug:
+      ansible.builtin.debug:
         var: beats_filebeat_version.stdout
 
     - name: Fail if Filebeat has the wrong version
-      fail:
+      ansible.builtin.fail:
         msg: "Filebeat has the wrong version"
       when:
         - beats_filebeat_version.stdout.find('7.17.1') == -1
         - elasticstack_release == 7
 
     - name: Fail if Filebeat has the wrong version
-      fail:
+      ansible.builtin.fail:
         msg: "Filebeat has the wrong version"
       when:
         - beats_filebeat_version.stdout.find('8.4.1') == -1

molecule/elasticsearch_cluster-oss/converge.yml

@@ -13,8 +13,8 @@
     elasticsearch_heap: "1"
   tasks:
     - name: Include Elastics repos role
-      include_role:
+      ansible.builtin.include_role:
         name: repos
     - name: Include Elasticsearch
-      include_role:
+      ansible.builtin.include_role:
         name: elasticsearch

molecule/elasticsearch_cluster-oss/prepare.yml

@@ -3,7 +3,7 @@
   hosts: all
   tasks:
     - name: Install packages for Debian
-      apt:
+      ansible.builtin.apt:
         name:
           - gpg
           - gpg-agent