CCM-10077 Relax api contact details validation

[Ian-Hodges]

Summary

Currently the NHS Notify batch send API performs up-front validation of fields in the request payload. Any validation errors cause the entire message request (for the send single message API) or the entire batch (for the send batch API and MESH) to be rejected. The original intention was to fail the request quickly for "client issues" that are within the control of the integrator. However, an unintended consequence of this is that message requests that have a validation error pertaining to a single channel (e.g. a malformed postcode override) would be rejected but may have succeeded via a different channel in the routing plan had the request been accepted. Furthermore, for batch requests a single validation error causes the entire batch to be rejected. Finally, the existing behaviour where an invalid overridden contact detail causes the message request to be rejected differs from the behaviour when contact details are retrieved from PDS as in this case validation occurs during enrichment, after the request has already been accepted.

Test Evidence

Test evidence added to CCM-10077

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Checklist

• Brief description of work completed, and any technical decisions made as part of the PR
• PR link added as a comment to the relevant JIRA ticket
• PR link shared on Slack and/or Teams
• 2 reviews received
• Tester approval

[github-actions]

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-10077