Switch from pdf templates to authoring in tests

ClareJonesBJSS · ClareJonesBJSS · commit d3965089d477 · 2026-03-27T11:58:29.000Z
diff --git a/frontend/src/__tests__/app/message-plans/choose-british-sign-language-letter-template/__snapshots__/page.test.tsx.snap b/frontend/src/__tests__/app/message-plans/choose-british-sign-language-letter-template/__snapshots__/page.test.tsx.snap
@@ -165,7 +165,7 @@ exports[`ChooseBritishSignLanguageLetterTemplate page renders British Sign Langu
                             >
                               Name 
                             </span>
-                            British Sign Language letter template name
+                            authoring letter template name
                           </td>
                           <td
                             class="nhsuk-table__cell"
diff --git a/frontend/src/__tests__/app/message-plans/choose-british-sign-language-letter-template/preview-template/__snapshots__/page.test.tsx.snap b/frontend/src/__tests__/app/message-plans/choose-british-sign-language-letter-template/preview-template/__snapshots__/page.test.tsx.snap
@@ -34,14 +34,14 @@ exports[`PreviewBritishSignLanguageLetterTemplateFromMessagePlan page renders Br
             <h1
               data-testid="preview-message__heading"
             >
-              British Sign Language letter template name
+              authoring letter template name
             </h1>
           </div>
           <div
             class="nhsuk-width-container nhsuk-u-margin-bottom-6 nhsuk-body-m"
           >
             <dl
-              class="nhsuk-summary-list nhsuk-u-margin-bottom-4 preview"
+              class="nhsuk-summary-list nhsuk-u-margin-bottom-4 preview authoringLetterDetails"
             >
               <div
                 class="nhsuk-summary-list__row"
@@ -57,6 +57,9 @@ exports[`PreviewBritishSignLanguageLetterTemplateFromMessagePlan page renders Br
                 >
                   bsl-letter-template-id
                 </dd>
+                <dd
+                  class="nhsuk-summary-list__actions"
+                />
               </div>
               <div
                 class="nhsuk-summary-list__row"
@@ -71,43 +74,92 @@ exports[`PreviewBritishSignLanguageLetterTemplateFromMessagePlan page renders Br
                 >
                   British Sign Language letter
                 </dd>
+                <dd
+                  class="nhsuk-summary-list__actions"
+                />
+              </div>
+              <div
+                class="nhsuk-summary-list__row missing-value"
+                id="campaign-id"
+              >
+                <dt
+                  class="nhsuk-summary-list__key"
+                >
+                  Campaign
+                </dt>
+                <dd
+                  class="nhsuk-summary-list__value"
+                />
+                <dd
+                  aria-hidden="true"
+                  class="nhsuk-summary-list__actions"
+                />
               </div>
               <div
                 class="nhsuk-summary-list__row"
               >
                 <dt
                   class="nhsuk-summary-list__key"
                 >
-                  Template file
+                  Total pages
                 </dt>
                 <dd
                   class="nhsuk-summary-list__value"
                 >
-                  <div
-                    class="container"
+                  2
+                </dd>
+                <dd
+                  class="nhsuk-summary-list__actions"
+                />
+              </div>
+              <div
+                class="nhsuk-summary-list__row"
+              >
+                <dt
+                  class="nhsuk-summary-list__key"
+                >
+                  Sheets
+                </dt>
+                <dd
+                  class="nhsuk-summary-list__value"
+                >
+                  1
+                </dd>
+                <dd
+                  class="nhsuk-summary-list__actions nhsuk-u-padding-right-4"
+                >
+                  <a
+                    data-testid="sheets-action"
+                    href="https://notify.nhs.uk/pricing-and-commercial/letters"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
-                    <svg
-                      aria-hidden="true"
-                      class="icon"
-                      fill="none"
-                      height="26"
-                      viewBox="0 0 20 26"
-                      width="20"
-                      xmlns="http://www.w3.org/2000/svg"
+                    Learn more
+                    <span
+                      class="nhsuk-u-visually-hidden"
                     >
-                      <path
-                        d="M0 0V26H20V6.59375L19.7188 6.28125L13.7188 0.28125L13.4062 0H0ZM2 2H12V8H18V24H2V2ZM14 3.4375L16.5625 6H14V3.4375Z"
-                        fill="#4C6272"
-                      />
-                    </svg>
-                    <p
-                      class="text"
-                    >
-                      bsl-template.pdf
-                    </p>
-                  </div>
+                       about sheets
+                    </span>
+                  </a>
                 </dd>
               </div>
+              <div
+                class="nhsuk-summary-list__row missing-value"
+                id="printing-and-postage"
+              >
+                <dt
+                  class="nhsuk-summary-list__key"
+                >
+                  Printing and postage
+                </dt>
+                <dd
+                  class="nhsuk-summary-list__value"
+                />
+                <dd
+                  aria-hidden="true"
+                  class="nhsuk-summary-list__actions"
+                />
+              </div>
             </dl>
           </div>
           <a
diff --git a/frontend/src/__tests__/app/message-plans/preview-message-plan/page.test.tsx b/frontend/src/__tests__/app/message-plans/preview-message-plan/page.test.tsx
@@ -10,9 +10,11 @@ import {
   ORDINALS,
 } from 'nhs-notify-web-template-management-utils';
 import {
+  BSL_LETTER_TEMPLATE,
   EMAIL_TEMPLATE,
-  PDF_LETTER_TEMPLATE,
+  LARGE_PRINT_LETTER_TEMPLATE,
   NHS_APP_TEMPLATE,
+  PDF_LETTER_TEMPLATE,
   SMS_TEMPLATE,
 } from '@testhelpers/helpers';
 import { RoutingConfigFactory } from '@testhelpers/routing-config-factory';
@@ -90,12 +92,12 @@ const templates: MessagePlanTemplates = {
     templateStatus: 'SUBMITTED',
   },
   [largePrintTemplateId]: {
-    ...PDF_LETTER_TEMPLATE,
+    ...LARGE_PRINT_LETTER_TEMPLATE,
     id: largePrintTemplateId,
     templateStatus: 'SUBMITTED',
   },
   [bslTemplateId]: {
-    ...PDF_LETTER_TEMPLATE,
+    ...BSL_LETTER_TEMPLATE,
     id: bslTemplateId,
     templateStatus: 'SUBMITTED',
   },
diff --git a/frontend/src/__tests__/app/message-plans/review-and-move-to-production/page.test.tsx b/frontend/src/__tests__/app/message-plans/review-and-move-to-production/page.test.tsx
@@ -5,9 +5,11 @@ import '@testing-library/jest-dom';
 
 import { RoutingConfig } from 'nhs-notify-web-template-management-types';
 import {
+  BSL_LETTER_TEMPLATE,
   EMAIL_TEMPLATE,
-  PDF_LETTER_TEMPLATE,
+  LARGE_PRINT_LETTER_TEMPLATE,
   NHS_APP_TEMPLATE,
+  PDF_LETTER_TEMPLATE,
   SMS_TEMPLATE,
 } from '@testhelpers/helpers';
 import { RoutingConfigFactory } from '@testhelpers/routing-config-factory';
@@ -69,14 +71,12 @@ const templates: MessagePlanTemplates = {
   [kuTemplateId]: { ...PDF_LETTER_TEMPLATE, id: kuTemplateId },
   [sqTemplateId]: { ...PDF_LETTER_TEMPLATE, id: sqTemplateId },
   [largePrintTemplateId]: {
-    ...PDF_LETTER_TEMPLATE,
+    ...LARGE_PRINT_LETTER_TEMPLATE,
     id: largePrintTemplateId,
-    templateStatus: 'SUBMITTED',
   },
   [bslTemplateId]: {
-    ...PDF_LETTER_TEMPLATE,
+    ...BSL_LETTER_TEMPLATE,
     id: bslTemplateId,
-    templateStatus: 'SUBMITTED',
   },
 };
 
diff --git a/frontend/src/__tests__/helpers/helpers.ts b/frontend/src/__tests__/helpers/helpers.ts
@@ -101,28 +101,7 @@ export const LARGE_PRINT_LETTER_TEMPLATE: PdfLetterTemplate = {
   lockNumber: 1,
 } as const;
 
-export const BSL_LETTER_TEMPLATE: PdfLetterTemplate = {
-  id: 'bsl-letter-template-id',
-  templateType: 'LETTER',
-  templateStatus: 'NOT_YET_SUBMITTED',
-  letterType: 'q4',
-  language: 'en',
-  letterVersion: 'PDF',
-  files: {
-    pdfTemplate: {
-      fileName: 'bsl-template.pdf',
-      currentVersion: '9BDED347C6BF',
-      virusScanStatus: 'PASSED',
-    },
-  },
-  name: 'British Sign Language letter template name',
-  createdAt: '2025-01-13T10:19:25.579Z',
-  updatedAt: '2025-01-13T10:19:25.579Z',
-  lockNumber: 1,
-} as const;
-
-export const AUTHORING_LETTER_TEMPLATE: AuthoringLetterTemplate = {
-  id: 'authoring-letter-template-id',
+const BASE_AUTHORING_LETTER_TEMPLATE: Omit<AuthoringLetterTemplate, 'id'> = {
   clientId: 'client-1',
   templateType: 'LETTER',
   templateStatus: 'NOT_YET_SUBMITTED',
@@ -150,6 +129,17 @@ export const AUTHORING_LETTER_TEMPLATE: AuthoringLetterTemplate = {
   lockNumber: 1,
 } as const;
 
+export const AUTHORING_LETTER_TEMPLATE: AuthoringLetterTemplate = {
+  ...BASE_AUTHORING_LETTER_TEMPLATE,
+  id: 'authoring-letter-template-id',
+} as const;
+
+export const BSL_LETTER_TEMPLATE: AuthoringLetterTemplate = {
+  ...BASE_AUTHORING_LETTER_TEMPLATE,
+  id: 'bsl-letter-template-id',
+  letterType: 'q4',
+} as const;
+
 export const ROUTING_CONFIG: RoutingConfig = {
   id: 'fbb81055-79b9-4759-ac07-d191ae57be34',
   name: 'Autumn Campaign Plan',
diff --git a/frontend/src/__tests__/utils/routing-utils.test.ts b/frontend/src/__tests__/utils/routing-utils.test.ts
@@ -32,6 +32,7 @@ import {
   LARGE_PRINT_LETTER_TEMPLATE,
   PDF_LETTER_TEMPLATE,
   NHS_APP_TEMPLATE,
+  BSL_LETTER_TEMPLATE,
 } from '@testhelpers/helpers';
 import { randomUUID } from 'node:crypto';
 
@@ -1880,8 +1881,8 @@ describe('getAccessibleTemplatesForCascadeItem', () => {
       ],
     };
 
-    const template = { ...PDF_LETTER_TEMPLATE, id };
-    const bslTemplate = { ...PDF_LETTER_TEMPLATE, id: id2 };
+    const template = { ...LARGE_PRINT_LETTER_TEMPLATE, id };
+    const bslTemplate = { ...BSL_LETTER_TEMPLATE, id: id2 };
     const templates: MessagePlanTemplates = {
       [id]: template,
       [id2]: bslTemplate,
diff --git a/tests/test-team/template-mgmt-routing-component-tests/letter/preview-british-sign-language-letter-template.routing-component.spec.ts b/tests/test-team/template-mgmt-routing-component-tests/letter/preview-british-sign-language-letter-template.routing-component.spec.ts
@@ -38,24 +38,16 @@ function createTemplates(user: TestUser) {
       user,
       'Email template name'
     ),
-    STANDARD_LETTER: TemplateFactory.uploadLetterTemplate(
+    STANDARD_LETTER: TemplateFactory.createAuthoringLetterTemplate(
       randomUUID(),
       user,
       'Standard letter template name'
     ),
-    BSL_LETTER: TemplateFactory.uploadLetterTemplate(
+    BSL_LETTER: TemplateFactory.createAuthoringLetterTemplate(
       randomUUID(),
       user,
       'BSL letter template name',
       'SUBMITTED',
-      'PASSED',
-      { letterType: 'q4' }
-    ),
-    AUTHORING_BSL_LETTER: TemplateFactory.createAuthoringLetterTemplate(
-      randomUUID(),
-      user,
-      'Authoring BSL letter template name',
-      'SUBMITTED',
       { letterType: 'q4' }
     ),
   };
@@ -162,49 +154,6 @@ test.describe('Routing - Preview British Sign Language letter template page', ()
     await expect(previewBSLLetterTemplatePage.campaignId).toContainText(
       templates.BSL_LETTER.campaignId!
     );
-
-    await expect(
-      page.getByText(templates.BSL_LETTER.files!.pdfTemplate!.fileName)
-    ).toBeVisible();
-
-    await expect(
-      page.getByText(templates.BSL_LETTER.files!.testDataCsv!.fileName)
-    ).toBeVisible();
-  });
-
-  test('loads the AUTHORING BSL letter template', async ({ page, baseURL }) => {
-    const previewBSLLetterTemplatePage =
-      new RoutingPreviewBritishSignLanguageLetterTemplatePage(page);
-    await previewBSLLetterTemplatePage
-      .setPathParam('messagePlanId', messagePlans.LETTER_ROUTING_CONFIG.id)
-      .setPathParam('templateId', templates.AUTHORING_BSL_LETTER.id)
-      .setSearchParam('lockNumber', '0')
-      .loadPage();
-
-    await expect(page).toHaveURL(
-      `${baseURL}/templates/message-plans/choose-british-sign-language-letter-template/${messagePlans.LETTER_ROUTING_CONFIG.id}/preview-template/${templates.AUTHORING_BSL_LETTER.id}?lockNumber=0`
-    );
-
-    await expect(previewBSLLetterTemplatePage.templateCaption).toContainText(
-      'Template'
-    );
-
-    await expect(previewBSLLetterTemplatePage.pageHeading).toContainText(
-      templates.AUTHORING_BSL_LETTER.name
-    );
-
-    await expect(previewBSLLetterTemplatePage.templateId).toBeVisible();
-    await expect(previewBSLLetterTemplatePage.templateId).toContainText(
-      templates.AUTHORING_BSL_LETTER.id
-    );
-
-    await expect(previewBSLLetterTemplatePage.summaryList).toBeVisible();
-
-    expect(templates.AUTHORING_BSL_LETTER.campaignId).toBeTruthy();
-
-    await expect(previewBSLLetterTemplatePage.campaignId).toContainText(
-      templates.AUTHORING_BSL_LETTER.campaignId!
-    );
   });
 
   test.describe('redirects to invalid template page', () => {

Original file line number	Diff line number	Diff line change
@@ -165,7 +165,7 @@ exports[`ChooseBritishSignLanguageLetterTemplate page renders British Sign Langu
`165`	`165`	`>`
`166`	`166`	`Name`
`167`	`167`	`</span>`
`168`		`- British Sign Language letter template name`
	`168`	`+ authoring letter template name`
`169`	`169`	`</td>`
`170`	`170`	`<td`
`171`	`171`	`class="nhsuk-table__cell"`