Skip to content

Commit 3ccd877

Browse files
NPA-6263: Update GET RelatedPerson examples to ensure the patient res… (#317)
…ource is for the patient # Pull Request ## 🧾 Ticket Link <!-- Add the Jira ticket link here --> https://nhsd-jira.digital.nhs.uk/browse/NPA-6263 --- ## 📄 Description/Summary of Changes <!-- Describe the changes made in this PR. Include the purpose/scope/impact of the changes --> - Updated spec typo where it indicates that RelatedPerson:patient returns proxy details. Is the patient details. - Updated examples to ensure the patient resource is always for the patient. --- ## 🧪 Developer Testing Carried Out <!-- Describe what tests (automated/unit/manual etc.) have been done for the ticket. Include: --> <!-- - Any tests added/updated --> <!-- - Evidence that each acceptance criterion from the Jira ticket is met --> - <!-- Add bullet points for testing instructions --> - <!-- Add bullet points for testing instructions --> - <!-- Add bullet points for testing instructions --> --- ## 🧪 Reviewer Testing Required <!-- Describe how to test the changes that have been made in the ticket. Include: --> <!-- - Testing environment details (e.g. sandbox/local setup) --> <!-- - Steps to verify the changes --> - <!-- Add bullet points for testing instructions --> - <!-- Add bullet points for testing instructions --> - <!-- Add bullet points for testing instructions --> --- ## ✅ Developer Checklist <!-- Complete before submitting the PR --> - [ ] PR title follows the format: `NPA-XXXX: <short-description>` - [ ] Branch name follows the convention: `<type>/NPA-XXXX/<short-description>` - [ ] Commit messages follow the template: `NPA-XXXX: <short-description>` - [ ] All acceptance criteria from the Jira ticket are addressed - [ ] Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated - [ ] Assignees and appropriate labels (e.g. `terraform`, `documentation`) are added --- ## 👀 Reviewer Checklist <!-- To be completed by the reviewer --> - [ ] Changes meet the acceptance criteria of the Jira ticket - [ ] Code is able to be merged (no conflicts and adheres to coding standards) - [ ] Sufficient test evidence is provided (manual and/or automated) - [ ] Infrastructure/operational/build changes are validated (if applicable) --- ## 🚀 Post-merge <!-- Actions to complete after merging --> After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow. This will run the tests within the collection to check that the sandbox is working as expected once deployed.
1 parent 4b9cd36 commit 3ccd877

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

specification/examples/responses/GET_RelatedPerson/list_relationship_9000000042.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ ListRelationship9000000042:
1313
id: BE974742
1414
identifier:
1515
- system: https://fhir.nhs.uk/Id/nhs-number
16-
value: '9000000042'
16+
value: '9000000009'
1717
name:
1818
- family: MOGAJI
1919
given:
@@ -26,7 +26,7 @@ ListRelationship9000000042:
2626
patient:
2727
identifier:
2828
system: https://fhir.nhs.uk/Id/nhs-number
29-
value: '9000000009'
29+
value: '9000000042'
3030
relationship:
3131
- coding:
3232
- code: CHILD

specification/examples/responses/GET_RelatedPerson/list_relationship_9000000042_include.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ListRelationship9000000042Include:
1515
id: BE974742
1616
identifier:
1717
- system: https://fhir.nhs.uk/Id/nhs-number
18-
value: '9000000042'
18+
value: '9000000009'
1919
name:
2020
- family: MOGAJI
2121
given:
@@ -28,7 +28,7 @@ ListRelationship9000000042Include:
2828
patient:
2929
identifier:
3030
system: https://fhir.nhs.uk/Id/nhs-number
31-
value: '9000000009'
31+
value: '9000000042'
3232
relationship:
3333
- coding:
3434
- code: CHILD
@@ -37,13 +37,13 @@ ListRelationship9000000042Include:
3737
resourceType: RelatedPerson
3838
search:
3939
mode: match
40-
- fullUrl: https://sandbox.api.service.nhs.uk/validated-relationships/FHIR/R4/Patient/9000000009
40+
- fullUrl: https://sandbox.api.service.nhs.uk/validated-relationships/FHIR/R4/Patient/9000000042
4141
resource:
4242
birthDate: '2017-09-23'
43-
id: '9000000009'
43+
id: '9000000042'
4444
identifier:
4545
- system: https://fhir.nhs.uk/Id/nhs-number
46-
value: '9000000009'
46+
value: '9000000042'
4747
name:
4848
- family: MOGAJI
4949
given:

specification/examples/responses/GET_RelatedPerson/verify_relationship_9000000009.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ VerifyRelationship9000000009:
1616
birthDate: '2017-09-23'
1717
identifier:
1818
- system: https://fhir.nhs.uk/Id/nhs-number
19-
value: '9000000009'
19+
value: '9000000017'
2020
patient:
2121
identifier:
2222
system: https://fhir.nhs.uk/Id/nhs-number
23-
value: '9000000017'
23+
value: '9000000009'
2424
name:
2525
- family: MOGAJI
2626
given:

specification/examples/responses/GET_RelatedPerson/verify_relationship_9000000009_include.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ VerifyRelationship9000000009Include:
4040
birthDate: '2017-09-23'
4141
identifier:
4242
- system: https://fhir.nhs.uk/Id/nhs-number
43-
value: '9000000009'
43+
value: '9000000017'
4444
patient:
4545
identifier:
4646
system: https://fhir.nhs.uk/Id/nhs-number
47-
value: '9000000017'
47+
value: '9000000009'
4848
name:
4949
- family: MOGAJI
5050
given:

specification/validated-relationships-service-api.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ paths:
432432
| List Relationship | `identifier=9000000017` | HTTP Status 200 List of relationships for the proxy |
433433
| List Relationship and include patient's details | `identifier=9000000017&_include=RelatedPerson:patient` | HTTP Status 200 List of relationships for the proxy and includes patient data |
434434
| List Patient Relationship | `patient:identifier=9000000042` | HTTP Status 200 List of relationships for the patient |
435-
| List Patient Relationship and include patient's details | `patient:identifier=9000000042&_include=RelatedPerson:patient` | HTTP Status 200 List of relationships for the patient and includes proxy data |
435+
| List Patient Relationship and include patient's details | `patient:identifier=9000000042&_include=RelatedPerson:patient` | HTTP Status 200 List of relationships for the patient and includes patient data |
436436
| List Relationship and no relationships returned | `identifier=9000000033` | HTTP Status 200 Empty bundle |
437437
| Verify Relationship between proxy and patient | `identifier=9000000017&patient:identifier=9000000009` | HTTP Status 200 Verified relationship between patient and proxy |
438438
| Verify Relationship between proxy and patient and include patient's details | `identifier=9000000017&patient:identifier=9000000009&_include=RelatedPerson:patient` | HTTP Status 200 Verified relationship between patient and proxy and includes patient's details |

0 commit comments

Comments
 (0)