Skip to content

Commit aff1bb1

Browse files
authored
NPA-6425: auditing error responses (#319)
# Pull Request ## 🧾 Ticket Link <!-- Add the Jira ticket link here --> https://nhsd-jira.digital.nhs.uk/browse/NPA-6425 --- ## 📄 Description/Summary of Changes <!-- Describe the changes made in this PR. Include the purpose/scope/impact of the changes --> - This PR matches up the error responses we return from VRS with the Spec. - This involved some error codes changing, and some errors being added/removed - A PR has been raised in the PVRS repo to reflect some of these changes too. --- ## 🧪 Developer Testing Carried Out <!-- Describe what tests (automated/unit/manual etc.) have been done for the ticket. Include: --> <!-- - Any tests added/updated --> <!-- - Evidence that each acceptance criterion from the Jira ticket is met --> <!-- - Evidence of tests running eg. link to github workflow with tests passing or screenshot of tests running locally --> - Tested this spec branch against my PVRS changes to check all tests passing NHSDigital/proxy-validated-relationships-service#1392 --- ## 📋 PR Principles <!-- Principles we as a team follow when conducting a PR --> - Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review. - Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket. - Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made. - Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices. - Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed. - Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment. ## 🏷️ Naming Conventions Reminder Please ensure the following naming conventions are followed: - PR title follows the format: `NPA-XXXX: <short-description>` - Branch name follows the convention: `<type>/NPA-XXXX/<short-description>` - Commit messages follow the template: `NPA-XXXX: <short-description>`
1 parent 9448325 commit aff1bb1

2 files changed

Lines changed: 28 additions & 39 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ __pycache__/
1616
.venv/
1717

1818
smoketest-report.xml
19+
test-report.xml
1920
env
2021
.dir-locals.el
2122
*.pyc

0 commit comments

Comments
 (0)