add security context support to binder pod#917
add security context support to binder pod#917AdheipSingh wants to merge 1 commit intokai-scheduler:mainfrom
Conversation
|
@enoodle - would like some feedback on the approach. |
rich7420
left a comment
There was a problem hiding this comment.
thanks for the patch!
A little suggestion: You've better develop on your other branch not main branch.
|
|
||
| if config.ResourceReservation.PodSecurityContext != nil { | ||
| secCtxJSON, err := json.Marshal(config.ResourceReservation.PodSecurityContext) | ||
| if err == nil { |
There was a problem hiding this comment.
Here should return some error message.
|
The implementation makes sense. I wonder if we can find a more structured way to pass the configuration to the reservation service. What do you think? Thanks! |
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
|
@AdheipSingh Do you plan to continue this PR? |
|
Hi @davidLif Yes, i ll be working this, let me send a polished PR this week. I have it running on my custom fork. |
Description
Related Issues
Fixes #570
Checklist
Breaking Changes
Additional Notes