Skip to content

feat(chart): add prometheus configuration options to values.yaml#976

Merged
davidLif merged 2 commits intokai-scheduler:mainfrom
Dave-London:feat/prometheus-values-config
Apr 7, 2026
Merged

feat(chart): add prometheus configuration options to values.yaml#976
davidLif merged 2 commits intokai-scheduler:mainfrom
Dave-London:feat/prometheus-values-config

Conversation

@Dave-London
Copy link
Copy Markdown
Contributor

Summary

  • Adds prometheus.enabled and prometheus.externalPrometheusUrl to values.yaml
  • Wires these values into the kai-config.yaml Helm template under spec.prometheus
  • Users can now link an external Prometheus instance at helm install / helm upgrade time instead of needing to kubectl patch kai-config afterwards

Closes #907

Changes

File Change
values.yaml Added prometheus.enabled (default: false) and prometheus.externalPrometheusUrl (commented out)
templates/kai-config.yaml Added conditional spec.prometheus block rendered when prometheus.enabled is true
tests/prometheus_test.yaml 7 new Helm unit tests covering defaults, enabled-only, external URL, and disabled-with-URL-set
CHANGELOG.md Added entry under [Unreleased] > Added

Example Usage

# values.yaml override
prometheus:
  enabled: true
  externalPrometheusUrl: "http://prometheus-kube-prometheus-prometheus.monitoring.svc.cluster.local:9090"

Or via CLI:

helm install kai-scheduler ./deployments/kai-scheduler \
  --set prometheus.enabled=true \
  --set prometheus.externalPrometheusUrl=http://prometheus:9090

Test plan

  • All existing Helm unit tests pass (53 tests)
  • 7 new prometheus-specific tests pass
  • helm template renders correctly with prometheus enabled + external URL
  • helm template omits prometheus section with defaults (disabled)

Add `prometheus.enabled` and `prometheus.externalPrometheusUrl` to
the Helm chart values, allowing users to link an external Prometheus
instance at install time without needing to kubectl patch kai-config
afterwards.

Closes kai-scheduler#907

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Dave-London <hello@os4us.org>
enoodle
enoodle previously approved these changes Feb 17, 2026
gshaibi
gshaibi previously approved these changes Feb 17, 2026
@enoodle enoodle added this pull request to the merge queue Feb 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Feb 17, 2026
@davidLif davidLif dismissed stale reviews from gshaibi and enoodle via 215dc33 April 6, 2026 13:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3e846ba8-43b8-406b-b1da-2d4fb9559eed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davidLif davidLif enabled auto-merge April 6, 2026 13:27
@davidLif davidLif added this pull request to the merge queue Apr 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 7, 2026
@davidLif davidLif added this pull request to the merge queue Apr 7, 2026
Merged via the queue into kai-scheduler:main with commit 89b4f7f Apr 7, 2026
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing options to configure prometheus instance from values.yaml

4 participants