feat(chart): add prometheus configuration options to values.yaml#976
Merged
davidLif merged 2 commits intokai-scheduler:mainfrom Apr 7, 2026
Merged
Conversation
Add `prometheus.enabled` and `prometheus.externalPrometheusUrl` to the Helm chart values, allowing users to link an external Prometheus instance at install time without needing to kubectl patch kai-config afterwards. Closes kai-scheduler#907 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dave-London <hello@os4us.org>
3 tasks
enoodle
previously approved these changes
Feb 17, 2026
gshaibi
previously approved these changes
Feb 17, 2026
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
enoodle
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prometheus.enabledandprometheus.externalPrometheusUrltovalues.yamlkai-config.yamlHelm template underspec.prometheushelm install/helm upgradetime instead of needing tokubectl patch kai-configafterwardsCloses #907
Changes
values.yamlprometheus.enabled(default:false) andprometheus.externalPrometheusUrl(commented out)templates/kai-config.yamlspec.prometheusblock rendered whenprometheus.enabledistruetests/prometheus_test.yamlCHANGELOG.md[Unreleased] > AddedExample Usage
Or via CLI:
Test plan
helm templaterenders correctly with prometheus enabled + external URLhelm templateomits prometheus section with defaults (disabled)