Skip to content

Fix flags for aarch64 containers using FFTW#1127

Merged
cliffburdick merged 1 commit intomainfrom
arm_container
Feb 23, 2026
Merged

Fix flags for aarch64 containers using FFTW#1127
cliffburdick merged 1 commit intomainfrom
arm_container

Conversation

@cliffburdick
Copy link
Copy Markdown
Collaborator

No description provided.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 23, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 23, 2026

Greptile Summary

Conditionally configures FFTW builds based on CPU architecture, omitting x86-specific SIMD flags (--enable-sse2, --enable-avx2, --enable-avx512) on aarch64 platforms. Also adds python3-numpy to system packages.

Changes:

  • Added python3-numpy to OS packages list
  • Introduced architecture-aware FFTW configuration that checks cpu_target variable
  • x86_64 builds use SSE2/AVX2/AVX512 optimizations (existing behavior)
  • aarch64 builds omit x86-specific SIMD flags (new behavior)
  • Both architectures retain OpenMP, shared library, and float/double configurations

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes correctly fix a known issue where x86-specific SIMD instruction flags would fail on ARM64/aarch64 platforms. The conditional logic is straightforward, mirrors existing patterns in the codebase (lines 14-19), and the addition of python3-numpy is a benign dependency addition.
  • No files require special attention

Important Files Changed

Filename Overview
.devcontainer/recipe.py Added architecture-specific FFTW configure flags and python3-numpy package. Conditionally omits SSE2/AVX2/AVX512 flags on aarch64.

Last reviewed commit: a32565b

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@cliffburdick cliffburdick merged commit 6782da4 into main Feb 23, 2026
@cliffburdick cliffburdick deleted the arm_container branch February 23, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant