From 38110937120f7d7ca8f100d35dc4d2c94c07746d Mon Sep 17 00:00:00 2001 From: David Gardner <96306125+dagardner-nv@users.noreply.github.com> Date: Thu, 5 Mar 2026 00:02:18 +0000 Subject: [PATCH] Cleanup vale vocabulary (#1745) * Anthropic and Brev should only ever be capitalized * Disallow 'kv' abbreviations should always be capitalized * Zsh should be cased the way the project cases the name. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Chores** * Updated style vocabulary: standardized names/capitalization (Anthropic, Brev, Zsh, Minimax). * Removed obsolete token ("kv") and tightened finetune variation handling. * Added explicit allowance for "AIQ" in one list and added an additional case-insensitive "AIQ" matching rule in the counterpart list to refine validation. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Bryan Bednarski (https://github.com/bbednarski9) URL: https://github.com/NVIDIA/NeMo-Agent-Toolkit/pull/1745 --- ci/vale/styles/config/vocabularies/nat/accept.txt | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ci/vale/styles/config/vocabularies/nat/accept.txt b/ci/vale/styles/config/vocabularies/nat/accept.txt index 8cb4d4d419..cccb377a7b 100644 --- a/ci/vale/styles/config/vocabularies/nat/accept.txt +++ b/ci/vale/styles/config/vocabularies/nat/accept.txt @@ -4,6 +4,7 @@ [Aa]gentic [Aa]gno +# Allow AIQ for AIQ Blueprint AIQ [Aa]llowlist [Aa]nonymize(d?) @@ -12,7 +13,7 @@ Arize ART arXiv [Aa]sync -[Aa]nthropic('s)? +Anthropic Authlib [Aa]utoencoder [Bb]ackdoor(s?) @@ -20,7 +21,7 @@ Authlib [Bb]ackpressure [Bb]atcher [Bb]oolean -[Bb]rev +Brev [Cc]allable(s?) # Documentation for ccache only capitalizes the name at the start of a sentence https://ccache.dev/ [Cc]cache @@ -69,7 +70,7 @@ etcd Faiss [Ff]inetunable [Ff]inetune(d?) -[Ff]inetune(r|rs|ing) +[Ff]inetune(r|rs) [Ff]inetuning Gantt [Gg]eneratable @@ -93,7 +94,6 @@ Jira jsonlines [Kk]aggle [Kk]eycloak -kv KV LangChain Langfuse @@ -112,6 +112,7 @@ Loghub Mem0 [Mm]iddleware Milvus +# Minimax the algorithm, not the MiniMax model Minimax [Mm]itigation(s?) [Mm]ixin(s?) @@ -208,4 +209,4 @@ vLLM [Ww]eb[Ss]ocket XGBoost Zep -zsh \ No newline at end of file +Zsh