Add Julia(Field|Ring|ExactRing)Element type unions
#2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
release notes: not needed
lgoettgens
reviewed
Dec 3, 2025
src/Fraction.jl
Outdated
|
|
||
| @doc raw""" | ||
| ==(x::FracElem, y::Union{Integer, Rational, AbstractFloat}) | ||
| ==(x::FracElem, y::JuliaRingElement) |
Member
There was a problem hiding this comment.
If this is used in a docstring, the union definition should also have a docstring
Member
Author
There was a problem hiding this comment.
Good point, thanks.
Looking at this, though, I'd prefer to just remove these docstrings, and make the other remaining ones clearer & more general
fingolfin
force-pushed
the
mh/julia-type-union
branch
from
3f4dc90 to
79cdc9d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2231 +/- ##
==========================================
- Coverage 88.02% 88.00% -0.03%
==========================================
Files 127 127
Lines 31815 31795 -20
==========================================
- Hits 28004 27980 -24
- Misses 3811 3815 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by issue #2100. Once this is in an AA release, we should also update Nemo to make use of this.