Split out a new Base from HashFormat
#14721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have the machinery to make a more informative error, telling the user what format was actually encountered, and not just that it is not the format that was requested.
This allows for better separation of concerns, and will allow better modeling of some things.
github-actions
bot
added
documentation
new-cli
xokdvium
reviewed
Dec 6, 2025
Comment on lines
103
to
112
| /** | ||
| * Get the encoding function for the given base encoding. | ||
| */ | ||
| decltype(base16::encode) * encodeForBase(Base base); | ||
|
|
||
| /** | ||
| * Get the decoding function for the given base encoding. | ||
| */ | ||
| decltype(base16::decode) * decodeForBase(Base base); | ||
|
|
Contributor
There was a problem hiding this comment.
This really should just be a BaseDecoder singleton const class with just virtual methods. No reason to do this function pointer hackery
Member
Author
There was a problem hiding this comment.
That will make this PR bigger with something that's sort of orthogonal, but tbc I am happy to do it. Would you like it in a first commit, or a second commit (or a second PR)?
Contributor
There was a problem hiding this comment.
In this PR is fine. As a follow-up commit would work, since we already have function pointer hackers now.
Member
Author
There was a problem hiding this comment.
OK will do. Also remember this depends on #14720 so we better do that one first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows for better separation of concerns, and will allow better modeling of some things.
Context
Depends on #14720
I am not sure whether the
*Displayfunctions, to preserve existing behavior, are worth it!Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.