-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Labels
P1Priority 1: Critical, fix as soon as possiblePriority 1: Critical, fix as soon as possiblebugSomething isn't workingSomething isn't workingtestingTesting and quality assuranceTesting and quality assurance
Description
Context
PR #252 (Release v0.8.0: develop -> main) was reviewed with 5 specialized agents. The review found legitimate issues that should be fixed before merging to main.
Important Issues (fix before merge)
Error Handling
- 1. Missing
CorruptMirrorError/ValueErrorhandling in 4 mirror endpoints (mirrors.py:164,205,225,277) - 2. Cost check fails open for unknown models (
community.py:621-628) - 3. Missing
OSErrorhandling increate_mirror_endpoint(mirrors.py:129-137) - 4. One stuck mirror blocks cleanup of all others (
mirror.py:409-417)
Code Quality
- 5.
asyncio.get_event_loop()deprecated; useget_running_loop()(mirrors.py:249) - 6. Missing
field_validatoronRefreshMirrorRequest.community_ids(mirrors.py:89-94) - 7. Broad
except Exceptionin_cleanup_mirrors(scheduler.py:302-308)
Test Gaps
- 8. No HTTP-level tests for mirror routing middleware
- 9. No HTTP-level tests for mirrors API router
- 10. No test for
active_mirror_contextcontext manager - 11. No test for
MirrorInfo.__post_init__validation - 12. No test for
run_sync_nowwith invalid sync_type - 13. No test for TTL clamping in
create_mirror
Comment Fixes
- 14. Fix
enable_cachingdocstring ("enabled" -> "requested") - 15. Fix
asyncio.to_threadcomment (code usesrun_in_executor) - 16. Fix
get_modeldocstring example (claude-3-5-sonnet->claude-3.5-sonnet)
Type Design Improvements
- 17. Make
MirrorInfoa frozen dataclass - 18. Move
is_safe_identifierto shared utility - 19. Add non-negativity check to
ModelRate.__new__ - 20. Expand
SecureFormatterkey patterns for other providers
Origin
PR #252 review findings from code-reviewer, silent-failure-hunter, test-analyzer, comment-analyzer, and type-design-analyzer agents.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1Priority 1: Critical, fix as soon as possiblePriority 1: Critical, fix as soon as possiblebugSomething isn't workingSomething isn't workingtestingTesting and quality assuranceTesting and quality assurance