Skip to content

Commit 2697d22

Browse files
fix: remove operation for description
1 parent f16d73a commit 2697d22

5 files changed

Lines changed: 28 additions & 12 deletions

File tree

app/Audit/ConcreteFormatters/SummitRefundPolicyTypeAuditLogFormatter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public function format($subject, array $change_set): ?string
4343
$name,
4444
$id,
4545
$summit_name,
46-
($refund_rate !== null ? sprintf("%.0f", $refund_rate * 100) : 'N/A'),
46+
($refund_rate !== null ? sprintf("%.0f", $refund_rate) : 'N/A'),
4747
($days_before !== null ? $days_before : 'N/A'),
4848
$this->getUserInfo()
4949
);
@@ -65,7 +65,7 @@ public function format($subject, array $change_set): ?string
6565
$name,
6666
$id,
6767
$summit_name,
68-
($refund_rate !== null ? sprintf("%.0f", $refund_rate * 100) : 'N/A'),
68+
($refund_rate !== null ? sprintf("%.0f", $refund_rate) : 'N/A'),
6969
($days_before !== null ? $days_before : 'N/A'),
7070
$this->getUserInfo()
7171
);

app/Audit/ConcreteFormatters/SummitTaxTypeAuditLogFormatter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function format($subject, array $change_set): ?string
4444
$id,
4545
$summit_name,
4646
$tax_id,
47-
($rate !== null ? sprintf("%.2f%%", $rate * 100) : 'N/A'),
47+
($rate !== null ? sprintf("%.2f%%", $rate) : 'N/A'),
4848
$this->getUserInfo()
4949
);
5050

@@ -66,7 +66,7 @@ public function format($subject, array $change_set): ?string
6666
$id,
6767
$summit_name,
6868
$tax_id,
69-
($rate !== null ? sprintf("%.2f%%", $rate * 100) : 'N/A'),
69+
($rate !== null ? sprintf("%.2f%%", $rate) : 'N/A'),
7070
$this->getUserInfo()
7171
);
7272
}

config/audit_log.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,5 +228,21 @@
228228
'enabled' => true,
229229
'strategy' => \App\Audit\ConcreteFormatters\PresentationAttendeeVoteAuditLogFormatter::class,
230230
],
231+
\models\summit\SummitTaxType::class => [
232+
'enabled' => true,
233+
'strategy' => \App\Audit\ConcreteFormatters\SummitTaxTypeAuditLogFormatter::class,
234+
],
235+
\models\summit\SummitRefundPolicyType::class => [
236+
'enabled' => true,
237+
'strategy' => \App\Audit\ConcreteFormatters\SummitRefundPolicyTypeAuditLogFormatter::class,
238+
],
239+
\models\summit\SummitTicketType::class => [
240+
'enabled' => true,
241+
'strategy' => \App\Audit\ConcreteFormatters\SummitTicketTypeAuditLogFormatter::class,
242+
],
243+
\models\summit\PrePaidSummitRegistrationDiscountCode::class => [
244+
'enabled' => true,
245+
'strategy' => \App\Audit\ConcreteFormatters\PrePaidSummitRegistrationDiscountCodeAuditLogFormatter::class,
246+
],
231247
]
232248
];

tests/OpenTelemetry/Formatters/SummitRefundPolicyTypeAuditLogFormatterTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ protected function tearDown(): void
6060

6161
public function testFormatCreationEvent(): void
6262
{
63-
$policy = $this->createMockPolicy('Full Refund', 30, 1.0);
63+
$policy = $this->createMockPolicy('Full Refund', 30, 100.0);
6464

6565
$this->formatter_creation->setContext($this->audit_context);
6666
$result = $this->formatter_creation->format($policy, []);
@@ -74,12 +74,12 @@ public function testFormatCreationEvent(): void
7474

7575
public function testFormatUpdateEvent(): void
7676
{
77-
$policy = $this->createMockPolicy('Partial Refund', 14, 0.5);
77+
$policy = $this->createMockPolicy('Partial Refund', 14, 50.0);
7878

7979
$this->formatter_update->setContext($this->audit_context);
8080
$result = $this->formatter_update->format($policy, [
8181
'until_x_days_before_event_starts' => [30, 14],
82-
'refund_rate' => [1.0, 0.5]
82+
'refund_rate' => [100.0, 50.0]
8383
]);
8484

8585
$this->assertNotNull($result);

tests/OpenTelemetry/Formatters/SummitTaxTypeAuditLogFormatterTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ protected function tearDown(): void
6161

6262
public function testFormatCreationEvent(): void
6363
{
64-
$tax = $this->createMockTax('VAT', 'VAT-001', 0.21, 5);
64+
$tax = $this->createMockTax('VAT', 'VAT-001', 21.0, 5);
6565

6666
$this->formatter_creation->setContext($this->audit_context);
6767
$result = $this->formatter_creation->format($tax, []);
@@ -74,11 +74,11 @@ public function testFormatCreationEvent(): void
7474

7575
public function testFormatUpdateEvent(): void
7676
{
77-
$tax = $this->createMockTax('Sales Tax', 'ST-002', 0.08, 3);
77+
$tax = $this->createMockTax('Sales Tax', 'ST-002', 8.0, 3);
7878

7979
$this->formatter_update->setContext($this->audit_context);
8080
$result = $this->formatter_update->format($tax, [
81-
'rate' => [0.07, 0.08],
81+
'rate' => [7.0, 8.0],
8282
'ticket_types' => [[], []]
8383
]);
8484

@@ -89,7 +89,7 @@ public function testFormatUpdateEvent(): void
8989

9090
public function testFormatDeletionEvent(): void
9191
{
92-
$tax = $this->createMockTax('GST', 'GST-CA', 0.05, 2);
92+
$tax = $this->createMockTax('GST', 'GST-CA', 5.0, 2);
9393

9494
$this->formatter_deletion->setContext($this->audit_context);
9595
$result = $this->formatter_deletion->format($tax, []);
@@ -102,7 +102,7 @@ public function testFormatDeletionEvent(): void
102102

103103
public function testFormatWithoutTicketTypes(): void
104104
{
105-
$tax = $this->createMockTax('Empty Tax', 'EMPTY', 0.1, 0);
105+
$tax = $this->createMockTax('Empty Tax', 'EMPTY', 10.0, 0);
106106

107107
$this->formatter_creation->setContext($this->audit_context);
108108
$result = $this->formatter_creation->format($tax, []);

0 commit comments

Comments
 (0)