[Bug]: Sub-tropical landscape has incorrect shops and office buildings

[davewthompson]

Version of OpenTTD

12.0

Expected result

The sub-triopical cities build sub-tropical shops and offices.

Actual result

The sub-tropical cities build temperate shops and offices.

Steps to reproduce

Using the current 12.0 build, select a sub-tropical map and let a city grow to a point where shops and offices are built. You will see the wrong building styles.

See attachment.

[James103]

Did you try updating to 12.1 and reproducing?

[davewthompson]

I still see it, but I'll run the game for a bit and see if any of the new buildings have the issue. Thank you for replying.

[2TallTyler]

What newgrfs are you using? Can you attach a savegame?

[glx22]

left opengfx, right original dos

[LordAro]

I concur - an issue with OGFX reusing buildings (if indeed it's unintentional at all), I shall migrate the issue

[glx22]

The building is definitely a tropic/arctic only one (type 46h in https://newgrf-specs.tt-wiki.net/wiki/DefaultHouseProps).
It's defined on https://github.com/OpenTTD/OpenGFX/blob/master/sprites/base/base-4404-houses-town-snow.pnml#L94-L96
and uses https://github.com/OpenTTD/OpenGFX/blob/master/sprites/png/houses/base-4477-4479.4577-office.png (only used for this specific building, and only for sprites mentioned in the filename).

So for me the issue is the building style not fully matching the climate.

[davewthompson]

Updating to 12.1 hasn't helped.

Save game is attached to this Jira.

El Gringo Loco Transport, 15th Oct 1965.sav.zip

[zephyris]

I've drawn new buildings for OpenGFX2 so it doesn't have this issue. Those sprites could be ported back to OpenGFX, if someone wants to.