Refacotr in JasperPHP::compile()

Author: rafaelqueiroz

src/Exception/InvalidInputFile.php

@@ -0,0 +1,21 @@
+<?php
+namespace JasperPHP\Exception;
+/**
+ * Class InvalidInputFile
+ * @package JasperPHP\Exception
+ */
+class InvalidInputFile extends \Exception
+{
+
+    /**
+     * InvalidInputFile constructor.
+     * @param string $message
+     * @param int $code
+     * @param Exception|null $previous
+     */
+    public function __construct($message = "", $code = 0, Exception $previous = null)
+    {
+        $message = 'No input file';
+        parent::__construct($message, $code, $previous);
+    }
+}

src/JasperPHP.php

@@ -47,24 +47,26 @@ public static function __callStatic($method, $parameters)
         return call_user_func_array(array(new $model, $method), $parameters);
     }
 
+    /**
+     * @param $input_file
+     * @param bool $output_file
+     * @return $this
+     * @throws Exception\InvalidInputFile
+     */
     public function compile($input_file, $output_file = false)
     {
-        if (is_null($input_file) || empty($input_file)) {
-            throw new \Exception('No input file', 1);
+        if (!$input_file) {
+            throw new \JasperPHP\Exception\InvalidInputFile();
         }
 
-        $command = ($this->windows) ? $this->executable : './' . $this->executable;
-
-        $command .= ' compile ';
-
-        $command .= "\"$input_file\"";
+        $this->the_command = $this->windows ? $this->executable : './' . $this->executable;
+        $this->the_command .= ' compile ';
+        $this->the_command .= "\"$input_file\"";
 
         if ($output_file !== false) {
-            $command .= ' -o ' . "\"$output_file\"";
+            $this->the_command .= ' -o ' . "\"$output_file\"";
         }
 
-        $this->the_command = $command;
-
         return $this;
     }
 

tests/JasperPHP/JasperPHPTest.php

@@ -10,13 +10,35 @@ class JasperPHPTest extends \PHPUnit_Framework_TestCase
 {
 
     /**
-     * @return JasperPHP
+     *
      */
     public function testConstructor()
     {
         $this->assertInstanceOf(JasperPHP::class, new JasperPHP());
     }
 
+    /**
+     *
+     */
+    public function testCompileWithWrongInput()
+    {
+        $this->setExpectedException(\JasperPHP\Exception\InvalidInputFile::class);
+
+        $jasper = new JasperPHP();
+        $jasper->compile(null);
+    }
+
+    /**
+     *
+     */
+    public function testCompile()
+    {
+        $jasper = new JasperPHP();
+        $result = $jasper->compile('hello_world.jrxml');
+
+        $this->assertInstanceOf(JasperPHP::class, $result);
+    }
+
     /**
      *
      */
@@ -31,7 +53,7 @@ public function testExecuteWithoutCompile()
     /**
      *
      */
-    public function testExecuteWithCompileAndWrongInput()
+    public function testExecuteWithCompile()
     {
         $this->setExpectedException(\JasperPHP\Exception\ErrorCommandExecutable::class);