From 9327231267ccad21b6d853835dbc3f047b005ab0 Mon Sep 17 00:00:00 2001 From: Joe Schoonover Date: Tue, 3 Feb 2026 15:53:46 -0500 Subject: [PATCH 1/2] Fix bug in download_all --- parcels_benchmarks/benchmark_setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parcels_benchmarks/benchmark_setup.py b/parcels_benchmarks/benchmark_setup.py index c937e6d..6df1e39 100644 --- a/parcels_benchmarks/benchmark_setup.py +++ b/parcels_benchmarks/benchmark_setup.py @@ -137,7 +137,7 @@ def download_all( dataset_folders: dict[str, Path] = {} for dataset_name in datasets.keys(): folder = download_example_dataset(dataset_name, manifest_path=manifest_path, data_home=data_home) - dataset_folders[dataset] = folder + dataset_folders[dataset_name] = folder return dataset_folders @app.command("add-dataset") From 5e2d60d6691aa21ed4406c761f359b1725a39d6c Mon Sep 17 00:00:00 2001 From: Joe Schoonover Date: Tue, 3 Feb 2026 15:54:24 -0500 Subject: [PATCH 2/2] Change to convert.* methodology for fesom2 benchmark --- benchmarks/fesom2.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/benchmarks/fesom2.py b/benchmarks/fesom2.py index 91b3d34..91efdd9 100644 --- a/benchmarks/fesom2.py +++ b/benchmarks/fesom2.py @@ -1,6 +1,7 @@ import numpy as np import uxarray as ux from parcels import ( + convert, Field, FieldSet, Particle, @@ -44,7 +45,8 @@ def time_load_data(self,npart,integrator): def pset_execute(self,npart,integrator): ds = _load_ds(self.datapath) - fieldset = FieldSet.from_fesom2(ds) + ds = convert.fesom_to_ugrid(ds) + fieldset = FieldSet.from_ugrid_conventions(ds) lon = np.linspace(2.0,15.0,npart) lat = np.linspace(32.0,19.0,npart)