update test to updated problem class organisation

Author: j-atkins

tests/make_realistic/problems/test_scenarios.py

@@ -1,4 +1,3 @@
-from dataclasses import is_dataclass
 from datetime import timedelta
 
 from virtualship.instruments.types import InstrumentType
@@ -12,28 +11,24 @@
 
 def _assert_general_problem_class(cls):
     assert isinstance(cls, GeneralProblem)
-    instance = cls()
-    assert is_dataclass(instance)
 
     # required attributes and types
-    assert isinstance(instance.message, str)
-    assert instance.message.strip(), "message should not be empty"
+    assert isinstance(cls.message, str)
+    assert cls.message.strip(), "message should not be empty"
 
-    assert isinstance(instance.delay_duration, timedelta)
-    assert isinstance(instance.pre_departure, bool)
+    assert isinstance(cls.delay_duration, timedelta)
+    assert isinstance(cls.pre_departure, bool)
 
 
 def _assert_instrument_problem_class(cls):
     assert isinstance(cls, InstrumentProblem)
-    instance = cls()
-    assert is_dataclass(instance)
 
     # required attributes and types
-    assert isinstance(instance.message, str)
-    assert instance.message.strip(), "message should not be empty"
+    assert isinstance(cls.message, str)
+    assert cls.message.strip(), "message should not be empty"
 
-    assert isinstance(instance.delay_duration, timedelta)
-    assert isinstance(instance.instrument_type, InstrumentType)
+    assert isinstance(cls.delay_duration, timedelta)
+    assert isinstance(cls.instrument_type, InstrumentType)
 
 
 def test_general_problems():