From dcf5a0aa09f58ca99c096f8fbc9d01c61a5f121e Mon Sep 17 00:00:00 2001
From: Daniel Marbach <danielmarbach@users.noreply.github.com>
Date: Fri, 27 Feb 2026 15:38:10 +0100
Subject: [PATCH 1/2] Improve exception logging in unattended installers

---
 .../Unattended/UnattendAuditInstaller.cs               |  4 ++--
 .../Unattended/UnattendMonitoringInstaller.cs          |  6 +++---
 .../Unattended/UnattendServiceControlInstaller.cs      | 10 +++++-----
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/ServiceControlInstaller.Engine/Unattended/UnattendAuditInstaller.cs b/src/ServiceControlInstaller.Engine/Unattended/UnattendAuditInstaller.cs
index 7d7eca55c2..eb80879cdb 100644
--- a/src/ServiceControlInstaller.Engine/Unattended/UnattendAuditInstaller.cs
+++ b/src/ServiceControlInstaller.Engine/Unattended/UnattendAuditInstaller.cs
@@ -70,7 +70,7 @@ public async Task<bool> Add(ServiceControlAuditNewInstance details, Func<PathInf
             }
             catch (Exception ex)
             {
-                logger.Error(ex.Message);
+                logger.Error("Error installing the service: {0}", ex);
                 return false;
             }
 
@@ -137,7 +137,7 @@ public bool Upgrade(ServiceControlAuditInstance instance, bool force)
             }
             catch (Exception ex)
             {
-                logger.Error("Upgrade Failed: {0}", ex.Message);
+                logger.Error("Upgrade Failed: {0}", ex);
                 return false;
             }
 
diff --git a/src/ServiceControlInstaller.Engine/Unattended/UnattendMonitoringInstaller.cs b/src/ServiceControlInstaller.Engine/Unattended/UnattendMonitoringInstaller.cs
index 797c086045..b9640a02bb 100644
--- a/src/ServiceControlInstaller.Engine/Unattended/UnattendMonitoringInstaller.cs
+++ b/src/ServiceControlInstaller.Engine/Unattended/UnattendMonitoringInstaller.cs
@@ -69,7 +69,7 @@ public async Task<bool> Add(MonitoringNewInstance details, Func<PathInfo, Task<b
             }
             catch (Exception ex)
             {
-                logger.Error(ex.Message);
+                logger.Error("Error installing the service: {0}", ex);
                 return false;
             }
 
@@ -130,7 +130,7 @@ public bool Upgrade(MonitoringInstance instance)
             }
             catch (Exception ex)
             {
-                logger.Error("Upgrade Failed: {0}", ex.Message);
+                logger.Error("Upgrade Failed: {0}", ex);
                 return false;
             }
 
@@ -178,7 +178,7 @@ internal async Task<bool> Update(MonitoringInstance instance, bool startService)
             }
             catch (Exception ex)
             {
-                logger.Error("Update failed: {0}", ex.Message);
+                logger.Error("Update failed: {0}", ex);
                 return false;
             }
 
diff --git a/src/ServiceControlInstaller.Engine/Unattended/UnattendServiceControlInstaller.cs b/src/ServiceControlInstaller.Engine/Unattended/UnattendServiceControlInstaller.cs
index e96b84ebb3..ff2fc16964 100644
--- a/src/ServiceControlInstaller.Engine/Unattended/UnattendServiceControlInstaller.cs
+++ b/src/ServiceControlInstaller.Engine/Unattended/UnattendServiceControlInstaller.cs
@@ -61,7 +61,7 @@ public async Task<bool> Add(ServiceControlNewInstance details, Func<PathInfo, Ta
                 }
                 catch (Exception ex)
                 {
-                    logger.Error(ex.Message);
+                    logger.Error("Error installing the service: {0}", ex);
                     return false;
                 }
 
@@ -131,7 +131,7 @@ public bool Upgrade(ServiceControlInstance instance, ServiceControlUpgradeOption
             }
             catch (Exception ex)
             {
-                logger.Error("Upgrade Failed: {0}", ex.Message);
+                logger.Error("Upgrade Failed: {0}", ex);
                 return false;
             }
             finally
@@ -175,7 +175,7 @@ internal async Task<bool> Update(ServiceControlInstance instance, bool startServ
             }
             catch (Exception ex)
             {
-                logger.Error("Update failed: {0}", ex.Message);
+                logger.Error("Update failed: {0}", ex);
                 return false;
             }
             finally
@@ -270,7 +270,7 @@ public bool AddRemoteInstance(ServiceControlInstance instance, string[] remoteIn
             }
             catch (Exception ex)
             {
-                logger.Error("Adding remote instances Failed: {0}", ex.Message);
+                logger.Error("Adding remote instances Failed: {0}", ex);
                 return false;
             }
             finally
@@ -310,7 +310,7 @@ public bool RemoveRemoteInstance(ServiceControlInstance instance, string[] remot
             }
             catch (Exception ex)
             {
-                logger.Error("Removing remote instances Failed: {0}", ex.Message);
+                logger.Error("Removing remote instances Failed: {0}", ex);
                 return false;
             }
             finally

From 74343f6dcb86030c51e26d0326e6f48f59beadf6 Mon Sep 17 00:00:00 2001
From: Daniel Marbach <danielmarbach@users.noreply.github.com>
Date: Mon, 2 Mar 2026 15:58:55 +0100
Subject: [PATCH 2/2] Switch to source-generated JSON serialization for
 `RemoteInstanceConverter`

---
 .../ServiceControl/RemoteInstanceConverter.cs      | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/ServiceControlInstaller.Engine/Configuration/ServiceControl/RemoteInstanceConverter.cs b/src/ServiceControlInstaller.Engine/Configuration/ServiceControl/RemoteInstanceConverter.cs
index 412dd11723..535d47a61f 100644
--- a/src/ServiceControlInstaller.Engine/Configuration/ServiceControl/RemoteInstanceConverter.cs
+++ b/src/ServiceControlInstaller.Engine/Configuration/ServiceControl/RemoteInstanceConverter.cs
@@ -6,17 +6,15 @@
 
     public static class RemoteInstanceConverter
     {
-        public static List<RemoteInstanceSetting> FromJson(string json) => JsonSerializer.Deserialize<List<RemoteInstanceSetting>>(json, Options);
+        public static List<RemoteInstanceSetting> FromJson(string json) => JsonSerializer.Deserialize(json, RemoteInstanceContext.Default.ListRemoteInstanceSetting);
 
-        public static string ToJson(IList<RemoteInstanceSetting> settings) => JsonSerializer.Serialize(settings, Options);
-
-        static readonly JsonSerializerOptions Options = new()
-        {
-            WriteIndented = false,
-            DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull
-        };
+        public static string ToJson(List<RemoteInstanceSetting> settings) => JsonSerializer.Serialize(settings, RemoteInstanceContext.Default.ListRemoteInstanceSetting);
     }
 
+    [JsonSourceGenerationOptions(WriteIndented = false, DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull)]
+    [JsonSerializable(typeof(List<RemoteInstanceSetting>))]
+    public partial class RemoteInstanceContext : JsonSerializerContext;
+
     public class RemoteInstanceSetting
     {
         [JsonPropertyName("api_uri")]