From 026a60aebc23c9ab6373df7d5a9ae1e5d4354c9e Mon Sep 17 00:00:00 2001 From: "dependencyupdates[bot]" <218638057+dependencyupdates[bot]@users.noreply.github.com> Date: Sat, 7 Mar 2026 21:23:17 +0000 Subject: [PATCH 1/3] Update dependency NUnit.Analyzers to 4.12.0 --- src/Directory.Packages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index fa54c02e52..7dfad2157f 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -54,7 +54,7 @@ - + From ab9a1ebd7fa80b7e956f1ca25220d45f245e32de Mon Sep 17 00:00:00 2001 From: Tamara Rivera Date: Wed, 11 Mar 2026 13:35:30 -0700 Subject: [PATCH 2/3] Fix assert condition --- src/ServiceControl.Audit.Persistence.Tests/AuditTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ServiceControl.Audit.Persistence.Tests/AuditTests.cs b/src/ServiceControl.Audit.Persistence.Tests/AuditTests.cs index 9dcffaee85..52f360ae46 100644 --- a/src/ServiceControl.Audit.Persistence.Tests/AuditTests.cs +++ b/src/ServiceControl.Audit.Persistence.Tests/AuditTests.cs @@ -101,7 +101,7 @@ public async Task Can_roundtrip_message_body() Assert.That(retrievedMessage.Found, Is.True); Assert.That(retrievedMessage.HasContent, Is.True); Assert.That(retrievedMessage.ContentLength, Is.EqualTo(body.Length)); - Assert.That(retrievedMessage.ETag, Is.Not.Null.Or.Empty); + Assert.That(retrievedMessage.ETag, Is.Not.Null.And.Not.Empty); Assert.That(retrievedMessage.StreamContent, Is.Not.Null); Assert.That(retrievedMessage.ContentType, Is.EqualTo(expectedContentType)); }); From c0242289ef4239e636761b8c4a5c3b387a432d08 Mon Sep 17 00:00:00 2001 From: Mike Minutillo Date: Fri, 13 Mar 2026 09:44:51 +0800 Subject: [PATCH 3/3] In-memory body storage should set ETag Even if it is not used anywhere --- .../InMemoryAttachmentsBodyStorage.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ServiceControl.Audit.Persistence.InMemory/InMemoryAttachmentsBodyStorage.cs b/src/ServiceControl.Audit.Persistence.InMemory/InMemoryAttachmentsBodyStorage.cs index b46d3b1fac..d2193c57fe 100644 --- a/src/ServiceControl.Audit.Persistence.InMemory/InMemoryAttachmentsBodyStorage.cs +++ b/src/ServiceControl.Audit.Persistence.InMemory/InMemoryAttachmentsBodyStorage.cs @@ -1,5 +1,6 @@ namespace ServiceControl.Audit.Persistence.InMemory { + using System; using System.Collections.Generic; using System.IO; using System.Linq; @@ -60,7 +61,7 @@ public async Task TryFetch(string bodyId, CancellationToken cancel Stream = new MemoryStream(messageBody.Content), ContentType = messageBody.ContentType, BodySize = messageBody.BodySize, - Etag = string.Empty + Etag = Guid.NewGuid().ToString() }); }