From 9307b0c4f8136aff8552839cb86171dfc59b1f04 Mon Sep 17 00:00:00 2001 From: Dave Coleman Date: Wed, 4 Mar 2026 17:32:29 -0700 Subject: [PATCH 1/3] Clean up and improve lab_sim objectives - Wrap Open/Close Gripper in ForceSuccess instead of Sequence - Replace _Scan Scene and Scan Multiple Views with Scan Scene - Multiple Point Clouds - Rename Stack Blocks with ICP to Stack Objects with ICP - Rename show_grasp_link to Visualize Grasp Link - Remove Pick And Place Example (superseded) - Recategorize pick/place subtrees to Manipulation - Remove redundant _favorite="false" from subtrees - Make Move Along Square runnable Co-Authored-By: Claude Opus 4.6 --- src/lab_sim/objectives/_scan_scene.xml | 34 ----- src/lab_sim/objectives/close_gripper.xml | 4 +- ...nt.xml => computelinkposefromwaypoint.xml} | 10 +- src/lab_sim/objectives/grasp_planning.xml | 2 +- src/lab_sim/objectives/move_along_square.xml | 2 +- src/lab_sim/objectives/mpc_pose_tracking.xml | 2 +- ...th_static_sphere_point_cloud_avoidance.xml | 2 +- src/lab_sim/objectives/open_gripper.xml | 6 +- .../objectives/pick_and_place_example.xml | 44 ------- src/lab_sim/objectives/pick_from_pose.xml | 2 +- .../pick_from_pose_with_approval.xml | 2 +- src/lab_sim/objectives/pick_up_cube.xml | 10 +- src/lab_sim/objectives/place_at_pose.xml | 2 +- .../place_at_pose_with_approval.xml | 2 +- .../objectives/scan_multiple_views.xml | 26 ---- .../scan_scene_-_multiple_point_clouds.xml | 121 ++++++++++++++++++ .../objectives/stack_blocks_with_icp.xml | 6 +- ...rasp_link.xml => visualize_grasp_link.xml} | 6 +- 18 files changed, 152 insertions(+), 131 deletions(-) delete mode 100644 src/lab_sim/objectives/_scan_scene.xml rename src/lab_sim/objectives/{compute_linkpose_from_waypoint.xml => computelinkposefromwaypoint.xml} (88%) delete mode 100644 src/lab_sim/objectives/pick_and_place_example.xml delete mode 100644 src/lab_sim/objectives/scan_multiple_views.xml create mode 100644 src/lab_sim/objectives/scan_scene_-_multiple_point_clouds.xml rename src/lab_sim/objectives/{show_grasp_link.xml => visualize_grasp_link.xml} (82%) diff --git a/src/lab_sim/objectives/_scan_scene.xml b/src/lab_sim/objectives/_scan_scene.xml deleted file mode 100644 index 334a261c8..000000000 --- a/src/lab_sim/objectives/_scan_scene.xml +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - - - - - - - - - - - - - - - diff --git a/src/lab_sim/objectives/close_gripper.xml b/src/lab_sim/objectives/close_gripper.xml index 6960f3d7f..6e0a3e6dd 100644 --- a/src/lab_sim/objectives/close_gripper.xml +++ b/src/lab_sim/objectives/close_gripper.xml @@ -5,14 +5,14 @@ _description="Close the gripper" _favorite="false" > - + - + diff --git a/src/lab_sim/objectives/compute_linkpose_from_waypoint.xml b/src/lab_sim/objectives/computelinkposefromwaypoint.xml similarity index 88% rename from src/lab_sim/objectives/compute_linkpose_from_waypoint.xml rename to src/lab_sim/objectives/computelinkposefromwaypoint.xml index a231afb76..14ee2e031 100644 --- a/src/lab_sim/objectives/compute_linkpose_from_waypoint.xml +++ b/src/lab_sim/objectives/computelinkposefromwaypoint.xml @@ -1,13 +1,17 @@ - + - + diff --git a/src/lab_sim/objectives/grasp_planning.xml b/src/lab_sim/objectives/grasp_planning.xml index 34038f2e4..597d3ca41 100644 --- a/src/lab_sim/objectives/grasp_planning.xml +++ b/src/lab_sim/objectives/grasp_planning.xml @@ -9,7 +9,7 @@ - + diff --git a/src/lab_sim/objectives/move_along_square.xml b/src/lab_sim/objectives/move_along_square.xml index 6c8b72fbd..c5292a813 100644 --- a/src/lab_sim/objectives/move_along_square.xml +++ b/src/lab_sim/objectives/move_along_square.xml @@ -83,7 +83,7 @@ - + diff --git a/src/lab_sim/objectives/mpc_pose_tracking.xml b/src/lab_sim/objectives/mpc_pose_tracking.xml index fa7571e23..8ee08b702 100644 --- a/src/lab_sim/objectives/mpc_pose_tracking.xml +++ b/src/lab_sim/objectives/mpc_pose_tracking.xml @@ -12,7 +12,7 @@ ID="Move to Waypoint" _collapsed="true" joint_group_name="manipulator" - waypoint_name="Above Pick Cube" + waypoint_name="Above Pick Object" /> - + + - + - + diff --git a/src/lab_sim/objectives/pick_and_place_example.xml b/src/lab_sim/objectives/pick_and_place_example.xml deleted file mode 100644 index 6d2ad6b28..000000000 --- a/src/lab_sim/objectives/pick_and_place_example.xml +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - diff --git a/src/lab_sim/objectives/pick_from_pose.xml b/src/lab_sim/objectives/pick_from_pose.xml index e73286bbc..320baa47a 100644 --- a/src/lab_sim/objectives/pick_from_pose.xml +++ b/src/lab_sim/objectives/pick_from_pose.xml @@ -98,7 +98,7 @@ - + diff --git a/src/lab_sim/objectives/pick_from_pose_with_approval.xml b/src/lab_sim/objectives/pick_from_pose_with_approval.xml index aedfe8dae..dbfc65994 100644 --- a/src/lab_sim/objectives/pick_from_pose_with_approval.xml +++ b/src/lab_sim/objectives/pick_from_pose_with_approval.xml @@ -104,7 +104,7 @@ - + diff --git a/src/lab_sim/objectives/pick_up_cube.xml b/src/lab_sim/objectives/pick_up_cube.xml index fad39d504..3186a75e9 100644 --- a/src/lab_sim/objectives/pick_up_cube.xml +++ b/src/lab_sim/objectives/pick_up_cube.xml @@ -1,21 +1,21 @@ - + - + - + diff --git a/src/lab_sim/objectives/place_at_pose.xml b/src/lab_sim/objectives/place_at_pose.xml index 0862561b7..c50a95669 100644 --- a/src/lab_sim/objectives/place_at_pose.xml +++ b/src/lab_sim/objectives/place_at_pose.xml @@ -98,7 +98,7 @@ - + diff --git a/src/lab_sim/objectives/place_at_pose_with_approval.xml b/src/lab_sim/objectives/place_at_pose_with_approval.xml index 3ac6b6dca..981ac792a 100644 --- a/src/lab_sim/objectives/place_at_pose_with_approval.xml +++ b/src/lab_sim/objectives/place_at_pose_with_approval.xml @@ -97,7 +97,7 @@ - + diff --git a/src/lab_sim/objectives/scan_multiple_views.xml b/src/lab_sim/objectives/scan_multiple_views.xml deleted file mode 100644 index 16448fe6f..000000000 --- a/src/lab_sim/objectives/scan_multiple_views.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - - - - - - - - - - - - diff --git a/src/lab_sim/objectives/scan_scene_-_multiple_point_clouds.xml b/src/lab_sim/objectives/scan_scene_-_multiple_point_clouds.xml new file mode 100644 index 000000000..0f29542cc --- /dev/null +++ b/src/lab_sim/objectives/scan_scene_-_multiple_point_clouds.xml @@ -0,0 +1,121 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/lab_sim/objectives/stack_blocks_with_icp.xml b/src/lab_sim/objectives/stack_blocks_with_icp.xml index 0d7a55a53..0804e4c46 100644 --- a/src/lab_sim/objectives/stack_blocks_with_icp.xml +++ b/src/lab_sim/objectives/stack_blocks_with_icp.xml @@ -1,8 +1,8 @@ - + @@ -29,7 +29,7 @@ - + diff --git a/src/lab_sim/objectives/show_grasp_link.xml b/src/lab_sim/objectives/visualize_grasp_link.xml similarity index 82% rename from src/lab_sim/objectives/show_grasp_link.xml rename to src/lab_sim/objectives/visualize_grasp_link.xml index 97b1abb62..26ddff1cd 100644 --- a/src/lab_sim/objectives/show_grasp_link.xml +++ b/src/lab_sim/objectives/visualize_grasp_link.xml @@ -1,7 +1,7 @@ - + - + - + From 971fd0833663ba4fe1c2620104a73b3b63c999f2 Mon Sep 17 00:00:00 2001 From: Dave Coleman Date: Fri, 6 Mar 2026 12:45:37 -0700 Subject: [PATCH 2/3] Fix waypoint name to match objective XML Rename "Above Pick Cube" to "Above Pick Object" in ur_waypoints.yaml to match the updated objective references. Co-Authored-By: Claude Opus 4.6 --- src/lab_sim/objectives/move_along_square.xml | 2 +- src/lab_sim/waypoints/ur_waypoints.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lab_sim/objectives/move_along_square.xml b/src/lab_sim/objectives/move_along_square.xml index c5292a813..6c8b72fbd 100644 --- a/src/lab_sim/objectives/move_along_square.xml +++ b/src/lab_sim/objectives/move_along_square.xml @@ -83,7 +83,7 @@ - + diff --git a/src/lab_sim/waypoints/ur_waypoints.yaml b/src/lab_sim/waypoints/ur_waypoints.yaml index a74e2aa09..c03513913 100644 --- a/src/lab_sim/waypoints/ur_waypoints.yaml +++ b/src/lab_sim/waypoints/ur_waypoints.yaml @@ -40,7 +40,7 @@ transforms: [] twist: [] wrench: [] - name: Above Pick Cube + name: Above Pick Object - description: '' favorite: false joint_group_names: From 8730d811bf76683744c9cb55ea813a11129fb4c6 Mon Sep 17 00:00:00 2001 From: Nathan Brooks Date: Wed, 11 Mar 2026 15:25:27 -0600 Subject: [PATCH 3/3] Tune stall_velocity_threshold for lab_sim --- src/lab_sim/config/control/picknik_ur.ros2_control.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lab_sim/config/control/picknik_ur.ros2_control.yaml b/src/lab_sim/config/control/picknik_ur.ros2_control.yaml index 022396adb..eaeae0477 100644 --- a/src/lab_sim/config/control/picknik_ur.ros2_control.yaml +++ b/src/lab_sim/config/control/picknik_ur.ros2_control.yaml @@ -92,6 +92,7 @@ robotiq_gripper_controller: joint: robotiq_85_left_knuckle_joint allow_stalling: true stall_timeout: 0.05 + stall_velocity_threshold: 0.004 goal_tolerance: 0.02 force_torque_sensor_broadcaster: