hardcoded paths cause issues with immutable distro packaging

[michaelBelsanti]

I have been packaging falcond for NixOS, which requires many of the hardcoded paths be patched before the build. I think it would be a great change to support changing the default path of /usr/share/falcond.

Alongside this change, I think it would be a good improvement to have all the locally configurable files stored in /etc, the recommended FHS directory for static config files. Currently, custom game profiles are stored at /usr/share/falcond/profiles/user and the docs also mention modifying /usr/share/falcond/system.conf to add games.

I would recommend moving custom profiles to /etc/falcond/profiles and adding support for /usr/share/falcond/system.conf for adding additional games. If keeping backwards compatibility is important, it could also check these paths and the legacy paths.

I wanted to hear some thoughts on these changes before working on it, but if you're open to them I can work on a PR.

[ferrreo]

Yeah it is on my list to sort the hardcoded paths. It likely be a prefix you can specify you can specify at build time, is this enough for nix to work without extensive patching?

I don't think we'll be splitting the config directories at this time, it doesn't really gain anything useful and is an extra directory to watch (which has efficiency/perf implications). Not to mention all tooling would need updating too (falcond-gui and other people's guis) etc, as well as porting over people's existing profiles adds complexity for a one off. Also given they are text files and meant so that they can be shared - they meet the criteria for /usr/share.

[ferrreo]

@michaelBelsanti I've planned in the build changes for the next release - will likely be sometime this weekend.

[michaelBelsanti]

Awesome! I plan to upstream the nixpkgs module soon, currently waiting on scx-loader to be merged.

[ferrreo]

@michaelBelsanti I forgot to update here but the last two releases have build flags to set all the paths now