From 2e059f9c2e2cc6913ada1c182f16f8390390df8d Mon Sep 17 00:00:00 2001 From: Siim Raud Date: Tue, 16 Sep 2025 13:12:22 +0300 Subject: [PATCH 1/2] feat: extracting general errors from GraphQL responses --- .../javascript-api/src/lib/services/api-base/api-base.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/javascript-api/src/lib/services/api-base/api-base.ts b/packages/javascript-api/src/lib/services/api-base/api-base.ts index 6dabe0a8..181b7239 100644 --- a/packages/javascript-api/src/lib/services/api-base/api-base.ts +++ b/packages/javascript-api/src/lib/services/api-base/api-base.ts @@ -8,7 +8,6 @@ import { isSuccessResponse, } from '../../model/graphql-response.js'; import { RequestInit } from '../../model/fetch.js'; -import { ResponseValidationError } from '../../model/errors/response-validation-error.js'; type RequestInitWithMethodRequired = Pick & { body?: string | File | object; @@ -151,11 +150,7 @@ export class ApiBase { return graphQLResponse.data; } - throw new ResponseValidationError( - `Server response is not valid GraphQL response. Response: ${JSON.stringify( - graphQLResponse, - )}`, - ); + throw this.extractError(graphQLResponse); } private static extractError(response: any): Error { From 72d14b859e17224c3b38264fa6a4348cafe7f572 Mon Sep 17 00:00:00 2001 From: Siim Raud Date: Tue, 16 Sep 2025 13:15:08 +0300 Subject: [PATCH 2/2] Fixed tests --- .../javascript-api/src/lib/services/api-base/api-base.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/javascript-api/src/lib/services/api-base/api-base.spec.ts b/packages/javascript-api/src/lib/services/api-base/api-base.spec.ts index be9feb4b..a0edf77b 100644 --- a/packages/javascript-api/src/lib/services/api-base/api-base.spec.ts +++ b/packages/javascript-api/src/lib/services/api-base/api-base.spec.ts @@ -522,7 +522,7 @@ describe('ApiBase', () => { await Qminder.ApiBase.queryGraph(ME_ID.request); }).rejects.toThrow( new ResponseValidationError( - `Server response is not valid GraphQL response. Response: {}`, + 'Error occurred! Could not extract error message!', ), ); });