Enable the use of an already connected device in ipymovehub#42
Merged
HaudinFlorence merged 3 commits intoQuantStack:mainfrom Apr 9, 2025
Conversation
HaudinFlorence
force-pushed
the
enable_the_use_of_an_already_connected_device_in_ipymovehub
branch
from
0f47590 to
d45fd39
Compare
17 tasks
…e of already connected devices or not. Add an identifier attribute to the connect method in movehub.py.
HaudinFlorence
force-pushed
the
enable_the_use_of_an_already_connected_device_in_ipymovehub
branch
from
d45fd39 to
224680b
Compare
afshin
reviewed
Apr 2, 2025
| break; | ||
| case 'led': | ||
| this.movehub.led.call(this.movehub, args); | ||
| this.movehub.led.apply(this.movehub, args); |
Member
There was a problem hiding this comment.
Is this working? Unless args is an array, I think .call instead of .apply is correct, here, like it was before. Did you need to change it?
Member
Author
There was a problem hiding this comment.
In the lego-boost-browser librairy, it was using apply. I tried to change to call following the recommendations of the linter, but then the commands to change the led or move the robot were not effective (no error message but no action on the robot apart from switching of the led when trying to sweep all colors). So I went back on using apply.
Member
Author
|
@afshin Thanks for approving the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Case where devices are already connected
Screencast.From.2025-03-31.19-13-29.mp4
Case where no device is a connected
Screencast.From.2025-03-31.19-14-28.mp4